From: zhichaox.zeng@intel.com
To: dev@dpdk.org
Cc: stable@dpdk.org, qiming.yang@intel.com,
Zhichao Zeng <zhichaox.zeng@intel.com>,
alvinx.zhang@intel.com, Junfeng Guo <junfeng.guo@intel.com>,
Simei Su <simei.su@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: [PATCH v2] net/igc: fix segmentation fault in secondary dpdk-symmetric_mp
Date: Wed, 22 Jun 2022 18:49:07 +0800 [thread overview]
Message-ID: <20220622104907.862666-1-zhichaox.zeng@intel.com> (raw)
In-Reply-To: <20220615073915.13309-1-zhichaox.zeng@intel.com>
From: Zhichao Zeng <zhichaox.zeng@intel.com>
In the secondary dpdk-symmetric_mp process, the "smp_port_init" was
skipped, which cause some function pointers not to be initialized,
and a segmentation fault occurred when calling these function pointers.
This patch assigns initial values to rx_pkt_burst, tx_pkt_burst
and tx_pkt_prepare pointers to avoid calling null function pointer.
Fixes: 66fde1b943eb ("net/igc: add skeleton")
Cc: alvinx.zhang@intel.com
Cc: stable@dpdk.org
Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
---
v2:
remove unnecessary parameters, move declaration to relevant header file
---
drivers/net/igc/igc_ethdev.c | 3 +++
drivers/net/igc/igc_txrx.c | 6 +++---
drivers/net/igc/igc_txrx.h | 4 ++++
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c
index b9933b395d..25fb91bfec 100644
--- a/drivers/net/igc/igc_ethdev.c
+++ b/drivers/net/igc/igc_ethdev.c
@@ -1234,6 +1234,9 @@ eth_igc_dev_init(struct rte_eth_dev *dev)
dev->rx_queue_count = eth_igc_rx_queue_count;
dev->rx_descriptor_status = eth_igc_rx_descriptor_status;
dev->tx_descriptor_status = eth_igc_tx_descriptor_status;
+ dev->rx_pkt_burst = igc_recv_pkts;
+ dev->tx_pkt_burst = igc_xmit_pkts;
+ dev->tx_pkt_prepare = eth_igc_prep_pkts;
/*
* for secondary processes, we don't initialize any further as primary
diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c
index e48d5df11a..753ac8a411 100644
--- a/drivers/net/igc/igc_txrx.c
+++ b/drivers/net/igc/igc_txrx.c
@@ -345,7 +345,7 @@ rx_desc_get_pkt_info(struct igc_rx_queue *rxq, struct rte_mbuf *rxm,
rxm->packet_type = rx_desc_pkt_info_to_pkt_type(pkt_info);
}
-static uint16_t
+uint16_t
igc_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
{
struct igc_rx_queue * const rxq = rx_queue;
@@ -1397,7 +1397,7 @@ eth_igc_rx_queue_setup(struct rte_eth_dev *dev,
}
/* prepare packets for transmit */
-static uint16_t
+uint16_t
eth_igc_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,
uint16_t nb_pkts)
{
@@ -1604,7 +1604,7 @@ tx_desc_cksum_flags_to_olinfo(uint64_t ol_flags)
return tmp;
}
-static uint16_t
+uint16_t
igc_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
{
struct igc_tx_queue * const txq = tx_queue;
diff --git a/drivers/net/igc/igc_txrx.h b/drivers/net/igc/igc_txrx.h
index 535108a868..a5240df9d7 100644
--- a/drivers/net/igc/igc_txrx.h
+++ b/drivers/net/igc/igc_txrx.h
@@ -49,6 +49,10 @@ void eth_igc_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
struct rte_eth_txq_info *qinfo);
void eth_igc_vlan_strip_queue_set(struct rte_eth_dev *dev,
uint16_t rx_queue_id, int on);
+uint16_t igc_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts);
+uint16_t igc_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts);
+uint16_t eth_igc_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,
+ uint16_t nb_pkts);
#ifdef __cplusplus
}
#endif
--
2.25.1
next prev parent reply other threads:[~2022-06-22 10:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 7:39 [PATCH] " zhichaox.zeng
2022-06-16 2:49 ` Guo, Junfeng
2022-06-22 10:49 ` zhichaox.zeng [this message]
2022-06-23 3:50 ` [PATCH v2] " Zhang, Qi Z
2022-06-28 6:20 ` [PATCH v3] net/igc: move the initialization of data path into dev_init zhichaox.zeng
2022-06-28 7:00 ` Zhang, Qi Z
2022-06-30 11:03 ` [PATCH v4] net/igc: add support for secondary processes zhichaox.zeng
2022-06-30 11:47 ` Zhang, Qi Z
2022-07-01 3:13 ` Zeng, ZhichaoX
2022-07-01 3:47 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220622104907.862666-1-zhichaox.zeng@intel.com \
--to=zhichaox.zeng@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=junfeng.guo@intel.com \
--cc=qiming.yang@intel.com \
--cc=simei.su@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).