From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: "Stanisław Kardach" <kda@semihalf.com>
Cc: Ruifeng Wang <ruifeng.wang@arm.com>,
David Christensen <drc@linux.vnet.ibm.com>, dev <dev@dpdk.org>,
upstream@semihalf.com
Subject: Re: [PATCH 1/2] config: Use G++ as C++ compiler
Date: Wed, 22 Jun 2022 09:05:40 -0700 [thread overview]
Message-ID: <20220622160540.GA31911@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <CALVGJWJb0ndN--XNzNDUJ_+yQuRRxVN3dGb2T3KpcJ3HWKndSw@mail.gmail.com>
On Wed, Jun 22, 2022 at 07:07:12AM +0200, Stanisław Kardach wrote:
> On Tue, Jun 21, 2022 at 9:53 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> > <snip>
> > > -cpp = ['ccache', 'arm-linux-gnueabihf-cpp']
> > > +cpp = ['ccache', 'arm-linux-gnueabihf-g++']
> >
> > suggest the variable should be 'cxx' not 'cpp' (to be consistent with
> > other build systems in the linux world)
> The variable name is mandated by meson as it names C++ language "cpp"
> in other places:
> https://mesonbuild.com/Reference-tables.html#language-arguments-parameter-names
unfortunate the meson folks didn't do their research.
thanks for clarifying, you can disregard my suggestion then.
> --
> Best Regards,
> Stanisław Kardach
next prev parent reply other threads:[~2022-06-22 16:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 12:28 [PATCH 0/2] fix C++ include checks in cross-compilation Stanislaw Kardach
2022-06-21 12:28 ` [PATCH 1/2] config: Use G++ as C++ compiler Stanislaw Kardach
2022-06-21 14:25 ` Bruce Richardson
2022-06-21 19:53 ` Tyler Retzlaff
2022-06-22 5:07 ` Stanisław Kardach
2022-06-22 16:05 ` Tyler Retzlaff [this message]
2022-06-22 16:24 ` Morten Brørup
2022-06-21 12:28 ` [PATCH 2/2] ci: use crossbuild-essential packages Stanislaw Kardach
2022-06-23 8:04 ` David Marchand
2022-06-23 8:04 ` [PATCH 0/2] fix C++ include checks in cross-compilation David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220622160540.GA31911@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=kda@semihalf.com \
--cc=ruifeng.wang@arm.com \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).