From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E25F6A0545; Thu, 23 Jun 2022 04:35:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B6B840A82; Thu, 23 Jun 2022 04:35:25 +0200 (CEST) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 3F16E4069D for ; Thu, 23 Jun 2022 04:35:24 +0200 (CEST) Received: by mail-pg1-f173.google.com with SMTP id q140so17802182pgq.6 for ; Wed, 22 Jun 2022 19:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iqYLK0Y7upLbDnaqPsX5YZdyk2dlBpYqhvVQvear7Zk=; b=ZBQRm91GR7N0dMU6jU3zV97B53QmnxEaTrPSinGyU5uUdZN6abhvtGX2M02O4DtjAG ejoHqxPN3Y5SemHn7cTuZe43SPUaH70vefMFO5F42nqY/EEESppAIvV858qmCn6rSeyw 8mH5IohicB9XAu7fYuXkfClkuv0DcxDziwrssp+8PDOIyRL3OX/cbJ6a/nb7DA12PKpg Af8ha9yEk57tdUBLvvpyAgykXImfDAnmnySMh93eTpgvj4YEu0r94blX3IXsqpsu8BWh ko63szmF04EoBxVMRkVRBl14TdntWs5BatHFo5C2++Pv9Hq4h0xraZ8kHB8c6BBVedtE tHng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iqYLK0Y7upLbDnaqPsX5YZdyk2dlBpYqhvVQvear7Zk=; b=c2SI3WwcqdQBWyRzWLmmFuoX6eUAysEK8q/f6t2IcAOGiVvciGVGZFq7YVY8Oinyu8 6gkN8i+P17iM0Co9WH6QE3amzj2HYAscSI2Ea65H0g8DVEVV6zPVCzD6YmWAYqPb6WhY /YuaVlpjPlPMbduw1QnLIHTAQgFGyW23zeKkhPwKgjlhtLtJHjBhsTtKHHvx+Trbyn1t m0bfiLabzybzOyXwwhs4/BR49Y0pMsUWFVPCaIVmyw4IVCevplU7CmF+9UrBfrumoKlr JNdB+2Q6ZgjKPDGE6aazvPT2brvWOZ0dbLaZHHEMthZY/mn+Wel46EsVRcKihb8NSTrf MhUg== X-Gm-Message-State: AJIora+vSVzKGcMuUKlIfz0gywVFEfIR5KEe/PAd0Pf5DvvNbDAqaEsn wN0St6jC3a2XqyWoy8TUx9ZQcQ== X-Google-Smtp-Source: AGRyM1tw71WOoj7NWbOXf32HWt6D1VvO9PVIEfiRZ/JvUaeDSqmEGouXGMqBys4MZDdvDWy0sMIk3Q== X-Received: by 2002:a05:6a00:1306:b0:512:ca3d:392f with SMTP id j6-20020a056a00130600b00512ca3d392fmr38859330pfu.79.1655951723383; Wed, 22 Jun 2022 19:35:23 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id s10-20020a63af4a000000b003db7de758besm14186328pgo.5.2022.06.22.19.35.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 19:35:22 -0700 (PDT) Date: Wed, 22 Jun 2022 19:35:20 -0700 From: Stephen Hemminger To: Konstantin Ananyev Cc: Huichao Cai , dev@dpdk.org, konstantin.ananyev@intel.com Subject: Re: [PATCH] ip_frag: replace the rte memcpy with memcpy Message-ID: <20220622193520.16e7c2e5@hermes.local> In-Reply-To: References: <1655561380-64616-1-git-send-email-chcchc88@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 22 Jun 2022 23:49:39 +0100 Konstantin Ananyev wrote: > > @@ -26,7 +25,7 @@ static inline void __fill_ipv4hdr_frag(struct rte_ipv4_hdr *dst, > > const struct rte_ipv4_hdr *src, uint16_t header_len, > > uint16_t len, uint16_t fofs, uint16_t dofs, uint32_t mf) > > { > > - rte_memcpy(dst, src, header_len); > > + memcpy(dst, src, header_len); > > > I am fine with replacements in test and inside the lib, for cases > where 'len' parameter is constant value. > Though as I said before, here 'header_len' is not a constant value. > Are you sure it will not introduce any performance regression? Do you have any performance tests. The ip header options are very small.