DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] test/crypto: fix authentication IV for zuc SGL
@ 2022-06-23 14:31 Ciara Power
  2022-06-24  7:26 ` De Lara Guarch, Pablo
  0 siblings, 1 reply; 3+ messages in thread
From: Ciara Power @ 2022-06-23 14:31 UTC (permalink / raw)
  To: Akhil Goyal, Fan Zhang
  Cc: dev, kai.ji, pablo.de.lara.guarch, Ciara Power, stable

The wireless operation for ZUC SGL tests was being passed NULL instead
of a pointer to the test data authentication IV, and IV length 0.
This is now corrected to use the IV from the test data.

Fixes: 11c5485bb276 ("test/crypto: add scatter-gather tests for IP and OOP")
Cc: stable@dpdk.org

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 app/test/test_cryptodev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 1cac76a64a..d08f786324 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -6563,7 +6563,7 @@ test_zuc_auth_cipher_sgl(const struct wireless_test_data *tdata,
 	retval = create_wireless_algo_auth_cipher_operation(
 		tdata->digest.data, tdata->digest.len,
 		tdata->cipher_iv.data, tdata->cipher_iv.len,
-		NULL, 0,
+		tdata->auth_iv.data, tdata->auth_iv.len,
 		(tdata->digest.offset_bytes == 0 ?
 		(verify ? ciphertext_pad_len : plaintext_pad_len)
 			: tdata->digest.offset_bytes),
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] test/crypto: fix authentication IV for zuc SGL
  2022-06-23 14:31 [PATCH] test/crypto: fix authentication IV for zuc SGL Ciara Power
@ 2022-06-24  7:26 ` De Lara Guarch, Pablo
  2022-06-28  8:58   ` Akhil Goyal
  0 siblings, 1 reply; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2022-06-24  7:26 UTC (permalink / raw)
  To: Power, Ciara, Akhil Goyal, Zhang, Roy Fan; +Cc: dev, Ji, Kai, stable

Hi Ciara,

> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Thursday, June 23, 2022 4:32 PM
> To: Akhil Goyal <gakhil@marvell.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>
> Cc: dev@dpdk.org; Ji, Kai <kai.ji@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Power, Ciara <ciara.power@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] test/crypto: fix authentication IV for zuc SGL
> 
> The wireless operation for ZUC SGL tests was being passed NULL instead of a
> pointer to the test data authentication IV, and IV length 0.
> This is now corrected to use the IV from the test data.
> 
> Fixes: 11c5485bb276 ("test/crypto: add scatter-gather tests for IP and OOP")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] test/crypto: fix authentication IV for zuc SGL
  2022-06-24  7:26 ` De Lara Guarch, Pablo
@ 2022-06-28  8:58   ` Akhil Goyal
  0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2022-06-28  8:58 UTC (permalink / raw)
  To: De Lara Guarch, Pablo, Power, Ciara, Zhang, Roy Fan; +Cc: dev, Ji, Kai, stable

> >
> > The wireless operation for ZUC SGL tests was being passed NULL instead of a
> > pointer to the test data authentication IV, and IV length 0.
> > This is now corrected to use the IV from the test data.
> >
> > Fixes: 11c5485bb276 ("test/crypto: add scatter-gather tests for IP and OOP")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-06-28  8:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-23 14:31 [PATCH] test/crypto: fix authentication IV for zuc SGL Ciara Power
2022-06-24  7:26 ` De Lara Guarch, Pablo
2022-06-28  8:58   ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).