From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 092D9A0093;
Thu, 23 Jun 2022 18:43:27 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 259EC427EE;
Thu, 23 Jun 2022 18:43:07 +0200 (CEST)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by mails.dpdk.org (Postfix) with ESMTP id 0DA774280C
for <dev@dpdk.org>; Thu, 23 Jun 2022 18:43:02 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1656002583; x=1687538583;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=3R7YDQkLSJb0lMuB2SKKfDQinNEFHdqXX2l2iCPysLk=;
b=Oz6hIN7nA9nSoUuqakZbhCSR0lmPtSmtivYUGtUE/19+h8Wetk0y5aLX
S3b6/ypqX8nCo45aLcsHt4m+/ilAnU3YbNn3o3iiuYGAadA2ugWyNf7gh
8rfjJwiGoc7XCFiAy0oNhhoFv1f8eWKegkI7DjunZ6EBQqUHZf8K0HBfd
C4FkRLfB87NCismdfJb8HMsUE0xmtcZoFfm9EFJhOorUOJKsWb+fyPTws
mVMAx8paEqg30oG9vC2K/hHOdq1m0mSucWW0F8MJcX7hd/cy+gsduVnjw
WxKLRI/Yvg0b3Ng2Uup95P8Wzb2MSKZHmfgsWzcfb5SxKgMr0doHbPQ8Q w==;
X-IronPort-AV: E=McAfee;i="6400,9594,10386"; a="260589095"
X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="260589095"
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
23 Jun 2022 09:43:02 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="915267944"
Received: from silpixa00401385.ir.intel.com (HELO
silpixa00401385.ger.corp.intel.com.) ([10.237.223.125])
by fmsmga005.fm.intel.com with ESMTP; 23 Jun 2022 09:43:00 -0700
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: ciara.power@intel.com, fengchengwen@huawei.com, mb@smartsharesystems.com,
Bruce Richardson <bruce.richardson@intel.com>
Subject: [RFC PATCH 4/6] test/telemetry_json: add test for string character
escaping
Date: Thu, 23 Jun 2022 17:42:43 +0100
Message-Id: <20220623164245.561371-5-bruce.richardson@intel.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220623164245.561371-1-bruce.richardson@intel.com>
References: <20220623164245.561371-1-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Add unit test to validate that when creating a string response in json,
that characters such as \n or quotes are properly escaped.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/test/test_telemetry_json.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/app/test/test_telemetry_json.c b/app/test/test_telemetry_json.c
index 748b7cfe5a..955c2e5b1b 100644
--- a/app/test/test_telemetry_json.c
+++ b/app/test/test_telemetry_json.c
@@ -125,6 +125,22 @@ test_large_obj_element(void)
return strncmp(expected, buf, sizeof(buf));
}
+static int
+test_string_char_escaping(void)
+{
+ static const char str[] = "A string across\ntwo lines and \"with quotes\"!";
+ const char *expected = "\"A string across\\ntwo lines and \\\"with quotes\\\"!\"";
+ char buf[sizeof(str) + 10];
+ int used = 0;
+
+ used = rte_tel_json_str(buf, sizeof(buf), used, str);
+ printf("%s: buf = '%s', expected = '%s'\n", __func__, buf, expected);
+ if (used != (int)strlen(expected))
+ return -1;
+
+ return strncmp(expected, buf, sizeof(buf));
+}
+
typedef int (*test_fn)(void);
static int
@@ -138,6 +154,7 @@ test_telemetry_json(void)
test_overflow_obj,
test_large_array_element,
test_large_obj_element,
+ test_string_char_escaping,
};
for (i = 0; i < RTE_DIM(fns); i++)
if (fns[i]() == 0)
--
2.34.1