DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: maxime.coquelin@redhat.com, chenbo.xia@intel.com,
	stable@dpdk.org, Yuanhan Liu <yuanhan.liu@linux.intel.com>,
	Jens Freimann <jfreimann@redhat.com>
Subject: [PATCH 1/4] vhost: add some trailing newline in log messages
Date: Mon, 27 Jun 2022 11:27:25 +0200	[thread overview]
Message-ID: <20220627092728.78214-2-david.marchand@redhat.com> (raw)
In-Reply-To: <20220627092728.78214-1-david.marchand@redhat.com>

VHOST_LOG_* macros don't append a newline.
Add missing ones.

Fixes: e623e0c6d8a5 ("vhost: add reconnect ability")
Fixes: af1475918124 ("vhost: introduce API to start a specific driver")
Fixes: 2dfeebe26546 ("vhost: check return of mutex initialization")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/vhost/socket.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
index 7a0f63af14..24d60ca149 100644
--- a/lib/vhost/socket.c
+++ b/lib/vhost/socket.c
@@ -499,7 +499,7 @@ vhost_user_reconnect_init(void)
 
 	ret = pthread_mutex_init(&reconn_list.mutex, NULL);
 	if (ret < 0) {
-		VHOST_LOG_CONFIG(ERR, "%s: failed to initialize mutex", __func__);
+		VHOST_LOG_CONFIG(ERR, "%s: failed to initialize mutex\n", __func__);
 		return ret;
 	}
 	TAILQ_INIT(&reconn_list.head);
@@ -507,9 +507,9 @@ vhost_user_reconnect_init(void)
 	ret = rte_ctrl_thread_create(&reconn_tid, "vhost_reconn", NULL,
 			     vhost_user_client_reconnect, NULL);
 	if (ret != 0) {
-		VHOST_LOG_CONFIG(ERR, "failed to create reconnect thread");
+		VHOST_LOG_CONFIG(ERR, "failed to create reconnect thread\n");
 		if (pthread_mutex_destroy(&reconn_list.mutex))
-			VHOST_LOG_CONFIG(ERR, "%s: failed to destroy reconnect mutex", __func__);
+			VHOST_LOG_CONFIG(ERR, "%s: failed to destroy reconnect mutex\n", __func__);
 	}
 
 	return ret;
@@ -1170,8 +1170,8 @@ rte_vhost_driver_start(const char *path)
 			"vhost-events", NULL, fdset_event_dispatch,
 			&vhost_user.fdset);
 		if (ret != 0) {
-			VHOST_LOG_CONFIG(ERR, "(%s) failed to create fdset handling thread", path);
-
+			VHOST_LOG_CONFIG(ERR, "(%s) failed to create fdset handling thread\n",
+				path);
 			fdset_pipe_uninit(&vhost_user.fdset);
 			return -1;
 		}
-- 
2.36.1


  reply	other threads:[~2022-06-27  9:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-27  9:27 [PATCH 0/4] Vhost logs fixes and improvement David Marchand
2022-06-27  9:27 ` David Marchand [this message]
2022-06-29 13:28   ` [PATCH 1/4] vhost: add some trailing newline in log messages Xia, Chenbo
2022-06-27  9:27 ` [PATCH 2/4] vhost: restore device information " David Marchand
2022-06-29 13:34   ` Xia, Chenbo
2022-06-29 13:45     ` David Marchand
2022-06-29 13:49       ` Xia, Chenbo
2022-06-27  9:27 ` [PATCH 3/4] vhost: improve some datapath " David Marchand
2022-06-30 16:07   ` Maxime Coquelin
2022-06-27  9:27 ` [PATCH 4/4] vhost: prefix logs with context David Marchand
2022-06-30 16:13   ` Maxime Coquelin
2022-07-01  7:13     ` David Marchand
2022-07-01  7:56       ` Maxime Coquelin
2022-07-01  7:55 ` [PATCH v2 0/4] Vhost logs fixes and improvement David Marchand
2022-07-01  7:55   ` [PATCH v2 1/4] vhost: add some trailing newline in log messages David Marchand
2022-07-01  7:55   ` [PATCH v2 2/4] vhost: restore device information " David Marchand
2022-07-01  7:55   ` [PATCH v2 3/4] vhost: improve some datapath " David Marchand
2022-07-01  7:55   ` [PATCH v2 4/4] vhost: prefix logs with context David Marchand
2022-07-01  8:00     ` Maxime Coquelin
2022-07-01 13:20     ` [PATCH v3] " David Marchand
2022-07-01 14:00       ` Maxime Coquelin
2022-07-01 14:00   ` [PATCH v2 0/4] Vhost logs fixes and improvement Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220627092728.78214-2-david.marchand@redhat.com \
    --to=david.marchand@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=jfreimann@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).