DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: maxime.coquelin@redhat.com, chenbo.xia@intel.com
Subject: [PATCH 3/4] vhost: improve some datapath log messages
Date: Mon, 27 Jun 2022 11:27:27 +0200	[thread overview]
Message-ID: <20220627092728.78214-4-david.marchand@redhat.com> (raw)
In-Reply-To: <20220627092728.78214-1-david.marchand@redhat.com>

Those messages were missed when adding socket context.
Fix this.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/vhost/vhost.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h
index 4ebcb7448a..810bc71c9d 100644
--- a/lib/vhost/vhost.h
+++ b/lib/vhost/vhost.h
@@ -652,7 +652,7 @@ extern int vhost_data_log_level;
 	} \
 	snprintf(packet + strnlen(packet, VHOST_MAX_PRINT_BUFF), VHOST_MAX_PRINT_BUFF - strnlen(packet, VHOST_MAX_PRINT_BUFF), "\n"); \
 	\
-	VHOST_LOG_DATA(DEBUG, "%s", packet); \
+	VHOST_LOG_DATA(DEBUG, "(%s) %s", device->ifname, packet); \
 } while (0)
 #else
 #define PRINT_PACKET(device, addr, size, header) do {} while (0)
@@ -866,8 +866,8 @@ vhost_vring_call_split(struct virtio_net *dev, struct vhost_virtqueue *vq)
 		vq->signalled_used = new;
 		vq->signalled_used_valid = true;
 
-		VHOST_LOG_DATA(DEBUG, "%s: used_event_idx=%d, old=%d, new=%d\n",
-			__func__,
+		VHOST_LOG_DATA(DEBUG, "(%s) %s: used_event_idx=%d, old=%d, new=%d\n",
+			dev->ifname, __func__,
 			vhost_used_event(vq),
 			old, new);
 
-- 
2.36.1


  parent reply	other threads:[~2022-06-27  9:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-27  9:27 [PATCH 0/4] Vhost logs fixes and improvement David Marchand
2022-06-27  9:27 ` [PATCH 1/4] vhost: add some trailing newline in log messages David Marchand
2022-06-29 13:28   ` Xia, Chenbo
2022-06-27  9:27 ` [PATCH 2/4] vhost: restore device information " David Marchand
2022-06-29 13:34   ` Xia, Chenbo
2022-06-29 13:45     ` David Marchand
2022-06-29 13:49       ` Xia, Chenbo
2022-06-27  9:27 ` David Marchand [this message]
2022-06-30 16:07   ` [PATCH 3/4] vhost: improve some datapath " Maxime Coquelin
2022-06-27  9:27 ` [PATCH 4/4] vhost: prefix logs with context David Marchand
2022-06-30 16:13   ` Maxime Coquelin
2022-07-01  7:13     ` David Marchand
2022-07-01  7:56       ` Maxime Coquelin
2022-07-01  7:55 ` [PATCH v2 0/4] Vhost logs fixes and improvement David Marchand
2022-07-01  7:55   ` [PATCH v2 1/4] vhost: add some trailing newline in log messages David Marchand
2022-07-01  7:55   ` [PATCH v2 2/4] vhost: restore device information " David Marchand
2022-07-01  7:55   ` [PATCH v2 3/4] vhost: improve some datapath " David Marchand
2022-07-01  7:55   ` [PATCH v2 4/4] vhost: prefix logs with context David Marchand
2022-07-01  8:00     ` Maxime Coquelin
2022-07-01 13:20     ` [PATCH v3] " David Marchand
2022-07-01 14:00       ` Maxime Coquelin
2022-07-01 14:00   ` [PATCH v2 0/4] Vhost logs fixes and improvement Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220627092728.78214-4-david.marchand@redhat.com \
    --to=david.marchand@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).