* [PATCH] doc: add deprecation notice for kni example
@ 2022-06-30 16:50 Bruce Richardson
2022-07-01 2:17 ` Xia, Chenbo
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Bruce Richardson @ 2022-06-30 16:50 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson
As agreed by DPDK Technical Board, the KNI example app is due to be
removed from the repository to discourage use in future projects, given
that better alternatives exist.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
doc/guides/rel_notes/deprecation.rst | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 4e5b23c53d..ee36fc684d 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -125,3 +125,7 @@ Deprecation Notices
applications should be updated to use the ``dmadev`` library instead,
with the underlying HW-functionality being provided by the ``ioat`` or
``idxd`` dma drivers
+
+* examples/kni: The ``kni`` kernel module and library are not recommended for use by new applications -
+ other technologies such as virtio-user are recommended instead.
+ Because of this, the example application for kni is deprecated and will be removed in a future release.
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] doc: add deprecation notice for kni example
2022-06-30 16:50 [PATCH] doc: add deprecation notice for kni example Bruce Richardson
@ 2022-07-01 2:17 ` Xia, Chenbo
2022-07-01 8:18 ` David Marchand
2022-07-12 14:17 ` Thomas Monjalon
2 siblings, 0 replies; 9+ messages in thread
From: Xia, Chenbo @ 2022-07-01 2:17 UTC (permalink / raw)
To: Richardson, Bruce, dev; +Cc: Richardson, Bruce
> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Friday, July 1, 2022 12:51 AM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>
> Subject: [PATCH] doc: add deprecation notice for kni example
>
> As agreed by DPDK Technical Board, the KNI example app is due to be
> removed from the repository to discourage use in future projects, given
> that better alternatives exist.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 4e5b23c53d..ee36fc684d 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -125,3 +125,7 @@ Deprecation Notices
> applications should be updated to use the ``dmadev`` library instead,
> with the underlying HW-functionality being provided by the ``ioat`` or
> ``idxd`` dma drivers
> +
> +* examples/kni: The ``kni`` kernel module and library are not recommended
> for use by new applications -
> + other technologies such as virtio-user are recommended instead.
> + Because of this, the example application for kni is deprecated and will
> be removed in a future release.
> --
> 2.34.1
Acked-by: Chenbo Xia <chenbo.xia@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] doc: add deprecation notice for kni example
2022-06-30 16:50 [PATCH] doc: add deprecation notice for kni example Bruce Richardson
2022-07-01 2:17 ` Xia, Chenbo
@ 2022-07-01 8:18 ` David Marchand
2022-07-12 11:50 ` Jerin Jacob
2022-07-12 14:17 ` Thomas Monjalon
2 siblings, 1 reply; 9+ messages in thread
From: David Marchand @ 2022-07-01 8:18 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
On Thu, Jun 30, 2022 at 6:50 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> As agreed by DPDK Technical Board, the KNI example app is due to be
> removed from the repository to discourage use in future projects, given
> that better alternatives exist.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] doc: add deprecation notice for kni example
2022-07-01 8:18 ` David Marchand
@ 2022-07-12 11:50 ` Jerin Jacob
0 siblings, 0 replies; 9+ messages in thread
From: Jerin Jacob @ 2022-07-12 11:50 UTC (permalink / raw)
To: David Marchand; +Cc: Bruce Richardson, dev
On Fri, Jul 1, 2022 at 1:48 PM David Marchand <david.marchand@redhat.com> wrote:
>
> On Thu, Jun 30, 2022 at 6:50 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > As agreed by DPDK Technical Board, the KNI example app is due to be
> > removed from the repository to discourage use in future projects, given
> > that better alternatives exist.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: David Marchand <david.marchand@redhat.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
>
>
> --
> David Marchand
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] doc: add deprecation notice for kni example
2022-06-30 16:50 [PATCH] doc: add deprecation notice for kni example Bruce Richardson
2022-07-01 2:17 ` Xia, Chenbo
2022-07-01 8:18 ` David Marchand
@ 2022-07-12 14:17 ` Thomas Monjalon
2022-07-13 5:52 ` Andrew Rybchenko
2022-07-13 8:14 ` Bruce Richardson
2 siblings, 2 replies; 9+ messages in thread
From: Thomas Monjalon @ 2022-07-12 14:17 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, chenbo.xia, david.marchand, jerinj, ferruh.yigit
30/06/2022 18:50, Bruce Richardson:
> +* examples/kni: The ``kni`` kernel module and library are not recommended for use by new applications -
> + other technologies such as virtio-user are recommended instead.
> + Because of this, the example application for kni is deprecated and will be removed in a future release.
Acked-by: Thomas Monjalon <thomas@monjalon.net>
I think it would have been better to give a precise timeline.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] doc: add deprecation notice for kni example
2022-07-12 14:17 ` Thomas Monjalon
@ 2022-07-13 5:52 ` Andrew Rybchenko
2022-07-13 8:14 ` Bruce Richardson
1 sibling, 0 replies; 9+ messages in thread
From: Andrew Rybchenko @ 2022-07-13 5:52 UTC (permalink / raw)
To: Thomas Monjalon, Bruce Richardson; +Cc: dev, chenbo.xia, david.marchand, jerinj
On 7/12/22 17:17, Thomas Monjalon wrote:
> 30/06/2022 18:50, Bruce Richardson:
>> +* examples/kni: The ``kni`` kernel module and library are not recommended for use by new applications -
>> + other technologies such as virtio-user are recommended instead.
>> + Because of this, the example application for kni is deprecated and will be removed in a future release.
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
> I think it would have been better to give a precise timeline.
+1
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] doc: add deprecation notice for kni example
2022-07-12 14:17 ` Thomas Monjalon
2022-07-13 5:52 ` Andrew Rybchenko
@ 2022-07-13 8:14 ` Bruce Richardson
2022-07-13 9:11 ` Thomas Monjalon
1 sibling, 1 reply; 9+ messages in thread
From: Bruce Richardson @ 2022-07-13 8:14 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, chenbo.xia, david.marchand, jerinj, ferruh.yigit
On Tue, Jul 12, 2022 at 04:17:31PM +0200, Thomas Monjalon wrote:
> 30/06/2022 18:50, Bruce Richardson:
> > +* examples/kni: The ``kni`` kernel module and library are not recommended for use by new applications -
> > + other technologies such as virtio-user are recommended instead.
> > + Because of this, the example application for kni is deprecated and will be removed in a future release.
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
> I think it would have been better to give a precise timeline.
>
I intentionally left it vague in case we decided to defer removal for a
release or anything. However, feel free to replace "in a future" release
with "in 22.11 release" on apply if you like.
/Bruce
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] doc: add deprecation notice for kni example
2022-07-13 8:14 ` Bruce Richardson
@ 2022-07-13 9:11 ` Thomas Monjalon
2022-07-13 16:13 ` Thomas Monjalon
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Monjalon @ 2022-07-13 9:11 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, chenbo.xia, david.marchand, jerinj, ferruh.yigit
13/07/2022 10:14, Bruce Richardson:
> On Tue, Jul 12, 2022 at 04:17:31PM +0200, Thomas Monjalon wrote:
> > 30/06/2022 18:50, Bruce Richardson:
> > > +* examples/kni: The ``kni`` kernel module and library are not recommended for use by new applications -
> > > + other technologies such as virtio-user are recommended instead.
> > > + Because of this, the example application for kni is deprecated and will be removed in a future release.
> >
> > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > I think it would have been better to give a precise timeline.
> >
> I intentionally left it vague in case we decided to defer removal for a
> release or anything. However, feel free to replace "in a future" release
> with "in 22.11 release" on apply if you like.
I won't do such change myself, too much critical.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] doc: add deprecation notice for kni example
2022-07-13 9:11 ` Thomas Monjalon
@ 2022-07-13 16:13 ` Thomas Monjalon
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2022-07-13 16:13 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, chenbo.xia, david.marchand, jerinj, ferruh.yigit
13/07/2022 11:11, Thomas Monjalon:
> 13/07/2022 10:14, Bruce Richardson:
> > On Tue, Jul 12, 2022 at 04:17:31PM +0200, Thomas Monjalon wrote:
> > > 30/06/2022 18:50, Bruce Richardson:
> > > > +* examples/kni: The ``kni`` kernel module and library are not recommended for use by new applications -
> > > > + other technologies such as virtio-user are recommended instead.
> > > > + Because of this, the example application for kni is deprecated and will be removed in a future release.
> > >
> > > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> > >
> > > I think it would have been better to give a precise timeline.
> > >
> > I intentionally left it vague in case we decided to defer removal for a
> > release or anything. However, feel free to replace "in a future" release
> > with "in 22.11 release" on apply if you like.
>
> I won't do such change myself, too much critical.
I've sent a new deprecation which updates Ferruh's one,
and squash parts of this one about the example:
https://patches.dpdk.org/project/dpdk/patch/20220713161047.121805-1-thomas@monjalon.net/
Please review quickly.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-07-13 16:13 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-30 16:50 [PATCH] doc: add deprecation notice for kni example Bruce Richardson
2022-07-01 2:17 ` Xia, Chenbo
2022-07-01 8:18 ` David Marchand
2022-07-12 11:50 ` Jerin Jacob
2022-07-12 14:17 ` Thomas Monjalon
2022-07-13 5:52 ` Andrew Rybchenko
2022-07-13 8:14 ` Bruce Richardson
2022-07-13 9:11 ` Thomas Monjalon
2022-07-13 16:13 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).