DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: venkatesh bs <venki.bsv@gmail.com>
Cc: dev@dpdk.org
Subject: Re: clarification on RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF flag
Date: Wed, 6 Jul 2022 08:22:56 -0700	[thread overview]
Message-ID: <20220706082256.562c1b69@hermes.local> (raw)
In-Reply-To: <CAM3UhOh04CFR16puEnQ0YVso8ucvanpJBsyW+-KxV0yJewXovg@mail.gmail.com>

On Wed, 6 Jul 2022 19:07:54 +0530
venkatesh bs <venki.bsv@gmail.com> wrote:

> Hi All,
> 
> In multithreaded/Multicore  environment can we use
> RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF
> independently,
> or this flag should always be used with
> RTE_HASH_EXTRA_FLAGS_MULTI_WRITER_ADD.
> 
> We are trying to create and access the hash table with
> RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF
> only.
> We are getting crashes in multi core environments , we debugged nothing
> wrong in the application , everything looks good.
> 
> We call rte_hash_del_key() first and from the returned position we are
> calling rte_hash_free_key_with_position().
> 
> Please let me know if we missed something.
> 
> Thanks,
> Venkatesh.

Repeating same question doesn't get answer faster.

Read the code, it is fairly straightforward.

The multi-writer add means that writers take a lock.
If doing lock free support then:
  1. It is up to your application to use a single writer and/or
     wrap writer calls in a lock.

  2. You need to use RCU mechanism to guarantee that no reader
     will access a deleted entry. Something like:

     rte_hash_del_key()
     synchronize_rcu()
     rte_hash_free_key_with_position()

     You can use either the DPDK RCU library or the userspace RCU library.
     Read that documentation, RCU is non-trivial change.



  parent reply	other threads:[~2022-07-06 15:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06  3:45 venkatesh bs
2022-07-06 13:37 ` venkatesh bs
2022-07-06 14:21   ` venkatesh bs
2022-07-06 15:22   ` Stephen Hemminger [this message]
2022-07-08 17:52     ` Honnappa Nagarahalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220706082256.562c1b69@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=venki.bsv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).