From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A54FA0540; Wed, 6 Jul 2022 17:27:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C950540687; Wed, 6 Jul 2022 17:27:40 +0200 (CEST) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id 1BDB540156 for ; Wed, 6 Jul 2022 17:27:38 +0200 (CEST) Received: by mail-pj1-f53.google.com with SMTP id y14-20020a17090a644e00b001ef775f7118so12374454pjm.2 for ; Wed, 06 Jul 2022 08:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1Zf3q3MLbC14kXdhAUHdGUcbcshI/JJCGdPi0inChxE=; b=fIIf3nf2Lj82wHZ0Zsv+cBc/QPCoyqdQRPXK4LBvNeAAhv8R/66hgGgymGxrgKsK1M +yUF17X4mHA4VnWgILPMGbqA7W30VY4zGn+EcLCkQPrMDtA3dswyjPSHg6HZ7Gl7S/Ao aAtNzQhrIY78hm0EdsjDAZ7vyEHULtF3WHz2y+N+qUN0ncTSGEfHy+jFR38JJO7zg6d+ tTAsCw5D4CZ5WwvRp7NsPDLlFPrfHumZl1N+dTPWwmaFQOmyh+9A21Qqc9wfeYCq0aLS 3w9JEpCvlkP4ATOnUcuQQ0NmiIfy76a+KLUdMfsP5cc9HzfzCxeJBj0P+ZGdBKBkIqSn VYYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1Zf3q3MLbC14kXdhAUHdGUcbcshI/JJCGdPi0inChxE=; b=2hsikp0vq8KKEdL2N1mb5Uu6sYnUF+UrEHvIW+Pa1t56kmsNh1K+gevr324fGbvuoa xDgJJ4+xZQXDLLHBih6h0V3wSl71iNBEHsgCULH/5iJ7l0FyEm43bq8QoUT2GB93WB0V lA5qQ/Ah5p2PiLquR0QwAVxApwrGSBiroa4kz+meTLnjQiloU3cE0RgCgm7CmuXAuxoI DI1ojssFO6ejpVJCozAnbERinmBZe8Bcz5OPntQa7IeZBcpvb1OlwWEHaDOIJlRqWhJc aboVLy5L4/2WsmIdvEgSUd4rRlrPTXrQp67xjR5pgvRlB4Cq4LDen1xhVVRUcQOBsEGz V+SQ== X-Gm-Message-State: AJIora9afQpGAo9js4ggUMY6rFap2c7XS0k1uDwnKqBTHszpEuq7UHfC +At7zRjzU3v2N6ZL3KGjBVyMKw== X-Google-Smtp-Source: AGRyM1vTiAuv+SWHHmxcjoM2dCVyxZ43+CblK3V8ZydEJFU6oEcSp+iOYL65Eupe8830fb4XFCMK5g== X-Received: by 2002:a17:902:728d:b0:16b:ee0d:1766 with SMTP id d13-20020a170902728d00b0016bee0d1766mr12436212pll.4.1657121258025; Wed, 06 Jul 2022 08:27:38 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id w190-20020a6262c7000000b00528655cd6a6sm6284165pfb.53.2022.07.06.08.27.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 08:27:37 -0700 (PDT) Date: Wed, 6 Jul 2022 08:27:34 -0700 From: Stephen Hemminger To: Aman Kumar Cc: dev@dpdk.org, maxime.coquelin@redhat.com, david.marchand@redhat.com Subject: Re: [RFC PATCH 04/29] net/qdma: add logging support Message-ID: <20220706082734.0e24f587@hermes.local> In-Reply-To: <20220706075219.517046-5-aman.kumar@vvdntech.in> References: <20220706075219.517046-1-aman.kumar@vvdntech.in> <20220706075219.517046-5-aman.kumar@vvdntech.in> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 6 Jul 2022 13:21:54 +0530 Aman Kumar wrote: > +extern int qdma_logtype_pmd; > +#define PMD_DRV_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, qdma_logtype_pmd, "%s(): " \ > + fmt "\n", __func__, ## args) Did you test this. Looks like your log messages are going to end up double spaced. Because many of the later calls put a newline on the message. Example: + PMD_DRV_LOG(INFO, "QDMA devargs desc_prefetch is: %s\n", value);