From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AA54A0540; Wed, 6 Jul 2022 23:46:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92BCC42836; Wed, 6 Jul 2022 23:46:36 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 667704069D; Wed, 6 Jul 2022 23:46:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657143994; x=1688679994; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xWdya+bXkbPwocA/c6mDgcqEZR/Jc50alGoXyIJNrLY=; b=hATEnMsumg6//z59Uot6P8UIyrfr7Ljrtcna7+bXiFDL/qbOEQs4ONul U0ocA9iLLdDkB/EIi1Xtg6Mgvjtz5snQ7x9Q7LcnO3kcIZtfXZ0zRxMZT i1KmVWKzTKZl5myobjfV7sNIVBKyf8PQ7kp3VTsvxt5/XI88CE6Q8BPF6 w7WsUcmGoJibzD3uH9xechbnZTdZvKsITL1XuclqVC9oZtxvQ5UIFltm+ VwPdcuBClwoMJ9qNMi6J4UsGtpTo9l2uQyOdrZYylAc5Ccvt3ruN1ebCj FxMxKYcWachHDRy4NsE7IzqdqZQ3Zb1pzYikJOF4YXzRNRQskdpYENRYD Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10400"; a="347859739" X-IronPort-AV: E=Sophos;i="5.92,251,1650956400"; d="scan'208";a="347859739" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2022 14:46:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,251,1650956400"; d="scan'208";a="650855400" Received: from txanpdk03.an.intel.com ([10.123.117.78]) by fmsmga008.fm.intel.com with ESMTP; 06 Jul 2022 14:46:32 -0700 From: Timothy McDaniel To: timothy.mcdaniel@intel.com Cc: dev@dpdk.org, jerinj@marvell.com, jerinjacobk@gmail.com, stable@dpdk.org Subject: [PATCH v2 2/2] event/dlb2: improve cq_weight error messages Date: Wed, 6 Jul 2022 16:46:28 -0500 Message-Id: <20220706214628.2375117-3-timothy.mcdaniel@intel.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220706214628.2375117-1-timothy.mcdaniel@intel.com> References: <20220706213141.2374006-2-timothy.mcdaniel@intel.com> <20220706214628.2375117-1-timothy.mcdaniel@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This commit changes 2 error messages to better describe cq_weight related errors, should one occur. Fixes: ffa46fc4a2b5 ("event/dlb2: support CQ weight") Cc: stable@dpdk.org Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 4 ++-- drivers/event/dlb2/pf/base/dlb2_resource.c | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 93bf215762..5a443acff8 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/drivers/event/dlb2/dlb2.c @@ -1527,8 +1527,8 @@ dlb2_hw_create_ldb_port(struct dlb2_eventdev *dlb2, if (dlb2->version == DLB2_HW_V2 && ev_port->cq_weight != 0 && ev_port->cq_weight > dequeue_depth) { - DLB2_LOG_ERR("dlb2: invalid cq depth, must be >= cq weight%d\n", - DLB2_MIN_ENQUEUE_DEPTH); + DLB2_LOG_ERR("dlb2: invalid cq dequeue depth %d, must be >= cq weight %d\n", + dequeue_depth, ev_port->cq_weight); return -EINVAL; } diff --git a/drivers/event/dlb2/pf/base/dlb2_resource.c b/drivers/event/dlb2/pf/base/dlb2_resource.c index e73d289445..0731416a43 100644 --- a/drivers/event/dlb2/pf/base/dlb2_resource.c +++ b/drivers/event/dlb2/pf/base/dlb2_resource.c @@ -6397,6 +6397,9 @@ dlb2_verify_enable_cq_weight_args(struct dlb2_hw *hw, struct dlb2_ldb_port *port; if (hw->ver == DLB2_HW_V2) { + DLB2_HW_ERR(hw, + "[%s():%d] CQ weight feature requires DLB 2.5 or later\n", + __func__, __LINE__); resp->status = DLB2_ST_FEATURE_UNAVAILABLE; return -EINVAL; } -- 2.25.1