From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 861B4A0032; Sat, 9 Jul 2022 18:30:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 251414021F; Sat, 9 Jul 2022 18:30:25 +0200 (CEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 41A194021E for ; Sat, 9 Jul 2022 18:30:24 +0200 (CEST) Received: by mail-pf1-f181.google.com with SMTP id y141so1479975pfb.7 for ; Sat, 09 Jul 2022 09:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GPCmdtKjT8FHmuc8SZYiLPo4LoV1aY6QoOlbCvAxDmE=; b=NP8hMDMyBt1a1qcIHhFcJe59yPZOJyIgMMwJM+xcXRRSkU3QxfXszqB9ca/ueI8eam MKIJ3uqD4K2/lz5HKYKFAmndR1hXert47cfKLibyhbNZrMEpGuzio7WdFVem8v7l55x7 UBBUQQpMS7q/Z2Bm+L5EzPrL0FLdgNEfBJa7Oyhv2l2jPMcFZYs80zr2uy8lqELUahlg QPGowWOfSQSFTOYN9Y+fhZhFdOWKXdRHmBQthMON5PK+D/RxM5eahS1l8vtqfvnLYm3D 7Ia+IF2Qr18iGnjV3rlMSaGLxndq2OzJNZCakDNjB75t4Xx0pCpXFeD+JRN/DhMtHGkl uqAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GPCmdtKjT8FHmuc8SZYiLPo4LoV1aY6QoOlbCvAxDmE=; b=aFM301R8lTADqjoLV7oGP7OzXSNwTqemyBAcZHpMSHTW2Eia8Ls4RzMwbUKT7/6Eb1 NP+u+wNomywMyeIkYnt65INx8/Fp/fFFs6EM7GCJK2BaYuSi5tDyCqsv1PU3I6K8uhYw xmZKsS8EKsIxeOhkAU90Lqevsh3JJq5rDywUSFqBQz0ods0fZzuVvJAd4liBjsEvJt9k NHbPNfbV2trJw4QXOpxaVw6ECC4jlVGYo9f6R6ndbyXAHmHqNO+WZ7dwcgLiN54r929G QHvwFPFMCj+5w+eJQQ/AmnlAQfKWTGRb9v5fqkyecJpnrpfVVBfiE2wwZSd5vLB8TLfy Hckw== X-Gm-Message-State: AJIora/bqXHZ90YoEkeM+G3wYr/fgL1rLEHWyDwkmb5LaMR9818Crp1b i18C5rHKCWZAh9+NzaHAuaGwvg== X-Google-Smtp-Source: AGRyM1uxndx3mkCv/GzB4r83YqcCLKf4R16hxG/g+jdGj4jEPvnf7mDknVrDNSZtZLTipdO15LvMmg== X-Received: by 2002:a63:86c8:0:b0:415:366c:f287 with SMTP id x191-20020a6386c8000000b00415366cf287mr8217870pgd.309.1657384223165; Sat, 09 Jul 2022 09:30:23 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id h20-20020a63df54000000b0040c9213a414sm1309832pgj.46.2022.07.09.09.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jul 2022 09:30:22 -0700 (PDT) Date: Sat, 9 Jul 2022 09:30:20 -0700 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org Subject: Re: [RFC v2 v2 00/29] Bus and device cleanup for 22.11 Message-ID: <20220709093020.05a50553@hermes.local> In-Reply-To: <20220709082644.664675-1-david.marchand@redhat.com> References: <20220628144643.1213026-1-david.marchand@redhat.com> <20220709082644.664675-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 9 Jul 2022 10:26:15 +0200 David Marchand wrote: > This is a PoC for hiding the rte_bus, rte_driver and rte_device objects. > And mark associated driver only API as internal. > > A good amount of the patches are preparation work on rte_bus.h, > rte_dev.h, rte_devargs.h and rte_eal.h headers, removing dependencies > between them. This is something I had in store for some time, maybe I > should have dropped it from the PoC, but I think those cleanups are > worth it in any case. > > Then PCI bus specific handling are moved from unit tests and examples, > though there is still a special case left in testpmd that may require a > new API, to be discussed. > > After this series, driver-only API headers for registering to buses are > not exported anymore, unless the enable_driver_sdk meson option is > selected. > > New accessors for rte_bus, rte_driver and rte_device have been added, > marked with an experimental tag though we may declare them as stable > right away so that users can switch to them directly. That's also > something to agree on. > > I simplified my series and switched to only update "external" users, > like app/ and examples/ files. > We need some checkpatch new checks to be sure we won't get some > driver-only headers included in these areas. That's something I'll work > on in the non RFC series. > > "Internal" users are simply using the internal headers. That helps > greatly reducing the size of the changes. > > Disclaimer: again, in this v2, this series is a bit rushed (I brute forced > compilation tests in GHA so that it passes between patches, but there still > may be something broken...). > Not surprisingly, the ABI check in the CI is expected to fail. > > > Comments welcome. Looks good to me, lots of work but will the separation internal and external API's will help in future.