From: Stephen Hemminger <stephen@networkplumber.org>
To: tadhgkearney <tadhg.kearney@intel.com>
Cc: dev@dpdk.org, dave.hunt@intel.com, anatoly.burakov@intel.com,
reshma.pattan@intel.com
Subject: Re: [PATCH v1 1/4] power: add uncore api to power library
Date: Mon, 11 Jul 2022 09:36:45 -0700 [thread overview]
Message-ID: <20220711093645.1ce3118c@hermes.local> (raw)
In-Reply-To: <20220711162300.3308684-2-tadhg.kearney@intel.com>
On Mon, 11 Jul 2022 16:22:57 +0000
tadhgkearney <tadhg.kearney@intel.com> wrote:
> + FILE *f_cur_min; /**< FD of scaling_min */
> + FILE *f_cur_max; /**< FD of scaling_max */
> + FILE *f_base_min; /**< FD of initial min */
> + FILE *f_base_max; /**< FD of initial max */
Do you need to hold these extra FD's open?
Also wasteful to use stdio for simple control sysfs like this.
next prev parent reply other threads:[~2022-07-11 16:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 16:22 [PATCH v1 0/4] add uncore api to be called through l3fwd-power tadhgkearney
2022-07-11 16:22 ` [PATCH v1 1/4] power: add uncore api to power library tadhgkearney
2022-07-11 16:36 ` Stephen Hemminger [this message]
2022-07-14 14:56 ` Kearney, Tadhg
2022-07-14 16:03 ` Stephen Hemminger
2022-07-11 16:22 ` [PATCH v1 2/4] l3fwd-power: add option to call uncore api tadhgkearney
2022-07-11 16:22 ` [PATCH v1 3/4] test/power: add unit tests for " tadhgkearney
2022-07-11 16:23 ` [PATCH v1 4/4] config: add uncore defines for x86 tadhgkearney
2022-07-11 16:56 ` [PATCH v1 0/4] add uncore api to be called through l3fwd-power Pattan, Reshma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220711093645.1ce3118c@hermes.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=dave.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=tadhg.kearney@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).