From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF3BEA0032; Mon, 11 Jul 2022 18:36:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6989F40DF6; Mon, 11 Jul 2022 18:36:50 +0200 (CEST) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 1162540C35 for <dev@dpdk.org>; Mon, 11 Jul 2022 18:36:49 +0200 (CEST) Received: by mail-pl1-f177.google.com with SMTP id v21so2376981plo.0 for <dev@dpdk.org>; Mon, 11 Jul 2022 09:36:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=di67T/tD49Mp5sk29AruVetrZnp4daPRmMLADJOYyQo=; b=gPAuPus+8/nsqDuo2YNxpkPM+naNp3agnPAwQyyGpm1OQKXDlgoEWv2NDRvPs+mGPL Qy4xTksDXt5JEVprxJXYCSH2HGx3jLobA8j3U7UsK77U7w/uPV2EwNzeznqdpMbeNWQc t3Hx1Q605WIOzqNde+eXE36WJc8K4D/+NBNSJ7ONUHr4cP+C8qPO6LtqWsQg6Kn9MYXj gFPsY91eF3DmLJqM+Ve+Luj+Ay8r2meCMAIe479zFrBPuAlLvZHjAJ+bOYcaVrloMPOb L+g4QdPms0+xd1kdiiMp1IjI4yNfmuAJeo4T6UPK3j20fON7tVIFelg3ksj2KHl9WiBl Y6Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=di67T/tD49Mp5sk29AruVetrZnp4daPRmMLADJOYyQo=; b=Sw3l5gfXu4l6+WDB9dWbpo70LxPmYERgWCT72Nr7PwVNHwPmNxx8Yaqjhpdsp4ZVqU geQrA/2KPn8LULLvJG11+LU62xSAJMfym9G0T7y0sFq05Sh1V65fA6IeXwchrEtGuy7X zlxILv3NWjMRa2w6vHbkTYCuEfsl6VmiH0tJjZJo0dz8m4xm2mXziN6XjWnt4FeZKZbH 6UVwLxfe7my0BRYzgDgGoEjEE8mFpI9HBsXGtR5QTaazPQktA9RU9VSTuxMEcN++yC4o r2fB9OjhuLBbN5vphPKoGzBphGii6O9A2ro+gQSlwCO4FjD6qPKPpQ6yWusLMJdpNr6k xCbw== X-Gm-Message-State: AJIora9+rpkv3JOvIOG6pduOlDktExdsKZaUl/GUaOZ/qsuf/WICAcRs yPc6yraziJG0d83bgmMA4DYQiQ== X-Google-Smtp-Source: AGRyM1s38OeAYR/B7kCoXFzGucoGB9+i3j0QV7fuYc4EQMZ3Wf0GcUg1zHZ0VOcwhG/Ug8e4jTb42g== X-Received: by 2002:a17:90a:7ac4:b0:1ef:a606:4974 with SMTP id b4-20020a17090a7ac400b001efa6064974mr18949900pjl.51.1657557408249; Mon, 11 Jul 2022 09:36:48 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ka19-20020a17090b475300b001ec798b0dc4sm4991517pjb.38.2022.07.11.09.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 09:36:47 -0700 (PDT) Date: Mon, 11 Jul 2022 09:36:45 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: tadhgkearney <tadhg.kearney@intel.com> Cc: dev@dpdk.org, dave.hunt@intel.com, anatoly.burakov@intel.com, reshma.pattan@intel.com Subject: Re: [PATCH v1 1/4] power: add uncore api to power library Message-ID: <20220711093645.1ce3118c@hermes.local> In-Reply-To: <20220711162300.3308684-2-tadhg.kearney@intel.com> References: <20220711162300.3308684-1-tadhg.kearney@intel.com> <20220711162300.3308684-2-tadhg.kearney@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, 11 Jul 2022 16:22:57 +0000 tadhgkearney <tadhg.kearney@intel.com> wrote: > + FILE *f_cur_min; /**< FD of scaling_min */ > + FILE *f_cur_max; /**< FD of scaling_max */ > + FILE *f_base_min; /**< FD of initial min */ > + FILE *f_base_max; /**< FD of initial max */ Do you need to hold these extra FD's open? Also wasteful to use stdio for simple control sysfs like this.