DPDK patches and discussions
 help / color / mirror / Atom feed
From: tadhgkearney <tadhg.kearney@intel.com>
To: dev@dpdk.org
Cc: dave.hunt@intel.com, anatoly.burakov@intel.com,
	reshma.pattan@intel.com, tadhgkearney <tadhg.kearney@intel.com>
Subject: [PATCH v1 3/4] test/power: add unit tests for uncore api
Date: Mon, 11 Jul 2022 16:22:59 +0000	[thread overview]
Message-ID: <20220711162300.3308684-4-tadhg.kearney@intel.com> (raw)
In-Reply-To: <20220711162300.3308684-1-tadhg.kearney@intel.com>

Add basic unit tests covering all seven uncore api's.

Signed-off-by: tadhgkearney <tadhg.kearney@intel.com>
---
 app/test/meson.build         |   2 +
 app/test/test_power_uncore.c | 245 +++++++++++++++++++++++++++++++++++
 2 files changed, 247 insertions(+)
 create mode 100644 app/test/test_power_uncore.c

diff --git a/app/test/meson.build b/app/test/meson.build
index 431c5bd318..3ab360ecee 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -100,6 +100,7 @@ test_sources = files(
         'test_power.c',
         'test_power_cpufreq.c',
         'test_power_kvm_vm.c',
+        'test_power_uncore.c',
         'test_prefetch.c',
         'test_rand_perf.c',
         'test_rawdev.c',
@@ -240,6 +241,7 @@ fast_tests = [
         ['power_cpufreq_autotest', false, true],
         ['power_autotest', true, true],
         ['power_kvm_vm_autotest', false, true],
+        ['power_uncore_autotest', true, true],
         ['reorder_autotest', true, true],
         ['service_autotest', true, true],
         ['thash_autotest', true, true],
diff --git a/app/test/test_power_uncore.c b/app/test/test_power_uncore.c
new file mode 100644
index 0000000000..80d1ae4025
--- /dev/null
+++ b/app/test/test_power_uncore.c
@@ -0,0 +1,245 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2022 Intel Corporation
+ */
+
+#include "test.h"
+
+#ifndef RTE_LIB_POWER
+
+static int
+test_power_uncore(void)
+{
+    printf("Power management library not supported, skipping test\n");
+    return TEST_SKIPPED;
+}
+
+#else
+#include <rte_power_uncore.h>
+#include <power_common.h>
+
+#define VALID_PKG 0
+#define VALID_DIE 0
+#define INVALID_PKG (RTE_MAX_NUMA_NODES + 1)
+#define INVALID_DIE (RTE_MAX_NUMA_DIE + 1)
+#define VALID_INDEX 1
+#define INVALID_INDEX (RTE_MAX_UNCORE_FREQS + 1)
+
+static int check_power_uncore_init(void)
+{
+    int ret;
+
+    /* Test initialisation of uncore configuration*/
+    ret = rte_power_uncore_init(VALID_PKG, VALID_DIE);
+    if(ret < 0){
+        printf("Cannot initialise uncore power management for pkg %u die %u, this "
+            "may occur if environment is not configured "
+            "correctly(APCI cpufreq) or operating in another valid "
+            "Power management environment\n", VALID_PKG, VALID_DIE);
+        return -1;
+    }
+
+    /* Unsuccessful Test */
+    ret = rte_power_uncore_init(INVALID_PKG, INVALID_DIE);
+    if (ret == 0) {
+        printf("Unexpectedly was able to initialise uncore power managment "
+            "for pkg %u die %u\n", INVALID_PKG, INVALID_DIE);
+        return -1;
+    }
+
+    return 0;
+}
+
+static int
+check_power_get_uncore_freq(void)
+{
+    int ret;
+
+    /* Successfully get uncore freq */
+    ret = rte_power_get_uncore_freq(VALID_PKG, VALID_DIE);
+    if (ret < 0) {
+        printf("Failed to get uncore frequency for pkg %u die %u\n",
+                            VALID_PKG, VALID_DIE);
+        return -1;
+    }
+
+    /* Unsuccessful Test */
+    ret = rte_power_get_uncore_freq(INVALID_PKG, INVALID_DIE);
+    if (ret >= 0) {
+        printf("Unexpectedly got invalid uncore frequency for pkg %u die %u\n",
+                            INVALID_PKG, INVALID_DIE);
+        return -1;
+    }
+
+    return 0;
+}
+
+static int
+check_power_set_uncore_freq(void)
+{
+    int ret;
+
+    /* Successfully set uncore freq */
+    ret = rte_power_set_uncore_freq(VALID_PKG, VALID_DIE, VALID_INDEX);
+    if (ret < 0) {
+        printf("Failed to set uncore frequency for pkg %u die %u index %u\n",
+                            VALID_PKG, VALID_DIE, VALID_INDEX);
+        return -1;
+    }
+
+    /* Try to unsuccesfully set invlaid uncore freq index */
+    ret = rte_power_set_uncore_freq(VALID_PKG, VALID_DIE, INVALID_INDEX);
+    if (ret == 0) {
+        printf("Unexpectedly set invalid uncore index for pkg %u die %u index %u\n",
+                            VALID_PKG, VALID_DIE, INVALID_INDEX);
+        return -1;
+    }
+
+    /* Unsuccessful Test */
+    ret = rte_power_set_uncore_freq(INVALID_PKG, INVALID_DIE, VALID_INDEX);
+    if (ret == 0) {
+        printf("Unexpectedly set invalid uncore frequency for pkg %u die %u index %u\n",
+                            INVALID_PKG, INVALID_DIE, VALID_INDEX);
+        return -1;
+    }
+
+    return 0;
+}
+
+static int
+check_power_uncore_freq_max(void)
+{
+    int ret;
+
+    /* Successfully get max uncore freq */
+    ret = rte_power_uncore_freq_max(VALID_PKG, VALID_DIE);
+    if (ret < 0) {
+        printf("Failed to set max uncore frequency for pkg %u die %u\n",
+                            VALID_PKG, VALID_DIE);
+        return -1;
+    }
+
+    /* Unsuccessful Test */
+    ret = rte_power_uncore_freq_max(INVALID_PKG, INVALID_DIE);
+    if (ret == 0) {
+        printf("Unexpectedly set invalid max uncore frequency for pkg %u die %u\n",
+                            INVALID_PKG, INVALID_DIE);
+        return -1;
+    }
+
+    return 0;
+}
+
+static int
+check_power_uncore_freq_min(void)
+{
+    int ret;
+
+    /* Successfully get min uncore freq */
+    ret = rte_power_uncore_freq_min(VALID_PKG, VALID_DIE);
+    if (ret < 0) {
+        printf("Failed to set min uncore frequency for pkg %u die %u\n",
+                            VALID_PKG, VALID_DIE);
+        return -1;
+    }
+
+    /* Unsuccessful Test */
+    ret = rte_power_uncore_freq_min(INVALID_PKG, INVALID_DIE);
+    if (ret == 0) {
+        printf("Unexpectedly set invalid min uncore frequency for pkg %u die %u\n",
+                            INVALID_PKG, INVALID_DIE);
+        return -1;
+    }
+
+    return 0;
+}
+
+static int
+check_power_uncore_get_num_freqs(void)
+{
+    int ret;
+
+    /* Successfully get number of uncore freq */
+    ret = rte_power_uncore_get_num_freqs(VALID_PKG, VALID_DIE);
+    if (ret < 0) {
+        printf("Failed to get number of uncore frequencies for pkg %u die %u\n",
+                            VALID_PKG, VALID_DIE);
+        return -1;
+    }
+
+    /* Unsuccessful Test */
+    ret = rte_power_uncore_get_num_freqs(INVALID_PKG, INVALID_DIE);
+    if (ret >= 0) {
+        printf("Unexpectedly got number of invalid frequencies for pkg %u die %u\n",
+                            INVALID_PKG, INVALID_DIE);
+        return -1;
+    }
+
+    return 0;
+}
+
+static int
+check_power_uncore_exit(void)
+{
+    int ret;
+
+    /* Successfully exit uncore power management */
+    ret = rte_power_uncore_exit(VALID_PKG, VALID_DIE);
+    if(ret < 0) {
+        printf("Failed to exit uncore power management for pkg %u die %u\n",
+                            VALID_PKG, VALID_DIE);
+        return -1;
+    }
+
+    /* Unsuccessful Test */
+    ret = rte_power_uncore_exit(INVALID_PKG, INVALID_DIE);
+    if (ret == 0) {
+        printf("Unexpectedly was able to exit uncore power management for pkg %u die %u\n",
+                            INVALID_PKG, INVALID_DIE);
+        return -1;
+    }
+
+    return 0;
+}
+
+static int
+test_power_uncore(void)
+{
+    int ret;
+
+    ret = check_power_uncore_init();
+    if (ret < 0)
+        goto fail_all;
+    
+    ret = check_power_get_uncore_freq();
+    if (ret < 0)
+        goto fail_all;
+
+    ret = check_power_set_uncore_freq();
+    if (ret < 0)
+        goto fail_all;
+
+    ret = check_power_uncore_freq_max();
+    if (ret < 0)
+        goto fail_all;
+
+    ret = check_power_uncore_freq_min();
+    if (ret < 0)
+        goto fail_all;
+
+    ret = check_power_uncore_get_num_freqs();
+    if (ret < 0)
+        goto fail_all;
+    
+    ret = check_power_uncore_exit();
+    if (ret < 0)
+        return -1;
+
+    return 0;
+
+fail_all:
+    rte_power_uncore_exit(VALID_PKG, VALID_DIE);
+    return -1;
+}
+#endif
+
+REGISTER_TEST_COMMAND(power_uncore_autotest, test_power_uncore);
-- 
2.25.1


  parent reply	other threads:[~2022-07-11 16:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11 16:22 [PATCH v1 0/4] add uncore api to be called through l3fwd-power tadhgkearney
2022-07-11 16:22 ` [PATCH v1 1/4] power: add uncore api to power library tadhgkearney
2022-07-11 16:36   ` Stephen Hemminger
2022-07-14 14:56     ` Kearney, Tadhg
2022-07-14 16:03       ` Stephen Hemminger
2022-07-11 16:22 ` [PATCH v1 2/4] l3fwd-power: add option to call uncore api tadhgkearney
2022-07-11 16:22 ` tadhgkearney [this message]
2022-07-11 16:23 ` [PATCH v1 4/4] config: add uncore defines for x86 tadhgkearney
2022-07-11 16:56 ` [PATCH v1 0/4] add uncore api to be called through l3fwd-power Pattan, Reshma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220711162300.3308684-4-tadhg.kearney@intel.com \
    --to=tadhg.kearney@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dave.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).