From: <abhimanyu.saini@xilinx.com>
To: <dev@dpdk.org>
Cc: <chenbo.xia@intel.com>, <maxime.coquelin@redhat.com>,
<andrew.rybchenko@oktetlabs.ru>,
Abhimanyu Saini <absaini@amd.com>, <stable@dpdk.org>
Subject: [PATCH v2 1/5] common/sfc_efx/base: remove VQ index check during VQ start
Date: Thu, 14 Jul 2022 14:14:47 +0530 [thread overview]
Message-ID: <20220714084451.38375-2-asaini@xilinx.com> (raw)
In-Reply-To: <20220714084451.38375-1-asaini@xilinx.com>
From: Abhimanyu Saini <absaini@amd.com>
The used/avail queue indexes are not bound by queue
size, because HW calculates descriptor entry index by
performing a simple modulo between queue index and queue_size.
So, do not check initial used and avail queue indexes
against queue size because it is possible for these
indexes to be greater than queue size in the
following cases:
1) The queue is created to be migrated into, or
2) The client issues a qstop/qstart after running datapath
Fixes: 4dda72dbdeab3 ("common/sfc_efx/base: add base virtio support for vDPA")
Cc: stable@dpdk.org
Signed-off-by: Abhimanyu Saini <absaini@amd.com>
---
v2:
* Fix checkpatch warnings
* Add a cover letter
drivers/common/sfc_efx/base/rhead_virtio.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/common/sfc_efx/base/rhead_virtio.c b/drivers/common/sfc_efx/base/rhead_virtio.c
index 335cb747d1..7f087170fe 100644
--- a/drivers/common/sfc_efx/base/rhead_virtio.c
+++ b/drivers/common/sfc_efx/base/rhead_virtio.c
@@ -47,14 +47,6 @@ rhead_virtio_qstart(
goto fail2;
}
- if (evvdp != NULL) {
- if ((evvdp->evvd_vq_cidx > evvcp->evvc_vq_size) ||
- (evvdp->evvd_vq_pidx > evvcp->evvc_vq_size)) {
- rc = EINVAL;
- goto fail3;
- }
- }
-
req.emr_cmd = MC_CMD_VIRTIO_INIT_QUEUE;
req.emr_in_buf = payload;
req.emr_in_length = MC_CMD_VIRTIO_INIT_QUEUE_REQ_LEN;
@@ -116,15 +108,13 @@ rhead_virtio_qstart(
if (req.emr_rc != 0) {
rc = req.emr_rc;
- goto fail4;
+ goto fail3;
}
evvp->evv_vi_index = vi_index;
return (0);
-fail4:
- EFSYS_PROBE(fail4);
fail3:
EFSYS_PROBE(fail3);
fail2:
--
2.18.2
next prev parent reply other threads:[~2022-07-14 8:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 8:44 [PATCH v2 0/5] Add support for live migration and cleanup MCDI headers abhimanyu.saini
2022-07-14 8:44 ` abhimanyu.saini [this message]
2022-07-14 8:44 ` [PATCH v2 2/5] common/sfc_efx/base: update " abhimanyu.saini
2022-07-14 8:44 ` [PATCH v2 3/5] common/sfc_efx/base: use the updated definitions of cidx/pidx abhimanyu.saini
2022-07-14 8:44 ` [PATCH v2 4/5] vdpa/sfc: enable support for multi-queue abhimanyu.saini
2022-07-14 8:44 ` [PATCH v2 5/5] vdpa/sfc: Add support for SW assisted live migration abhimanyu.saini
2022-07-14 13:47 ` [PATCH v3 0/5] Add support for live migration and cleanup MCDI headers abhimanyu.saini
2022-07-14 13:48 ` [PATCH v3 1/5] common/sfc_efx/base: remove VQ index check during VQ start abhimanyu.saini
2022-07-14 13:48 ` [PATCH v3 2/5] common/sfc_efx/base: update MCDI headers abhimanyu.saini
2022-07-28 11:32 ` Andrew Rybchenko
2022-07-14 13:48 ` [PATCH v3 3/5] common/sfc_efx/base: use the updated definitions of cidx/pidx abhimanyu.saini
2022-07-28 11:34 ` Andrew Rybchenko
2022-07-14 13:48 ` [PATCH v3 4/5] vdpa/sfc: enable support for multi-queue abhimanyu.saini
2022-07-28 11:29 ` Andrew Rybchenko
2022-07-14 13:48 ` [PATCH v3 5/5] vdpa/sfc: Add support for SW assisted live migration abhimanyu.saini
2022-07-28 13:42 ` Andrew Rybchenko
2022-10-04 15:31 ` [PATCH v3 0/5] Add support for live migration and cleanup MCDI headers Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714084451.38375-2-asaini@xilinx.com \
--to=abhimanyu.saini@xilinx.com \
--cc=absaini@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).