From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B597A0032; Thu, 14 Jul 2022 18:03:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC37942847; Thu, 14 Jul 2022 18:03:15 +0200 (CEST) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id 2C50541156 for ; Thu, 14 Jul 2022 18:03:15 +0200 (CEST) Received: by mail-pf1-f176.google.com with SMTP id l124so2234055pfl.8 for ; Thu, 14 Jul 2022 09:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nFApw3vRPnbT7Qb/W2Fnw0crHX8r/D6OIb5M/v+p6/4=; b=L77fH5GUK65DQUZHtmFCtNgV+M5YThMYOxQch/fuWb1Ch+YW+aNUr1KGqKiYBvbbbB cOlhhNtO+Gurd/IgUMovmrC/faceqg76iXIzR3L5bD4kTxEajLe+JU2uFF/HoWmwiPUR 7fBRFAylmwlGJSOhuAsaNuLeYsMNEBAIYgVP+Z3WacZH8+BjAFZ+gOigiBB4Y9JLS+OD iSg0qpgBqDLQFYOYldWkfDKfAutgmXkG0vv/8pzQFxzu814qJdrJULQzfekFOPHf/mGz nRWpxIckBu5VIwVTCu3YStO4W8sYPZHtLeo5KSDZVxitkBsN3U1tiYDZvPTxBDcqdiH8 MSlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nFApw3vRPnbT7Qb/W2Fnw0crHX8r/D6OIb5M/v+p6/4=; b=RzUsjAh9TN9Qt9BPZtg8HS5rDacFP4reCa2/Y9212q9KzO0CA8XxzsFTDII82gRLfb 1AuTNnoYao+YVIQ4rbpzmEGocf3KnuRaNVM71SBDFHjKum7V6cfCJzKV9kq5wSycKVvR PqxtWOVdyFuSvCgh3oiZN3aD9+qdmZsgUpizL7BKYoor1a1gv8vs0UgAN52sVHJg6suJ OczsULcidCphCBOWtX4WDrApcYLvLWF954fDy14NGr66qNe5HoQPcwyvFHlusnLWlc+c 00vWEF3fuZhE9+o7NS+4ABjWpxz/w8NUWcURcqcmJNASdl0GivGaVZgOIwuJbISYMdL8 hLzA== X-Gm-Message-State: AJIora9jMpXo5N3PCNazYq3QkKskJ9Q1cxHTOPcYp2Y59gKrhRC3rmHb YEP4nrr04s8a4y59AGwG/7WdMw== X-Google-Smtp-Source: AGRyM1uXELREwRLticPgDGf2TrrkGvLxjiUvjKzJlzn/8XRf20qVJ48jod6/FJDDy3aWyV8yluL1qQ== X-Received: by 2002:a65:604a:0:b0:3f9:f423:b474 with SMTP id a10-20020a65604a000000b003f9f423b474mr8006279pgp.527.1657814594070; Thu, 14 Jul 2022 09:03:14 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id a8-20020a170902710800b0015e8d4eb1d7sm1652722pll.33.2022.07.14.09.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jul 2022 09:03:13 -0700 (PDT) Date: Thu, 14 Jul 2022 09:03:11 -0700 From: Stephen Hemminger To: "Kearney, Tadhg" Cc: "dev@dpdk.org" , "Burakov, Anatoly" , "Pattan, Reshma" , "Hunt, David" Subject: Re: [PATCH v1 1/4] power: add uncore api to power library Message-ID: <20220714090311.710c6f99@hermes.local> In-Reply-To: References: <20220711162300.3308684-1-tadhg.kearney@intel.com> <20220711162300.3308684-2-tadhg.kearney@intel.com> <20220711093645.1ce3118c@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 14 Jul 2022 14:56:29 +0000 "Kearney, Tadhg" wrote: > > -----Original Message----- > > From: Stephen Hemminger > > Sent: Monday 11 July 2022 17:37 > > To: Kearney, Tadhg > > Cc: dev@dpdk.org; dave.hunt@intel.com; Burakov, Anatoly > > ; Pattan, Reshma > > Subject: Re: [PATCH v1 1/4] power: add uncore api to power library > > > > On Mon, 11 Jul 2022 16:22:57 +0000 > > tadhgkearney wrote: > > > > > + FILE *f_cur_min; /**< FD of scaling_min */ > > > + FILE *f_cur_max; /**< FD of scaling_max */ > > > + FILE *f_base_min; /**< FD of initial min */ > > > + FILE *f_base_max; /**< FD of initial max */ > > > > Do you need to hold these extra FD's open? > > Also wasteful to use stdio for simple control sysfs like this. > > Hi Stephen, > No these extra FD's don't need to be kept open, will remove their usage for v3. > What do you mean exactly by using stdio; are you suggesting to not make use of flush() calls, > or more broadly avoid stdio altogether? > Thanks, > Tadhg See eal_parse_sysfs_value.