From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E0C8A0032; Thu, 21 Jul 2022 17:19:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 024F640141; Thu, 21 Jul 2022 17:19:27 +0200 (CEST) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id 00269400D7 for ; Thu, 21 Jul 2022 17:19:25 +0200 (CEST) Received: by mail-pj1-f52.google.com with SMTP id t3-20020a17090a3b4300b001f21eb7e8b0so4982962pjf.1 for ; Thu, 21 Jul 2022 08:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EQLfh5ngri4D2+bsRO1uqvaID5sCRINj1DNaw2dVYE0=; b=hFB9P+RINH4jb5ymDrMDOjcbkYz3F688pIW5smlQNTdRpK2UWc9Ai3iSmHWYn+EgyY 1Sy8f4AI/2q9JopRmS04j/okkLRHYkqgbeglAeKBLUnBtA669Vo6aRSLg+5H6QjYcYBF nIbd5g0OL7efPmNvKccU0qVhvKRLQdFWYBJ4P0ypXuix1oEhhstRzbwZSzGBZcu3HGCh hMb4+aZKQ0nRA76B0lcW/WmcOZHEpZwUzaJbim5fG+hmQ4kp+D6W1rEq5nTVJMPVQ0IZ BfXZhck0iwJoGyMELGJxFIRJmfTv1fBHaBsiYaEU9q8wYkSv9J+MerXpcgOrRyFAdpki Bw0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EQLfh5ngri4D2+bsRO1uqvaID5sCRINj1DNaw2dVYE0=; b=dJSSRUxgx2QvidMhdAWObleFQ6ts+3UjTSK6VP5u740YQhwFd03R87BeR/YbaNRjzu oIX8zQAUKffJZIADylLI/mM2qMYRODi1I0CjKegIl0m8MuX2VdYUIcwFRVufvhAruBHV jWAI5J5JIW6WQqY3I6SmJY7Lo0A48pQCmbTIzpuYBiVM1C5ud+k78wg9nNf6C1DPTX4w 7gGt1FGAz7MciI5cfr8dQRq9w3sARfq+D+LdmL24YDnbs0N2Q33EwThzBAxTNJQU1fZv UznYuQKxO8RHqbKhkLRR7NdhJHa5Hj7kmX3/ldvnsJjW2n+xBFwhLtEEb96ye+SKZAnr hDjw== X-Gm-Message-State: AJIora82RL5E8wGvmWWlYhcd3O0/frcjl8Lh8BscOyurRE13xFX50e2v KEo0EdWxbxhgwK6VYpfj1STgdg== X-Google-Smtp-Source: AGRyM1uvkCWQsRmhRcjbxr/hPIZui0kcuSwRZfITamw8KFXiwszMgikb5JpBwnCjwV/woS2V700Mog== X-Received: by 2002:a17:90b:4ad0:b0:1f0:28c6:9493 with SMTP id mh16-20020a17090b4ad000b001f028c69493mr11667448pjb.142.1658416764858; Thu, 21 Jul 2022 08:19:24 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id e9-20020a170902784900b001678dcb4c5asm513760pln.100.2022.07.21.08.19.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jul 2022 08:19:24 -0700 (PDT) Date: Thu, 21 Jul 2022 08:19:21 -0700 From: Stephen Hemminger To: Alex Kiselev Cc: dev@dpdk.org, Keith Wiles Subject: Re: [PATCH] net/tap: fix the overflow of the network interface index. Message-ID: <20220721081921.37221f7c@hermes.local> In-Reply-To: <20220721111301.2106005-2-alex@bisonrouter.com> References: <20220721111301.2106005-1-alex@bisonrouter.com> <20220721111301.2106005-2-alex@bisonrouter.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 21 Jul 2022 11:13:01 +0000 Alex Kiselev wrote: > On Linux and most other systems, network interface index is a 32-bit > integer. Indexes overflowing the 16-bit integer are frequently seen > when used inside a Docker container. > > Signed-off-by: Alex Kiselev Looks good, Linux API is inconsistent in use of signed vs unsigned int for the ifindex. But negative values are never used/returned. Acked-by: Stephen Hemminger