From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA0FEA0032; Fri, 22 Jul 2022 16:49:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 849F94021E; Fri, 22 Jul 2022 16:49:29 +0200 (CEST) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 9393640156 for ; Fri, 22 Jul 2022 16:49:28 +0200 (CEST) Received: by mail-pj1-f51.google.com with SMTP id pc13so4584175pjb.4 for ; Fri, 22 Jul 2022 07:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JeQo/Rrwdqq+y7QjsjmMPb91sUkPoLWOZyoW0O9K1FQ=; b=JsMCujZGv1djhtm0qCYRCwZDEck5bXsZfT0Ho1mKeyAdVtykhm6jf7uDLVcmgK9RjB F1vuw+dr1ixgdDsg4ng716hdEM+xcbEx9NxHJ0VFjAxIH+1QY/FnkB2YEIix9pdCAsT2 VhH72hIIYQtEKIy6HxxmIOpXx4/1w4qwKCYF4FZwSSAndPRKF9y0qG9O5VfPhBQVz3aj ckHmTYyaQVrio8z3tm/243etqC2lneaXFCWLE0x0tV0pUFWXN0RoYedI4xr9CPyGqZZM E5ZD1eca+sCqHb99KcyWLFkXyG3j/e8eldrv7L15rEYQ11hjc1HuRVQ898NDQTG0DwVx WUIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JeQo/Rrwdqq+y7QjsjmMPb91sUkPoLWOZyoW0O9K1FQ=; b=3JH+vtBMbzx2Fclygj99jhDDsKRAg5n36tmNqV6/5zijVnO0IorbO65JGRRGTbgoIV GJG+aBmw7Y914aMwWxLPNlOIPK0UxYrwwEcQxtMR1ZdgchvttWmpJTn9607IZVT5zjWN zNOlfXzzSn+ihhLDxOotXxBdo+ej1Wf2lo82oKQqv/xz146YUQJBMNjumAXGu3ibycV8 NJO+1z7vYTgLnY6mBydnThqy+tC3uGdmF07iDLe7gYFAZtAFECD0+pOpjfdlvsFajobF Hgd+jvjbYll+9tfsn8Za53GARE0Pvu8/6zWfSgvDSFVFdbo2gNcXJuBDExHulaRcZ2Ry WaEg== X-Gm-Message-State: AJIora8g5kne5oROzgVlWQu5Kj5CArbWwIYjrhCwWcmLifrdZgqLTOca xw6gu7T6IlNtXiB73kMaa1cB0A== X-Google-Smtp-Source: AGRyM1tYKQ8+7ZBpw4aUeEeDDP5fmRhQ13bUoc7rvXv2vTn/XOmc6tJSGyyWpAX+2q2ULxiusaJKxg== X-Received: by 2002:a17:90a:5aa3:b0:1f2:2bb7:aea9 with SMTP id n32-20020a17090a5aa300b001f22bb7aea9mr58233pji.197.1658501367565; Fri, 22 Jul 2022 07:49:27 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id x1-20020aa79561000000b00528c26c84a3sm3947062pfq.64.2022.07.22.07.49.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jul 2022 07:49:27 -0700 (PDT) Date: Fri, 22 Jul 2022 07:49:25 -0700 From: Stephen Hemminger To: Huichao Cai Cc: dev@dpdk.org, konstantin.v.ananyev@yandex.ru Subject: Re: [PATCH v3] ip_frag: add IPv4 fragment copy packet API Message-ID: <20220722074925.2e06fbd5@hermes.local> In-Reply-To: <1658494910-7869-1-git-send-email-chcchc88@163.com> References: <1654784398-11315-1-git-send-email-chcchc88@163.com> <1658494910-7869-1-git-send-email-chcchc88@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 22 Jul 2022 21:01:50 +0800 Huichao Cai wrote: > Some NIC drivers support MBUF_FAST_FREE(Device supports optimization > for fast release of mbufs. When set application must guarantee that > per-queue all mbufs comes from the same mempool and has refcnt = 1) > offload. In order to adapt to this offload function, add this API. > Add some test data for this API. > > Signed-off-by: Huichao Cai The code should just be checking that refcnt == 1 directly. There are cases where sender passes a cloned mbuf. This is independent of the fast free optimization. Similar to what Linux kernel does with skb_cow().