[dpdk-dev v1] crypto/qat: add in libcrypto version check

[dpdk-dev v1] crypto/qat: add in libcrypto version check

[Kai Ji]

This patch add in libcrypto version check before enable libipsec-mb for
QAT. The inter-ipsec-mb lib for partial hash and AES cacluation should
only be enabled when both OpensSSL 3.0 and IPSec_MB 1.2.0 are installed
on the system.

Signed-off-by: Kai Ji <kai.ji@intel.com>
---
 drivers/common/qat/meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build
index 245c0fbe61..8247bdd017 100644
--- a/drivers/common/qat/meson.build
+++ b/drivers/common/qat/meson.build
@@ -37,7 +37,9 @@ endif
 
 IMB_required_ver = '1.2.0'
 libipsecmb = cc.find_library('IPSec_MB', required: false)
-if libipsecmb.found()
+libcrypto_3 = dependency('libcrypto', required: false,
+    method: 'pkg-config', version : '>=3.0.0')
+if libipsecmb.found() and libcrypto_3.found()
     # version comes with quotes, so we split based on " and take the middle
     imb_ver = cc.get_define('IMB_VERSION_STR',
         prefix : '#include<intel-ipsec-mb.h>').split('"')[1]
-- 
2.17.1

[dpdk-dev v2] crypto/qat: add in libcrypto version check

[Kai Ji]

This patch add in libcrypto version check before enable libipsec-mb for
QAT. The inter-ipsec-mb lib for partial hash and AES calculation should
only be enabled when both OpensSSL 3.0 and IPSec_MB 1.2.0 are installed
on the system.

Signed-off-by: Kai Ji <kai.ji@intel.com>
---
 drivers/common/qat/meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build
index 245c0fbe61..8247bdd017 100644
--- a/drivers/common/qat/meson.build
+++ b/drivers/common/qat/meson.build
@@ -37,7 +37,9 @@ endif
 
 IMB_required_ver = '1.2.0'
 libipsecmb = cc.find_library('IPSec_MB', required: false)
-if libipsecmb.found()
+libcrypto_3 = dependency('libcrypto', required: false,
+    method: 'pkg-config', version : '>=3.0.0')
+if libipsecmb.found() and libcrypto_3.found()
     # version comes with quotes, so we split based on " and take the middle
     imb_ver = cc.get_define('IMB_VERSION_STR',
         prefix : '#include<intel-ipsec-mb.h>').split('"')[1]
-- 
2.17.1

RE: [EXT] [dpdk-dev v1] crypto/qat: add in libcrypto version check

[Akhil Goyal]

Hi Kai,

This is a fix for compilation when openssl 1.1 is used to build QAT.
Can you update the title to
Crypto/qat: fix build with OpenSSL 1.1

> This patch add in libcrypto version check before enable libipsec-mb for
> QAT. The inter-ipsec-mb lib for partial hash and AES cacluation should
> only be enabled when both OpensSSL 3.0 and IPSec_MB 1.2.0 are installed
> on the system.

Spell check on description.

> 
> Signed-off-by: Kai Ji <kai.ji@intel.com>
> ---
>  drivers/common/qat/meson.build | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/common/qat/meson.build
> b/drivers/common/qat/meson.build
> index 245c0fbe61..8247bdd017 100644
> --- a/drivers/common/qat/meson.build
> +++ b/drivers/common/qat/meson.build
> @@ -37,7 +37,9 @@ endif
> 
>  IMB_required_ver = '1.2.0'
>  libipsecmb = cc.find_library('IPSec_MB', required: false)
> -if libipsecmb.found()
> +libcrypto_3 = dependency('libcrypto', required: false,
> +    method: 'pkg-config', version : '>=3.0.0')
> +if libipsecmb.found() and libcrypto_3.found()
>      # version comes with quotes, so we split based on " and take the middle
>      imb_ver = cc.get_define('IMB_VERSION_STR',
>          prefix : '#include<intel-ipsec-mb.h>').split('"')[1]
> --
> 2.17.1

[dpdk-dev v2] Crypto/qat: fix build with OpenSSL 1.1

[Kai Ji]

This patch add in libcrypto version check before enable libipsec-mb for
QAT. The inter-ipsec-mb lib for partial hash and AES calculation should
only be enabled when both OpensSSL 3.0 and IPSec_MB 1.2.0 are installed
on the system.

Signed-off-by: Kai Ji <kai.ji@intel.com>
---
 drivers/common/qat/meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build
index 245c0fbe61..8247bdd017 100644
--- a/drivers/common/qat/meson.build
+++ b/drivers/common/qat/meson.build
@@ -37,7 +37,9 @@ endif
 
 IMB_required_ver = '1.2.0'
 libipsecmb = cc.find_library('IPSec_MB', required: false)
-if libipsecmb.found()
+libcrypto_3 = dependency('libcrypto', required: false,
+    method: 'pkg-config', version : '>=3.0.0')
+if libipsecmb.found() and libcrypto_3.found()
     # version comes with quotes, so we split based on " and take the middle
     imb_ver = cc.get_define('IMB_VERSION_STR',
         prefix : '#include<intel-ipsec-mb.h>').split('"')[1]
-- 
2.17.1

RE: [EXT] [dpdk-dev v1] crypto/qat: add in libcrypto version check

[Ji, Kai]

Thanks akhil,

V2 here: http://patchwork.dpdk.org/project/dpdk/patch/20220726115608.84140-1-kai.ji@intel.com/

Regards

Kai 

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Tuesday, July 26, 2022 11:14 AM
> To: Ji, Kai <kai.ji@intel.com>; dev@dpdk.org
> Cc: Ashwin Sekhar Thalakalath Kottilveetil <asekhar@marvell.com>; Anoob
> Joseph <anoobj@marvell.com>
> Subject: RE: [EXT] [dpdk-dev v1] crypto/qat: add in libcrypto version check
> 
> Hi Kai,
> 
> This is a fix for compilation when openssl 1.1 is used to build QAT.
> Can you update the title to
> Crypto/qat: fix build with OpenSSL 1.1
> 
> > This patch add in libcrypto version check before enable libipsec-mb
> > for QAT. The inter-ipsec-mb lib for partial hash and AES cacluation
> > should only be enabled when both OpensSSL 3.0 and IPSec_MB 1.2.0 are
> > installed on the system.
> 
> Spell check on description.
> 
> >
> > Signed-off-by: Kai Ji <kai.ji@intel.com>
> > ---
> >  drivers/common/qat/meson.build | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/common/qat/meson.build
> > b/drivers/common/qat/meson.build index 245c0fbe61..8247bdd017 100644
> > --- a/drivers/common/qat/meson.build
> > +++ b/drivers/common/qat/meson.build
> > @@ -37,7 +37,9 @@ endif
> >
> >  IMB_required_ver = '1.2.0'
> >  libipsecmb = cc.find_library('IPSec_MB', required: false) -if
> > libipsecmb.found()
> > +libcrypto_3 = dependency('libcrypto', required: false,
> > +    method: 'pkg-config', version : '>=3.0.0') if libipsecmb.found()
> > +and libcrypto_3.found()
> >      # version comes with quotes, so we split based on " and take the middle
> >      imb_ver = cc.get_define('IMB_VERSION_STR',
> >          prefix : '#include<intel-ipsec-mb.h>').split('"')[1]
> > --
> > 2.17.1

RE: [EXT] [dpdk-dev v2] Crypto/qat: fix build with OpenSSL 1.1

[Akhil Goyal]

> Subject: [EXT] [dpdk-dev v2] Crypto/qat: fix build with OpenSSL 1.1
common/qat: fix build with OpenSSL 1.1

> This patch add in libcrypto version check before enable libipsec-mb for
> QAT. The inter-ipsec-mb lib for partial hash and AES calculation should
> only be enabled when both OpensSSL 3.0 and IPSec_MB 1.2.0 are installed
> on the system.
> 
> Signed-off-by: Kai Ji <kai.ji@intel.com>
    Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb for partial hash and AES")
    Cc: stable@dpdk.org

Acked-by: Akhil Goyal <gakhil@marvell.com>

Applied to dpdk-next-crypto

Thanks.