From: Stephen Hemminger <stephen@networkplumber.org>
To: "Mário Kuka" <kuka@cesnet.cz>
Cc: dev@dpdk.org, mdr@ashroe.eu, reshma.pattan@intel.com
Subject: Re: [PATCH v2 0/2] pcapng: fix some issues with writing packets.
Date: Fri, 29 Jul 2022 08:58:50 -0700 [thread overview]
Message-ID: <20220729085850.170d1e03@hermes.local> (raw)
In-Reply-To: <20220729071841.18198-1-kuka@cesnet.cz>
On Fri, 29 Jul 2022 09:18:39 +0200
Mário Kuka <kuka@cesnet.cz> wrote:
> This patchset contains fixes for some issues that occur when writing a
> large burst of packets at once, such as writing more packets than the
> IOV_MAX limit and the problem of partial writing of a packet to a file
> if the writev() system call performs a partial write.
>
> The typical use of pcapng in our cases is to copy the packets into a
> separate buffer and the process of writing to the file is done in some
> slow path, for example by writing in a separate thread or at the end of
> the application, where we don't mind the limitation of the typically
> slow speed of the storage medium.
>
> Mário Kuka (2):
> pcapng: fix write more packets than IOV_MAX limit
> pcapng: check if writev() returns a partial write
>
> app/test/test_pcapng.c | 42 +++++++++++++++++-
> lib/pcapng/rte_pcapng.c | 96 +++++++++++++++++++++++++++++++++--------
> 2 files changed, 120 insertions(+), 18 deletions(-)
>
You ignored my feedback from earlier patch.
It seems you are adding a lot more here that is necessary.
next prev parent reply other threads:[~2022-07-29 15:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 15:28 [PATCH] pcapng: fix write more packets than IOV_MAX limit Mário Kuka
2022-07-25 15:57 ` Stephen Hemminger
2022-07-25 16:10 ` Stephen Hemminger
2022-07-29 7:18 ` [PATCH v2 0/2] pcapng: fix some issues with writing packets Mário Kuka
2022-07-29 7:18 ` [PATCH v2 1/2] pcapng: fix write more packets than IOV_MAX limit Mário Kuka
2022-07-29 7:18 ` [PATCH v2 2/2] pcapng: check if writev() returns a partial write Mário Kuka
2022-07-29 16:00 ` Stephen Hemminger
2022-07-29 17:08 ` Mário Kuka
2022-07-29 18:14 ` Stephen Hemminger
2022-08-01 8:42 ` Mário Kuka
2022-07-29 15:58 ` Stephen Hemminger [this message]
2022-07-29 17:33 ` [PATCH v2 0/2] pcapng: fix some issues with writing packets Mário Kuka
2022-08-01 8:40 ` [PATCH v3] pcapng: fix write more packets than IOV_MAX limit Mário Kuka
2022-08-01 15:33 ` Stephen Hemminger
2022-10-10 0:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729085850.170d1e03@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=kuka@cesnet.cz \
--cc=mdr@ashroe.eu \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).