From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 20DFAA04FD;
Mon, 1 Aug 2022 15:13:48 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C32D54067B;
Mon, 1 Aug 2022 15:13:47 +0200 (CEST)
Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com
[67.231.148.174])
by mails.dpdk.org (Postfix) with ESMTP id 1C3CB4014F
for <dev@dpdk.org>; Mon, 1 Aug 2022 15:13:45 +0200 (CEST)
Received: from pps.filterd (m0045849.ppops.net [127.0.0.1])
by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 271AKm5B003279;
Mon, 1 Aug 2022 06:13:44 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-type : content-transfer-encoding; s=pfpt0220;
bh=3CcXJWlFtPNFIKAuAWE+cnCgWG5FZnCudzhLqKj/0nk=;
b=dpeCv1zgCB7VDV9fhpXMjJpsBO84OI96IYNpiqFe+eM8j5Yv/9uak8jQ/1kEfYjc71Te
o+fUOPiuvsba3XERpdG2gBbUCnB//YX4OAw5XaUQrrxrTOwW6DwsJgnlczYAhN+CC0MU
zxmqWEN3+HWZq++fOyZrvMqOQ+MjVXKudtKRyAHwxA3VVi5k9Fre7pQ6+GBwnnFaDsyH
jaguNRxA5gdHQTOZo0KM6bxe4/xLw669H3YusuyfkWSxkIOHmEGACQ236nUVt0gd2uK6
eAENmK9ncSqIRMz/PJol/oijwrhZsIl/H+yN9/0BuYXGK+F65T0ny6DLTSsB+FO8G+se QA==
Received: from dc5-exch01.marvell.com ([199.233.59.181])
by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3hn20q74gx-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
Mon, 01 Aug 2022 06:13:44 -0700
Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com
(10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;
Mon, 1 Aug 2022 06:13:43 -0700
Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com
(10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend
Transport; Mon, 1 Aug 2022 06:13:43 -0700
Received: from localhost.localdomain (unknown [10.28.36.155])
by maili.marvell.com (Postfix) with ESMTP id A5B233F70A1;
Mon, 1 Aug 2022 06:13:41 -0700 (PDT)
From: Hanumanth Pothula <hpothula@marvell.com>
To: Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang
<yuying.zhang@intel.com>
CC: <dev@dpdk.org>, <jerinj@marvell.com>, <hpothula@marvell.com>
Subject: [PATCH] app/testpmd: add command line argument 'rx-metadata'
Date: Mon, 1 Aug 2022 18:43:37 +0530
Message-ID: <20220801131338.1710737-1-hpothula@marvell.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220801044111.1706871-1-hpothula@marvell.com>
References: <20220801044111.1706871-1-hpothula@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-Proofpoint-GUID: Mn7OeMr4CgrhGt5gmxeEYt1B6X_5GCU3
X-Proofpoint-ORIG-GUID: Mn7OeMr4CgrhGt5gmxeEYt1B6X_5GCU3
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
definitions=2022-08-01_07,2022-08-01_01,2022-06-22_01
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Presently, rx metadata is sent to PMD by default, leading
to a performance drop as processing for the same in rx path
takes extra cycles.
Hence, introducing command line argument, 'rx-metadata' to
control passing rx metadata to PMD. By default it’s disabled.
Signed-off-by: Hanumanth Pothula <hpothula@marvell.com>
---
app/test-pmd/parameters.c | 4 ++++
app/test-pmd/testpmd.c | 6 +++++-
app/test-pmd/testpmd.h | 2 ++
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index e3c9757f3f..daf1218977 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -213,6 +213,7 @@ usage(char* progname)
printf(" --hairpin-mode=0xXX: bitmask set the hairpin port mode.\n"
" 0x10 - explicit Tx rule, 0x02 - hairpin ports paired\n"
" 0x01 - hairpin ports loop, 0x00 - hairpin port self\n");
+ printf(" --rx-metadata: send rx metadata to driver \n");
}
#ifdef RTE_LIB_CMDLINE
@@ -710,6 +711,7 @@ launch_args_parse(int argc, char** argv)
{ "record-burst-stats", 0, 0, 0 },
{ PARAM_NUM_PROCS, 1, 0, 0 },
{ PARAM_PROC_ID, 1, 0, 0 },
+ { "rx-metadata", 0, 0, 0 },
{ 0, 0, 0, 0 },
};
@@ -1510,6 +1512,8 @@ launch_args_parse(int argc, char** argv)
num_procs = atoi(optarg);
if (!strcmp(lgopts[opt_idx].name, PARAM_PROC_ID))
proc_id = atoi(optarg);
+ if (!strcmp(lgopts[opt_idx].name, "rx-metadata"))
+ rx_metadata_negotiate = 1;
break;
case 'h':
usage(argv[0]);
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index addcbcac85..ebbde5dfc9 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -411,6 +411,9 @@ uint8_t clear_ptypes = true;
/* Hairpin ports configuration mode. */
uint16_t hairpin_mode;
+/* send rx metadata */
+uint8_t rx_metadata_negotiate;
+
/* Pretty printing of ethdev events */
static const char * const eth_event_desc[] = {
[RTE_ETH_EVENT_UNKNOWN] = "unknown",
@@ -1628,7 +1631,8 @@ init_config_port_offloads(portid_t pid, uint32_t socket_id)
int ret;
int i;
- eth_rx_metadata_negotiate_mp(pid);
+ if (rx_metadata_negotiate)
+ eth_rx_metadata_negotiate_mp(pid);
port->dev_conf.txmode = tx_mode;
port->dev_conf.rxmode = rx_mode;
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index fb2f5195d3..8a9168c51e 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -621,6 +621,8 @@ extern struct rte_ether_addr peer_eth_addrs[RTE_MAX_ETHPORTS];
extern uint32_t burst_tx_delay_time; /**< Burst tx delay time(us) for mac-retry. */
extern uint32_t burst_tx_retry_num; /**< Burst tx retry number for mac-retry. */
+extern uint8_t rx_metadata_negotiate;
+
#ifdef RTE_LIB_GRO
#define GRO_DEFAULT_ITEM_NUM_PER_FLOW 32
#define GRO_DEFAULT_FLOW_NUM (RTE_GRO_MAX_BURST_ITEM_NUM / \
--
2.25.1