From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9487A00C5; Tue, 2 Aug 2022 18:01:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA73240141; Tue, 2 Aug 2022 18:01:27 +0200 (CEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 0FB18400D7 for ; Tue, 2 Aug 2022 18:01:26 +0200 (CEST) Received: by mail-pl1-f169.google.com with SMTP id iw1so13858113plb.6 for ; Tue, 02 Aug 2022 09:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z1waN/qfUwOY16194dNlb8yYjGuySa0UVgbKe+RxLw4=; b=5tyuM6J6l8GRe8PuajKVLAvQLNmo37UNQn4N21l2yWNCfep3L4Q84k+aKydvvzmjxU aqxzZnLSsxLx1GM5y0AkScBHUVv6+7RPpwC2H0tCWMLvh6AN+NrPeciUMSA5Dx7N4AU5 DpDCuicXu8GBp9asZxlc8VzbjLazjE4qadrP7cUU9/g8C2ivy+XNic+qnAadUkXovBvj 8IzUjcne+iRWAppRIvkWYmfm+TMfEbnAavprqaqtOU98Dhflyz2rgScsdKIWpYmVmvnf HDUQSFr9olrFc8aW4tJU607Xun+N2PrNMF3zVVb2rOKbtzFcRqZcX98ZoBP4UMpF2d/q dbxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z1waN/qfUwOY16194dNlb8yYjGuySa0UVgbKe+RxLw4=; b=e9xEpPhZIocUGAgubbOtXTARies2M3IlponZ7WNc/wh41/lpFP7sgTvLRs7abg/JMr tpX9ruKeFCwgSLsK0jkLykchTqPARmCC+wvr39xDc6DKoGwwikzkWf6BhrxSWFYm3bo4 p6M/mNOkvJtx/6bLCJ27wn7/kLKGeon83v273Uq2kVl3Kan94gQa0dkXZW4EoQhoq0Dv bSwll1c1Ub3kGKg55J35TmDbpB2z0iwcJZMauSPVlvY5/W2MsWNUzTC2NaL9m7HxnDKl EMOFTwWnHaOXwT4/OO84V0djbhREzpT4/dXtfuKjsE7S5NsYHk/zrr2yIptRIVS+VInc If1A== X-Gm-Message-State: ACgBeo0OHPdHrg0uSwl+b949NRBVf3+3K7E33OfMpOS6aRtfQuldATo2 17K+84C+5YYPO9uuO0jhKZ1zmw== X-Google-Smtp-Source: AA6agR7rTmRXefP0Y/kdFer5fTufC/6jkrSKx4FacGFCGYPSfey7PJqrK9Tue3XiofHtLfIH+JOpVQ== X-Received: by 2002:a17:90b:4a50:b0:1f4:f1b9:d21f with SMTP id lb16-20020a17090b4a5000b001f4f1b9d21fmr131327pjb.185.1659456086181; Tue, 02 Aug 2022 09:01:26 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id w187-20020a6230c4000000b0052c456eafe1sm11281005pfw.176.2022.08.02.09.01.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Aug 2022 09:01:25 -0700 (PDT) Date: Mon, 1 Aug 2022 18:40:57 -0700 From: Stephen Hemminger To: Claudio Fontana Cc: Maxime Coquelin , Chenbo Xia , dev@dpdk.org Subject: Re: [PATCH v3 0/2] vhost fixes for OVS SIGSEGV in PMD Message-ID: <20220801183637.23f4add6@hermes.local> In-Reply-To: <20220802004938.23670-1-cfontana@suse.de> References: <20220802004938.23670-1-cfontana@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 2 Aug 2022 02:49:36 +0200 Claudio Fontana wrote: > This is an alternative, more general fix compared with PATCH v1, > and fixes style issues in v2. > > The series fixes a segmentation fault in the OVS PMD thread when > resynchronizing with QEMU after the guest application has been killed > with SIGKILL (patch 1/2), > > The segmentation fault can be caused by the guest DPDK application, > which is able this way to crash the OVS process on the host, > see the backtrace in patch 1/2. > > Patch 2/2 is an additional improvement in the current error handling. Checking for NULL and 0 is good on host side. But guest should probably not be sending such a useless request?