From: Claudio Fontana <cfontana@suse.de>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>
Cc: dev@dpdk.org, Claudio Fontana <cfontana@suse.de>
Subject: [PATCH v2 0/2] vhost fixes for OVS SIGSEGV in PMD
Date: Tue, 2 Aug 2022 02:39:46 +0200 [thread overview]
Message-ID: <20220802003948.22693-1-cfontana@suse.de> (raw)
This is an alternative, more general fix compared with PATCH v1.
The series fixes a segmentation fault in the OVS PMD thread when
resynchronizing with QEMU after the guest application has been killed
with SIGKILL (patch 1/2),
The segmentation fault can be caused by the guest DPDK application,
which is able this way to crash the OVS process on the host,
see the backtrace in patch 1/2.
Patch 2/2 is an additional improvement in the current error handling.
---
Changes from v1:
* patch 1/2: instead of only fixing virtio_dev_tx_split, put the check
for nr_vec == 0 inside desc_to_mbuf and mbuf_to_desc, so that in no
case they attempt to read and dereference addresses from the buf_vec[]
array when it does not contain any valid elements.
---
For your review and comments,
Claudio
Claudio Fontana (2):
vhost: check for nr_vec == 0 in desc_to_mbuf, mbuf_to_desc
vhost: improve error handling in desc_to_mbuf
lib/vhost/virtio_net.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
--
2.26.2
next reply other threads:[~2022-08-02 0:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 0:39 Claudio Fontana [this message]
2022-08-02 0:39 ` [PATCH 1/2] vhost: check for nr_vec == 0 in desc_to_mbuf, mbuf_to_desc Claudio Fontana
2022-08-02 0:39 ` [PATCH 2/2] vhost: improve error handling in desc_to_mbuf Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220802003948.22693-1-cfontana@suse.de \
--to=cfontana@suse.de \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).