From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B1A7A00C5; Wed, 3 Aug 2022 17:11:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E00D140A7E; Wed, 3 Aug 2022 17:11:44 +0200 (CEST) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mails.dpdk.org (Postfix) with ESMTP id 5E4D440141 for ; Wed, 3 Aug 2022 17:11:42 +0200 (CEST) Received: by mail-pg1-f180.google.com with SMTP id j17so1040346pgl.5 for ; Wed, 03 Aug 2022 08:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4oiorZpPX4Bl2DwNHa69Qd5gsNyr3fHVOkIlvCHn0Ww=; b=vYehTDLgquSD5tkMe2+y/GDOV8fs7gWlFdcfayGTqZj4MTQn08BsSTTN1Ku/KFLvbo luo5LQIPEDAOa3lqToU1/WqESlmrz9oUmlMmbMJ0HDbyXxs7rkNQlNgaBdnLlZKe/Gqr dEYNwTUHOdBOTnFLtW4dtywXJBPlU7oAZZwgE63m3JVDFCNIGBxldsin08WcD7p/stg2 z69hjmMiilXtPbm5OR/CwidaLA1thuaVBeOu8F2ApxG57BLxzHN0yhdPuV2EsFMEMZ3f QgvjJjridTdUcXyMfUhmu0GnoUzmZDaRD0N7d74rFRnGWOmNEa2jpJoagLlc/ad4u7xv UAog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4oiorZpPX4Bl2DwNHa69Qd5gsNyr3fHVOkIlvCHn0Ww=; b=CXOdBGktAe9AIGiMg3XbJYyBxjd4cXlYXMcsFMaopWmN5uvtljFoskKhIWWYN04Iia Uudopvhek6wVH0fk9xYOUoaho67Sv0GP95BtXKRrw/vZSuFBCnhZF325UcW/HquKR8yP oLRDvu8wG6IdPy4ndYONqVokMdM6a2P2FHkJRxyoQX0D7XplZ6AEru/7M8OOz/wdvrOH sgVsjLfumCZXQzEoYKkiXs3LYACTaqYqZ7oA/s7Axo+snx20BjVuCCCQ21eyeT+tto8G 4pdBJStvPP0O/5JeaqFF2VXpIf9w0oM/6FeRvJ2GlJ7rngcSgXHDx9elqEvLVcL39PJV u+aw== X-Gm-Message-State: ACgBeo2+zTU2KWtq5dJGw4GKmblY+xo8m4crGW07frpwVJPpGeQUSTq3 JewTsIbQVvjtW/dGW5toSRD4Zg== X-Google-Smtp-Source: AGRyM1v8LSA0W58rZnJIekMfgfWOG9IQ+4pF6Ym5tnLgtvzt+r4+qH8GdwschFhMljrnxKe14/STgw== X-Received: by 2002:aa7:82ca:0:b0:51b:cf43:d00a with SMTP id f10-20020aa782ca000000b0051bcf43d00amr26237777pfn.58.1659539500934; Wed, 03 Aug 2022 08:11:40 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y19-20020a1709027c9300b0016d62ba5665sm2005359pll.254.2022.08.03.08.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Aug 2022 08:11:40 -0700 (PDT) Date: Wed, 3 Aug 2022 08:11:38 -0700 From: Stephen Hemminger To: Junfeng Guo Cc: qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org, Xiaoyun Li , Xiao Wang Subject: Re: [PATCH 03/13] net/idpf: support device initialization Message-ID: <20220803081138.1439da10@hermes.local> In-Reply-To: <20220803113104.1184059-4-junfeng.guo@intel.com> References: <20220803113104.1184059-1-junfeng.guo@intel.com> <20220803113104.1184059-4-junfeng.guo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 3 Aug 2022 19:30:54 +0800 Junfeng Guo wrote: > + > +static int > +idpf_dev_configure(struct rte_eth_dev *dev) > +{ > + struct idpf_vport *vport = > + (struct idpf_vport *)dev->data->dev_private; Cast of void pointer dev_private is unnecessary in C (only in C++ is it needed). > + int ret = 0; Useless initialization, you are setting in next line. > + > + ret = idpf_init_vport_req_info(dev); > + if (ret) {