From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24648A00C5; Wed, 3 Aug 2022 19:49:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D1CF42BB2; Wed, 3 Aug 2022 19:49:10 +0200 (CEST) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 720AB42BB1 for ; Wed, 3 Aug 2022 19:49:09 +0200 (CEST) Received: by mail-pg1-f173.google.com with SMTP id f11so15763349pgj.7 for ; Wed, 03 Aug 2022 10:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YklTj9XE7FIVGzZkBxQKEYlgATj126U71lgP9EFJHho=; b=MkEny4ReX218PEwl0bZro7y0y+7qRg4j4u6mQ107WkAITpCy9Ow2JYj0ihGXIcW61X kTG92y7Br7llxRUhaAsL1TpOmxKtGREKMPR4ZR4i2EJg2dK/fPpXSfVAI91IZzDt5Mfh rWy5iylLN7hqndJih39YyB5OVTFajy6ZfbBo1fZp92Bgyze+bui+xNFAX2QqjE43NC+x AejCXhdo/gp3VlrV1BnuyeOQx1GQecIzFXTVxo1JN2vuoaMvUM4GtlRd7hBS04JVoBZ0 9NtdOvCf5QnpAAsf3zTSzmf/+y3XK1HR/GGjTa1qTInW8k0W/lgrll8Pz6tUeYYNb86j HAsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YklTj9XE7FIVGzZkBxQKEYlgATj126U71lgP9EFJHho=; b=BEOVJvwXISm955lyU2VonkjW74i+ydy8Y9RsRyLWxNb0m0O4k3IRjEt8Z3FCTb2Llk NAf1o1pi8CPdRU8F0bGCUDhmj+lC3iU8NfFor1ReCBnJ+9SapU3+XvoJJUnJuf9g12IF 0AZmdXpZVn3XJFZF7e5PTRU6s8857bvjHzGihy42f4L/p6expaGevByHD5E1ifCA1T2C BiQ0dtN+jaHMCK9f+nTKdzv6+2WmHkEp52dexjKlleHY7vNACvq+PU1sh6Je+NL+SqQS 06WNrqETJIL8GopHvssqv9Oo6vcd4zAejrT2jZx3pUtXKXs9Wrg2f0OtVW6PnG6eCirg cpTA== X-Gm-Message-State: ACgBeo1SO8UUPJq0MggSIE6grhne1p03Xp64z8NDgxKSziEErG2LSiEY d3MsmfW/7vDomgX7tddRbYo6qQ== X-Google-Smtp-Source: AA6agR5XdwDWh9QJjQeziHRPjjjzuQEvnqTXYsFQ2jQPbmowC8EA3IuYpMQ0Oq80vsrBpMJvtKEFpA== X-Received: by 2002:a63:d652:0:b0:41c:45e9:abee with SMTP id d18-20020a63d652000000b0041c45e9abeemr10033474pgj.110.1659548948614; Wed, 03 Aug 2022 10:49:08 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id x17-20020aa79ad1000000b0052d90512a53sm6540615pfp.44.2022.08.03.10.49.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Aug 2022 10:49:08 -0700 (PDT) Date: Wed, 3 Aug 2022 10:49:06 -0700 From: Stephen Hemminger To: Naga Harish K S V Cc: erik.g.carrillo@intel.com, dev@dpdk.org Subject: Re: [PATCH 3/4] timer: fix rte_timer_stop_all Message-ID: <20220803104906.4013d349@hermes.local> In-Reply-To: <20220803162651.3145945-1-s.v.naga.harish.k@intel.com> References: <20220803162651.3145945-1-s.v.naga.harish.k@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 3 Aug 2022 11:26:51 -0500 Naga Harish K S V wrote: > there is a possibility of deadlock in this api, > as same spinlock is tried to be acquired in nested manner. > > This patch removes the acquisition of nested locking. > > Signed-off-by: Naga Harish K S V The wording in this commit message is a little confusing, what is the exact lock conflict? After your patch, there are no longer any callers for __rte_timer_stop() with the local_is_locked flag. Please resubmit and remove all the the local_is_locked from __rte_timer_stop(). It looks like the test suite for rte_timer is not exercising all the exposed API's. That's a problem