[PATCH 2/4] event/sw: report periodic event timer capability

[PATCH 2/4] event/sw: report periodic event timer capability

[Naga Harish K S V]

update the software eventdev pmd timer_adapter_caps_get
callback function to report the support of periodic
event timer capability

Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
---
 drivers/event/sw/sw_evdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index f93313b31b..89c07d30ae 100644
--- a/drivers/event/sw/sw_evdev.c
+++ b/drivers/event/sw/sw_evdev.c
@@ -564,7 +564,7 @@ sw_timer_adapter_caps_get(const struct rte_eventdev *dev, uint64_t flags,
 {
 	RTE_SET_USED(dev);
 	RTE_SET_USED(flags);
-	*caps = 0;
+	*caps = RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC;
 
 	/* Use default SW ops */
 	*ops = NULL;
-- 
2.25.1

RE: [PATCH 2/4] event/sw: report periodic event timer capability

[Van Haaren, Harry]

> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Wednesday, August 3, 2022 5:27 PM
> To: Carrillo, Erik G <erik.g.carrillo@intel.com>; jerinj@marvell.com; Van Haaren,
> Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH 2/4] event/sw: report periodic event timer capability
> 
> update the software eventdev pmd timer_adapter_caps_get
> callback function to report the support of periodic
> event timer capability

Apologies for my non-familiarity with the Eventdev and DPDK Timer features.. but
what does a PMD need to "do" to be capable of TIMER_ADAPTER_CAP_PERIODIC?

I see the code change to enable reporting that "sw pmd supports it", but I didn't
find (in rte_eventdev.h[0] or event-timer-adapter docs[1]) what the PMD must
actually "do" to support it?

If a PMD does not have to actually change anything in the implementation, then why does the flag exist at all?

<snip patch contents>

[0] https://doc.dpdk.org/api/rte__eventdev_8h.html#ac9a05105d3e7f16cce2776408571e1a2
[1] https://doc.dpdk.org/guides-21.05/prog_guide/event_timer_adapter.html

[PATCH v2 2/4] event/sw: report periodic event timer capability

[Naga Harish K S V]

update the software eventdev pmd timer_adapter_caps_get
callback function to report the support of periodic
event timer capability

Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
---
 drivers/event/sw/sw_evdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index f93313b31b..89c07d30ae 100644
--- a/drivers/event/sw/sw_evdev.c
+++ b/drivers/event/sw/sw_evdev.c
@@ -564,7 +564,7 @@ sw_timer_adapter_caps_get(const struct rte_eventdev *dev, uint64_t flags,
 {
 	RTE_SET_USED(dev);
 	RTE_SET_USED(flags);
-	*caps = 0;
+	*caps = RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC;
 
 	/* Use default SW ops */
 	*ops = NULL;
-- 
2.25.1

RE: [PATCH 2/4] event/sw: report periodic event timer capability

[Naga Harish K, S V]

Hi,


> -----Original Message-----
> From: Van Haaren, Harry <harry.van.haaren@intel.com>
> Sent: Friday, August 5, 2022 5:31 PM
> To: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; Carrillo, Erik G
> <erik.g.carrillo@intel.com>; jerinj@marvell.com
> Cc: dev@dpdk.org
> Subject: RE: [PATCH 2/4] event/sw: report periodic event timer capability
> 
> > -----Original Message-----
> > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > Sent: Wednesday, August 3, 2022 5:27 PM
> > To: Carrillo, Erik G <erik.g.carrillo@intel.com>; jerinj@marvell.com;
> > Van Haaren, Harry <harry.van.haaren@intel.com>
> > Cc: dev@dpdk.org
> > Subject: [PATCH 2/4] event/sw: report periodic event timer capability
> >
> > update the software eventdev pmd timer_adapter_caps_get callback
> > function to report the support of periodic event timer capability
> 
> Apologies for my non-familiarity with the Eventdev and DPDK Timer
> features.. but what does a PMD need to "do" to be capable of
> TIMER_ADAPTER_CAP_PERIODIC?
> 
> I see the code change to enable reporting that "sw pmd supports it", but I
> didn't find (in rte_eventdev.h[0] or event-timer-adapter docs[1]) what the
> PMD must actually "do" to support it?
> 
> If a PMD does not have to actually change anything in the implementation,
> then why does the flag exist at all?
> 
> <snip patch contents>
> 
> [0]
> https://doc.dpdk.org/api/rte__eventdev_8h.html#ac9a05105d3e7f16cce277
> 6408571e1a2
> [1] https://doc.dpdk.org/guides-
> 21.05/prog_guide/event_timer_adapter.html

The SW eventdev PMD also exposes other adapter (Eth Rx adapter, Crypto adapter) capabilities in the same manner.
In general eventdev PMDs provide the adapter capabilities by design.
This may be to accommodate the eventdev PMDs which have Hardware interface between NIC and event device.

-Harish

RE: [PATCH v2 2/4] event/sw: report periodic event timer capability

[Carrillo, Erik G]

Hi Harish,

> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Wednesday, August 10, 2022 2:10 AM
> To: Carrillo, Erik G <erik.g.carrillo@intel.com>; jerinj@marvell.com; Van
> Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH v2 2/4] event/sw: report periodic event timer capability
> 
> update the software eventdev pmd timer_adapter_caps_get callback
> function to report the support of periodic event timer capability
> 
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> ---
>  drivers/event/sw/sw_evdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
> index f93313b31b..89c07d30ae 100644
> --- a/drivers/event/sw/sw_evdev.c
> +++ b/drivers/event/sw/sw_evdev.c
> @@ -564,7 +564,7 @@ sw_timer_adapter_caps_get(const struct
> rte_eventdev *dev, uint64_t flags,  {
>  	RTE_SET_USED(dev);
>  	RTE_SET_USED(flags);
> -	*caps = 0;
> +	*caps = RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC;

It looks like we can add:

#define RTE_EVENT_TIMER_ADAPTER_SW_CAP \
	RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC

to eventdev_pmd.h (the same as RTE_EVENT_CRYPTO_ADAPTER_SW_CAP, for example), 

and use that definition here, and in rte_event_timer_adapter_caps_get().

Thanks,
Erik

> 
>  	/* Use default SW ops */
>  	*ops = NULL;
> --
> 2.25.1

RE: [PATCH v2 2/4] event/sw: report periodic event timer capability

[Van Haaren, Harry]

> -----Original Message-----
> From: Carrillo, Erik G <erik.g.carrillo@intel.com>
> Sent: Wednesday, August 10, 2022 9:52 PM
> To: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; jerinj@marvell.com; Van
> Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v2 2/4] event/sw: report periodic event timer capability
> 
> Hi Harish,
> 
> > -----Original Message-----
> > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > Sent: Wednesday, August 10, 2022 2:10 AM
> > To: Carrillo, Erik G <erik.g.carrillo@intel.com>; jerinj@marvell.com; Van
> > Haaren, Harry <harry.van.haaren@intel.com>
> > Cc: dev@dpdk.org
> > Subject: [PATCH v2 2/4] event/sw: report periodic event timer capability
> >
> > update the software eventdev pmd timer_adapter_caps_get callback
> > function to report the support of periodic event timer capability
> >
> > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> > ---
> >  drivers/event/sw/sw_evdev.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
> > index f93313b31b..89c07d30ae 100644
> > --- a/drivers/event/sw/sw_evdev.c
> > +++ b/drivers/event/sw/sw_evdev.c
> > @@ -564,7 +564,7 @@ sw_timer_adapter_caps_get(const struct
> > rte_eventdev *dev, uint64_t flags,  {
> >  	RTE_SET_USED(dev);
> >  	RTE_SET_USED(flags);
> > -	*caps = 0;
> > +	*caps = RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC;

Thanks Harish for the explanation as to why caps are exposed in the Eventdev PMD,
for related timer/etc features, makes sense.

> It looks like we can add:
> 
> #define RTE_EVENT_TIMER_ADAPTER_SW_CAP \
> 	RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC
> 
> to eventdev_pmd.h (the same as RTE_EVENT_CRYPTO_ADAPTER_SW_CAP, for
> example),
> 
> and use that definition here, and in rte_event_timer_adapter_caps_get().
> 
> Thanks,
> Erik

Erik, I like the suggestion of a standardized set of "generic SW" caps flags at the Eventdev level,
and then all SW based PMDs can use that #define, avoids each new cap needing changes in multiple drivers.

Good work, -Harry

[PATCH v3 2/4] event/sw: report periodic event timer capability

[Naga Harish K S V]

update the software eventdev pmd timer_adapter_caps_get
callback function to report the support of periodic
event timer capability

Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
---
 drivers/event/sw/sw_evdev.c | 2 +-
 lib/eventdev/eventdev_pmd.h | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index f93313b31b..6eddf8bd93 100644
--- a/drivers/event/sw/sw_evdev.c
+++ b/drivers/event/sw/sw_evdev.c
@@ -564,7 +564,7 @@ sw_timer_adapter_caps_get(const struct rte_eventdev *dev, uint64_t flags,
 {
 	RTE_SET_USED(dev);
 	RTE_SET_USED(flags);
-	*caps = 0;
+	*caps = RTE_EVENT_TIMER_ADAPTER_SW_CAP;
 
 	/* Use default SW ops */
 	*ops = NULL;
diff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h
index 69402668d8..9d43b73570 100644
--- a/lib/eventdev/eventdev_pmd.h
+++ b/lib/eventdev/eventdev_pmd.h
@@ -77,6 +77,9 @@ extern "C" {
 #define RTE_EVENT_CRYPTO_ADAPTER_SW_CAP \
 		RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA
 
+#define RTE_EVENT_TIMER_ADAPTER_SW_CAP \
+	RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC
+
 /**< Ethernet Rx adapter cap to return If the packet transfers from
  * the ethdev to eventdev use a SW service function
  */
-- 
2.25.1

RE: [PATCH v2 2/4] event/sw: report periodic event timer capability

[Naga Harish K, S V]

Hi Gabe,

> -----Original Message-----
> From: Carrillo, Erik G <erik.g.carrillo@intel.com>
> Sent: Thursday, August 11, 2022 2:22 AM
> To: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; jerinj@marvell.com;
> Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v2 2/4] event/sw: report periodic event timer capability
> 
> Hi Harish,
> 
> > -----Original Message-----
> > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > Sent: Wednesday, August 10, 2022 2:10 AM
> > To: Carrillo, Erik G <erik.g.carrillo@intel.com>; jerinj@marvell.com;
> > Van Haaren, Harry <harry.van.haaren@intel.com>
> > Cc: dev@dpdk.org
> > Subject: [PATCH v2 2/4] event/sw: report periodic event timer
> > capability
> >
> > update the software eventdev pmd timer_adapter_caps_get callback
> > function to report the support of periodic event timer capability
> >
> > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> > ---
> >  drivers/event/sw/sw_evdev.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
> > index f93313b31b..89c07d30ae 100644
> > --- a/drivers/event/sw/sw_evdev.c
> > +++ b/drivers/event/sw/sw_evdev.c
> > @@ -564,7 +564,7 @@ sw_timer_adapter_caps_get(const struct
> > rte_eventdev *dev, uint64_t flags,  {
> >  	RTE_SET_USED(dev);
> >  	RTE_SET_USED(flags);
> > -	*caps = 0;
> > +	*caps = RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC;
> 
> It looks like we can add:
> 
> #define RTE_EVENT_TIMER_ADAPTER_SW_CAP \
> 	RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC
> 
> to eventdev_pmd.h (the same as RTE_EVENT_CRYPTO_ADAPTER_SW_CAP,
> for example),
> 
> and use that definition here, and in rte_event_timer_adapter_caps_get().
> 

Taken in v3 version of the patch

> Thanks,
> Erik
> 
> >
> >  	/* Use default SW ops */
> >  	*ops = NULL;
> > --
> > 2.25.1

[PATCH v4 2/4] event/sw: report periodic event timer capability

[Naga Harish K S V]

update the software eventdev pmd timer_adapter_caps_get
callback function to report the support of periodic
event timer capability

Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
---
 drivers/event/sw/sw_evdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index f93313b31b..6eddf8bd93 100644
--- a/drivers/event/sw/sw_evdev.c
+++ b/drivers/event/sw/sw_evdev.c
@@ -564,7 +564,7 @@ sw_timer_adapter_caps_get(const struct rte_eventdev *dev, uint64_t flags,
 {
 	RTE_SET_USED(dev);
 	RTE_SET_USED(flags);
-	*caps = 0;
+	*caps = RTE_EVENT_TIMER_ADAPTER_SW_CAP;
 
 	/* Use default SW ops */
 	*ops = NULL;
-- 
2.25.1

RE: [PATCH v4 2/4] event/sw: report periodic event timer capability

[Van Haaren, Harry]

> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Friday, August 12, 2022 5:08 PM
> To: Carrillo, Erik G <erik.g.carrillo@intel.com>; jerinj@marvell.com; Van Haaren,
> Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH v4 2/4] event/sw: report periodic event timer capability
> 
> update the software eventdev pmd timer_adapter_caps_get
> callback function to report the support of periodic
> event timer capability
> 
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>

Thanks for explaining how things work on the v2 & follow-up reworks;
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

RE: [PATCH v4 2/4] event/sw: report periodic event timer capability

[Naga Harish K, S V]

Hi Jerin,
    This patch set (all 4 patches in the series) is acked by the respective maintainers.
Please review and do the needful.

-Harish

> -----Original Message-----
> From: Van Haaren, Harry <harry.van.haaren@intel.com>
> Sent: Tuesday, September 6, 2022 1:40 PM
> To: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; Carrillo, Erik G
> <erik.g.carrillo@intel.com>; jerinj@marvell.com
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v4 2/4] event/sw: report periodic event timer capability
> 
> > -----Original Message-----
> > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > Sent: Friday, August 12, 2022 5:08 PM
> > To: Carrillo, Erik G <erik.g.carrillo@intel.com>; jerinj@marvell.com;
> > Van Haaren, Harry <harry.van.haaren@intel.com>
> > Cc: dev@dpdk.org
> > Subject: [PATCH v4 2/4] event/sw: report periodic event timer
> > capability
> >
> > update the software eventdev pmd timer_adapter_caps_get callback
> > function to report the support of periodic event timer capability
> >
> > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> 
> Thanks for explaining how things work on the v2 & follow-up reworks;
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>