From: Amit Prakash Shukla <amitprakashs@marvell.com>
To: Fan Zhang <roy.fan.zhang@intel.com>
Cc: <dev@dpdk.org>, <jerinj@marvell.com>,
Amit Prakash Shukla <amitprakashs@marvell.com>
Subject: [PATCH 3/3] crypto/qat: compilation fix for GCC-12
Date: Thu, 4 Aug 2022 19:10:55 +0530 [thread overview]
Message-ID: <20220804134055.1816993-3-amitprakashs@marvell.com> (raw)
In-Reply-To: <20220804134055.1816993-1-amitprakashs@marvell.com>
GCC 12 raises the following warning:
from ../lib/eal/x86/include/rte_vect.h:31,
from ../lib/eal/x86/include/rte_memcpy.h:17,
from ../drivers/crypto/qat/qat_sym_session.c:10:
In function '_mm_storeu_si128',
inlined from 'rte_mov16' at
../lib/eal/x86/include/rte_memcpy.h:508:2,
inlined from 'rte_mov128' at
../lib/eal/x86/include/rte_memcpy.h:542:2,
inlined from 'rte_memcpy_generic' at
../lib/eal/x86/include/rte_memcpy.h:732:4,
inlined from 'rte_memcpy' at
../lib/eal/x86/include/rte_memcpy.h:882:10,
inlined from 'qat_sym_do_precomputes.constprop' at
../drivers/crypto/qat/qat_sym_session.c:1434:2:
/usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/include/emmintrin.h:739:8: error:
array subscript 8 is outside array bounds of 'unsigned char[128]'
[-Werror=array-bounds]
739 | *__P = __B;
| ~~~~~^~~~~
../drivers/crypto/qat/qat_sym_session.c:
In function 'qat_sym_do_precomputes.constprop':
../drivers/crypto/qat/qat_sym_session.c:1305:17: note:
at offset 192 into object 'opad.750' of size 128
1305 | uint8_t
opad[qat_hash_get_block_size(ICP_QAT_HW_AUTH_ALGO_DELIMITER)];
| ^~~~
../drivers/crypto/qat/qat_sym_session.c:
In function 'qat_sym_do_precomputes.constprop':
../drivers/crypto/qat/qat_sym_session.c:1304:17: note:
at offset 128 into object 'ipad.749' of size 128
1304 | uint8_t
ipad[qat_hash_get_block_size(ICP_QAT_HW_AUTH_ALGO_DELIMITER)];
| ^~~~
Added a check to prevent compiler warnings.
Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
---
drivers/crypto/qat/qat_sym_session.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c
index 8ca475ca8b..4c513186d4 100644
--- a/drivers/crypto/qat/qat_sym_session.c
+++ b/drivers/crypto/qat/qat_sym_session.c
@@ -1431,6 +1431,10 @@ static int qat_sym_do_precomputes(enum icp_qat_hw_auth_algo hash_alg,
QAT_LOG(ERR, "invalid keylen %u", auth_keylen);
return -EFAULT;
}
+
+ RTE_VERIFY(auth_keylen <= sizeof(ipad));
+ RTE_VERIFY(auth_keylen <= sizeof(opad));
+
rte_memcpy(ipad, auth_key, auth_keylen);
rte_memcpy(opad, auth_key, auth_keylen);
--
2.25.1
next prev parent reply other threads:[~2022-08-04 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 13:40 [PATCH 1/3] test/test_ipsec: " Amit Prakash Shukla
2022-08-04 13:40 ` [PATCH 2/3] ipsec: " Amit Prakash Shukla
2022-08-07 13:17 ` Konstantin Ananyev
2022-08-04 13:40 ` Amit Prakash Shukla [this message]
2022-08-05 8:12 ` [PATCH 3/3] crypto/qat: " Zhang, Roy Fan
2022-08-28 12:01 ` [EXT] [PATCH 1/3] test/test_ipsec: " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804134055.1816993-3-amitprakashs@marvell.com \
--to=amitprakashs@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).