From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07616A00C4; Sat, 6 Aug 2022 00:00:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1806942905; Sat, 6 Aug 2022 00:00:38 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 49EEE400D6 for ; Sat, 6 Aug 2022 00:00:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659736835; x=1691272835; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=ZBh62HpW23Ht9f6a4VoeI/C2wkX5PrS7PTH/YxhgW8s=; b=F3+v0lQxUBKl3cLS19NJdjhOADID9eYUZ0W0IvMcutQ+BFy2891oTrSW hzsNo7cxuPbvx5MHrfi9JDcSfg0dXeFrjJEMY/l9fYggnuzk7DYkz0RhQ swF/bxIMHTX7p8QL2y2r8VLy1Jf7ypZHRESdhvquSPKQ/5fKzrEyrD7rm zdB5qZ2DsVPD6K24aung9QPXFxSkebZWSgK2EpoeasbxlKBgF2NNQSQCl CHoIiHCJB5lNdoJ14Dc8Z4HHoItP8YBCBxhMQ7F++E17rtAcJUh+fWLuz MST+98MeQlkEUds3KNVlPdznG0WcK0jWCvpKsWGAleuACEnnZTZzVNOaf g==; X-IronPort-AV: E=McAfee;i="6400,9594,10430"; a="290308813" X-IronPort-AV: E=Sophos;i="5.93,216,1654585200"; d="scan'208";a="290308813" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2022 15:00:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,217,1654585200"; d="scan'208";a="693137562" Received: from silpixa00400573.ir.intel.com (HELO silpixa00400573.ger.corp.intel.com.) ([10.237.223.157]) by FMSMGA003.fm.intel.com with ESMTP; 05 Aug 2022 15:00:33 -0700 From: Cristian Dumitrescu To: dev@dpdk.org Subject: [PATCH 05/10] port: prevent unnecessary flush for the Ethernet device output port Date: Fri, 5 Aug 2022 22:00:24 +0000 Message-Id: <20220805220029.1096212-6-cristian.dumitrescu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220805220029.1096212-1-cristian.dumitrescu@intel.com> References: <20220805220029.1096212-1-cristian.dumitrescu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do not flush the buffered packets unnecessarily when a burst was sent since the last flush call. Signed-off-by: Cristian Dumitrescu --- lib/port/rte_swx_port_ethdev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/port/rte_swx_port_ethdev.c b/lib/port/rte_swx_port_ethdev.c index 8a1da71003..7cb3c4dfb1 100644 --- a/lib/port/rte_swx_port_ethdev.c +++ b/lib/port/rte_swx_port_ethdev.c @@ -174,6 +174,7 @@ struct writer { struct rte_mbuf **pkts; int n_pkts; uint32_t n_bytes; + int flush_flag; }; static void * @@ -249,6 +250,7 @@ __writer_flush(struct writer *p) p->stats.n_bytes_drop = n_bytes_drop_total + n_bytes_drop; p->n_pkts = 0; p->n_bytes = 0; + p->flush_flag = 0; TRACE("[Ethdev TX port %u queue %u] Buffered packets flushed: %d out, %d dropped\n", (uint32_t)p->params.port_id, @@ -363,8 +365,10 @@ writer_flush(void *port) { struct writer *p = port; - if (p->n_pkts) + if (p->n_pkts && p->flush_flag) __writer_flush(p); + + p->flush_flag = 1; } static void -- 2.34.1