From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E878A00C5; Tue, 9 Aug 2022 11:15:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55F6F4069C; Tue, 9 Aug 2022 11:15:51 +0200 (CEST) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mails.dpdk.org (Postfix) with ESMTP id 8C22740143 for ; Tue, 9 Aug 2022 11:15:50 +0200 (CEST) Received: by mail-lf1-f45.google.com with SMTP id r17so16115374lfm.11 for ; Tue, 09 Aug 2022 02:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc; bh=+3cgzhpcJv6/svL7dkdA4Ckl2LwI09QVOIQ4l/ZpOnU=; b=fz4M0dKNNfeG5y7AkBZ4g9e4FYoZTUXnbud8bhkN5wrpsVHt7jB7f9Z5A6Nwfk/jyW JuRiE+3lVnL+sr17+yfSOuiCWxzS5Tns/R3K+5uOdKAKUPzx9iB6yfYbsqlxKQac682v KlruH0iBZFY4Hp3S9FeXuKxbclfHPbcdEtCap4k3fA8CAXQydxKoFgMOJa2d/RrHbhuU TO6yHSG9AdbHpNOiejRauFOU+/t0JsZy/yc6RyoiondGoIDN9a9C8wKAFs/tQuh3wzYQ 6phjouYrnty5jvfeDPNHpY4+IobttSjTGk6uriQkCNkcnIweAm3DALyFAqi8/B2lOJZ5 gYNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=+3cgzhpcJv6/svL7dkdA4Ckl2LwI09QVOIQ4l/ZpOnU=; b=nVI2AEBAHuLEgZK80j9DKs+BNo/actorNDWosEahc0LhgDUdqFe1BvtwWM4pnU5+y3 a4Bmu9VC0OyjNO6Ya5ZKMHJ6Br8UYzXqI07xNeuP9Xy47FIY+KHJLfWnYpgcnfK9WUEZ iJDubC0TKh833RxBpPQv0vQbrCzN2+lkZkehzyxk3qnpJocjM9FY8Bk9DLA7LYY6ah7K qp3ad3L3BashdntQMBoiJgk7dqIlC0BqJyhJ8rq6RDiCSjHZxcrsBluWagaOhrpd7avc Cp9P7emgNTPbTT8XZEz/hAXkQ5AHCDM0YFMdVTUbDWcnixH4xTH8DMK82EtkWwVS7sLN lY5g== X-Gm-Message-State: ACgBeo1Ivls+EI9dIH+a8sjjoQHt/sFkIFv2OvO8On2j/hMKNVQDKXEl Zo4zq6dCG7VOTs5PpGMEqd0= X-Google-Smtp-Source: AA6agR7pYtTCfodlAe6aQ2ePlt+kAii1r4Cj9RbCSRh4dRkiZetGaeLM5K2W36+/WOqEf3CA7DM9jw== X-Received: by 2002:a05:6512:3609:b0:48a:ef9f:9465 with SMTP id f9-20020a056512360900b0048aef9f9465mr8406573lfs.115.1660036549920; Tue, 09 Aug 2022 02:15:49 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id i39-20020a0565123e2700b0048a91266268sm1690798lfv.232.2022.08.09.02.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Aug 2022 02:15:49 -0700 (PDT) Date: Tue, 9 Aug 2022 12:15:48 +0300 From: Dmitry Kozlyuk To: "Kadam, Pallavi" Cc: , , , , , Subject: Re: [dpdk-kmods] windows/netuio: fix bar parsing Message-ID: <20220809121548.00a18082@sovereign> In-Reply-To: References: <20220802191058.1779-1-pallavi.kadam@intel.com> <20220807000113.4f773581@sovereign> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2022-08-08 17:33 (UTC-0700), Kadam, Pallavi: [...] > > Hi Pallavi, > > > > In the first place, it was wrong to always test `prev_bar & PCI_TYPE_64BIT` > > because only the first BAR slot of a 64-bit BAR contains flags. > > The current code has a state to track (curr_bar, prev_bar), > > and the fix is complicating it even more without solving the root cause. > > I suggest a simpler fix (not tested!) > > that eliminates both the incorrectness and the state to maintain: > > Thank you. This change works for us. > > Please let me know if you would like to submit this change as a new patch or if I should include it as a v2 of this same patch. Please send v2. You can include my Signed-off-by. You might also update the commit message and capitalize "BAR" in the title.