From: zhichaox.zeng@intel.com
To: dev@dpdk.org
Cc: qiming.yang@intel.com, yidingx.zhou@intel.com,
Zhichao Zeng <zhichaox.zeng@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>
Subject: [PATCH] net/ice: remove deprecated VF flow action
Date: Wed, 10 Aug 2022 14:49:37 +0800 [thread overview]
Message-ID: <20220810064937.162455-1-zhichaox.zeng@intel.com> (raw)
From: Zhichao Zeng <zhichaox.zeng@intel.com>
According to the ABI and API Deprecation, remove deprecated VF action
as hard-to-use / ambiguous.
Action REPRESENTED_PORT should be used instead.
Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
---
doc/guides/nics/features/ice.ini | 1 -
drivers/net/ice/ice_switch_filter.c | 22 ----------------------
2 files changed, 23 deletions(-)
diff --git a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features/ice.ini
index 12fd802885..fe1e81302c 100644
--- a/doc/guides/nics/features/ice.ini
+++ b/doc/guides/nics/features/ice.ini
@@ -81,5 +81,4 @@ mark = Y
passthru = Y
queue = Y
rss = Y
-vf = Y
represented_port = Y
diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
index 5d65988474..da81e49bfa 100644
--- a/drivers/net/ice/ice_switch_filter.c
+++ b/drivers/net/ice/ice_switch_filter.c
@@ -1619,7 +1619,6 @@ ice_switch_parse_dcf_action(struct ice_dcf_adapter *ad,
struct ice_adv_rule_info *rule_info)
{
const struct rte_flow_action_ethdev *act_ethdev;
- const struct rte_flow_action_vf *act_vf;
const struct rte_flow_action *action;
const struct rte_eth_dev *repr_dev;
enum rte_flow_action_type action_type;
@@ -1629,26 +1628,6 @@ ice_switch_parse_dcf_action(struct ice_dcf_adapter *ad,
RTE_FLOW_ACTION_TYPE_END; action++) {
action_type = action->type;
switch (action_type) {
- case RTE_FLOW_ACTION_TYPE_VF:
- rule_info->sw_act.fltr_act = ICE_FWD_TO_VSI;
- act_vf = action->conf;
-
- if (act_vf->id >= ad->real_hw.num_vfs &&
- !act_vf->original) {
- rte_flow_error_set(error,
- EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
- actions,
- "Invalid vf id");
- return -rte_errno;
- }
-
- if (act_vf->original)
- rule_info->sw_act.vsi_handle =
- ad->real_hw.avf.bus.func;
- else
- rule_info->sw_act.vsi_handle = act_vf->id;
- break;
-
case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT:
rule_info->sw_act.fltr_act = ICE_FWD_TO_VSI;
act_ethdev = action->conf;
@@ -1812,7 +1791,6 @@ ice_switch_check_action(const struct rte_flow_action *actions,
RTE_FLOW_ACTION_TYPE_END; action++) {
action_type = action->type;
switch (action_type) {
- case RTE_FLOW_ACTION_TYPE_VF:
case RTE_FLOW_ACTION_TYPE_RSS:
case RTE_FLOW_ACTION_TYPE_QUEUE:
case RTE_FLOW_ACTION_TYPE_DROP:
--
2.25.1
next reply other threads:[~2022-08-10 6:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 6:49 zhichaox.zeng [this message]
2022-08-12 2:44 ` Zhang, Qi Z
2022-08-30 1:23 Xu, Ke1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220810064937.162455-1-zhichaox.zeng@intel.com \
--to=zhichaox.zeng@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).