From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B74CEA0545; Wed, 10 Aug 2022 15:50:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7D9E40DDE; Wed, 10 Aug 2022 15:50:33 +0200 (CEST) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id D89004067C for ; Wed, 10 Aug 2022 15:50:32 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id m2so14302210pls.4 for ; Wed, 10 Aug 2022 06:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc; bh=VlA/2X9v3sWlFXmvb5AM3KU6M1kfpgnDMH6P2wdNyIY=; b=QYt8K1WQ5DauBYWpCvrKsPkpiVOGyghMC1klEdwehR4ywhS7J25xlNUyItHY5GPlp8 zRjUZ9ZKUINQbwDlMymsKDBLgAo+9IBQ3KxLmqhrHcWMkCxaXfjKYyxToRvVE/Ti+CmS LmLkC41DilCzK2gmDm8vRwPrTTgp7p5a0LfLr2pEu+aq95qSfweld8sKjAVNCrk01MnW 7BLmZoWnjI7u7bk2Nh7TcPhtomfZiKJEx9ANxmVEPpJmqrIBdfjkQ6bGcJZn4EeuYsM3 t3UpDZUNi4eEo6n3E5KHOG00d8EmFM4w/J7is9A8m7a/sqJTyWEcIHlPu3ZSO+UgMUz5 4nvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=VlA/2X9v3sWlFXmvb5AM3KU6M1kfpgnDMH6P2wdNyIY=; b=w1hpUmW2CyYJiDMwPY/YwKX3IQwTythFh8uQH0jGrHToiVQUVLUH2VQ25bZ2FU634g wa1ZkjUUP/OQsRkHUlXVlHJuzAWQBLeGgB8xliKnILp9Cq8ISbT+v2dXH6c3cvak+lDu Bi2r/B2qHGzJinquwo5W9GhVHTYDwySBciWtzu444OHOMly3PajWetSZIzKax/0ZK8Rm w9mVpMG7CYXNFz/XlHvPcw7k/k1DhANZIcNH7QSkC2/V4D3399WFL4b26IR7MTQ8/Z/v 2ufhze+iLSn91Z/ztY+Y5kZU4bp/aCj7T5pgVaZ/7EwFgzcpQQZQuZkRvJVaUtKPYDFW 36hQ== X-Gm-Message-State: ACgBeo1X8tu7YZtHrkLp1/6CWgrShEQ9uD743EIdtWi9S3TJXW7vjn3g UvzqXsSLbsUno/HxWNeIBcGNXQ== X-Google-Smtp-Source: AA6agR5lKx8nM1MUBXovW5rLz9nwmLlKilENcsR09JZZpGq4aKW/VVv7ySBvnvTHj3fHzYXE6wG+nw== X-Received: by 2002:a17:90b:1b01:b0:1f7:3e2c:7ea7 with SMTP id nu1-20020a17090b1b0100b001f73e2c7ea7mr3877412pjb.59.1660139432115; Wed, 10 Aug 2022 06:50:32 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id d196-20020a621dcd000000b0052e6d6f3cb7sm1927424pfd.189.2022.08.10.06.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Aug 2022 06:50:31 -0700 (PDT) Date: Wed, 10 Aug 2022 06:50:30 -0700 From: Stephen Hemminger To: Krzysztof Kozlowski Cc: "lihuisong (C)" , dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, thomas@monjalon.net, ferruh.yigit@xilinx.com, huangdaode@huawei.com, liudongdong3@huawei.com Subject: Re: [PATCH] usertools: fix bind failure from dpdk to kernel Message-ID: <20220810065030.687e0e31@hermes.local> In-Reply-To: References: <20220805031022.9795-1-lihuisong@huawei.com> <20220805083529.5ca3233e@hermes.local> <20220809105852.42051ed4@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 10 Aug 2022 09:02:57 +0300 Krzysztof Kozlowski wrote: > On 09/08/2022 20:58, Stephen Hemminger wrote: > >> > >> However, due to the patch[1] merged into 5.19 kernel, 'driver_override' > >> in the pci_dev is no longer NULL by writing '\00' to driver_override file. > >> This causes PCI match device failure and the device will never be bound to > >> their kernel driver. > > > > > > Linux kernel does not look favorably on API changes and that looks like > > the kernel changed behavior. That should be reported and fixed there. > > To clarify around this issue: > > There were no API changes. Linux kernel follows the API exactly how it > is described in the API document since 2014: > Documentation/ABI/testing/sysfs-bus-pci > > There was no change in kernel API. > > There was a change in undocumented, unsupported and wrong usage of > driver_override API. > > Best regards, > Krzysztof Linux documentation is not the standard, the code is.