DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v1] net/ice/base: fix switch rules not cleared on warm reset
@ 2022-08-12  2:52 Steve Yang
  0 siblings, 0 replies; only message in thread
From: Steve Yang @ 2022-08-12  2:52 UTC (permalink / raw)
  To: dev; +Cc: qiming.yang, qi.z.zhang, Steve Yang, stable

When users killed app forcely (e.g.: kill -9 pid), the driver reset
couldn't make all registers of NIC recovery to initial status.
For example, the switch filter rules, which involved the vlan tag,
couldn't be added.

Tell the Firmware to shut down the AdminQ to avoid possible error
when process was killed abnormally.

Fixes: 453d087ccaff ("net/ice/base: add common functions")
Cc: stable@dpdk.org

Signed-off-by: Steve Yang <stevex.yang@intel.com>
---
 drivers/net/ice/base/ice_common.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c
index db87bacd97..66b51be29d 100644
--- a/drivers/net/ice/base/ice_common.c
+++ b/drivers/net/ice/base/ice_common.c
@@ -926,6 +926,11 @@ enum ice_status ice_init_hw(struct ice_hw *hw)
 	if (status)
 		goto err_unroll_cqinit;
 
+	/* Tell the Firmware to shut down the AdminQ to avoid possible error
+	 * when process was killed abnormally.
+	 */
+	ice_aq_q_shutdown(hw, true);
+
 	status = ice_init_nvm(hw);
 	if (status)
 		goto err_unroll_cqinit;
-- 
2.25.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-08-12  3:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-12  2:52 [PATCH v1] net/ice/base: fix switch rules not cleared on warm reset Steve Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).