From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
To: <dev@dpdk.org>
Cc: Anoob Joseph <anoobj@marvell.com>,
Fan Zhang <roy.fan.zhang@intel.com>,
Brian Dooley <brian.dooley@intel.com>,
Akhil Goyal <gakhil@marvell.com>, <jerinj@marvell.com>,
Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Subject: [PATCH v2 1/2] examples/fips_validation: share test callback with multiple keys
Date: Fri, 12 Aug 2022 17:22:00 +0530 [thread overview]
Message-ID: <20220812115201.1032352-1-gmuthukrishn@marvell.com> (raw)
In-Reply-To: <73d188a54d126678538a1a2b7d8b9aae95e4e6d8.1657694117.git.gmuthukrishn@marvell.com>
Make use of key param in test callbacks so that, test callback
can be shared with multiple keys.
Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
---
examples/fips_validation/fips_validation.c | 27 +++++++++++++++-------
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/examples/fips_validation/fips_validation.c b/examples/fips_validation/fips_validation.c
index 12b9b03f56..9678aa2161 100644
--- a/examples/fips_validation/fips_validation.c
+++ b/examples/fips_validation/fips_validation.c
@@ -499,11 +499,8 @@ fips_test_parse_one_json_group(void)
return -EINVAL;
}
- /* First argument is blank because the key
- * is not included in the string being parsed.
- */
ret = info.interim_callbacks[i].cb(
- "", json_value,
+ info.interim_callbacks[i].key, json_value,
info.interim_callbacks[i].val
);
if (ret < 0)
@@ -525,11 +522,8 @@ fips_test_parse_one_json_case(void)
param = json_object_get(json_info.json_test_case, info.callbacks[i].key);
if (param) {
strcpy(info.one_line_text, json_string_value(param));
- /* First argument is blank because the key
- * is not included in the string being parsed.
- */
ret = info.callbacks[i].cb(
- "", info.one_line_text,
+ info.callbacks[i].key, info.one_line_text,
info.callbacks[i].val
);
if (ret < 0)
@@ -625,7 +619,14 @@ parse_uint8_hex_str(const char *key, char *src, struct fips_val *val)
{
uint32_t len, j;
+#ifdef USE_JANSSON
+ /*
+ * Offset not applicable in case of JSON test vectors.
+ */
+ RTE_SET_USED(key);
+#else
src += strlen(key);
+#endif
len = strlen(src) / 2;
@@ -653,6 +654,15 @@ parse_uint8_hex_str(const char *key, char *src, struct fips_val *val)
return 0;
}
+#ifdef USE_JANSSON
+int
+parser_read_uint32_val(const char *key, char *src, struct fips_val *val)
+{
+ RTE_SET_USED(key);
+
+ return parser_read_uint32(&val->len, src);
+}
+#else
int
parser_read_uint32_val(const char *key, char *src, struct fips_val *val)
{
@@ -676,6 +686,7 @@ parser_read_uint32_val(const char *key, char *src, struct fips_val *val)
return ret;
}
+#endif
int
parser_read_uint32_bit_val(const char *key, char *src, struct fips_val *val)
--
2.25.1
next prev parent reply other threads:[~2022-08-12 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 6:39 [PATCH v1 1/2] examples/fips_validation: skip offsetting source for json vectors Gowrishankar Muthukrishnan
2022-07-13 6:39 ` [PATCH v1 2/2] examples/fips_validation: add parsing for tdes Gowrishankar Muthukrishnan
2022-08-12 11:52 ` Gowrishankar Muthukrishnan [this message]
2022-08-12 11:52 ` [PATCH v2 2/2] examples/fips_validation: add parsing for TDES Gowrishankar Muthukrishnan
2022-09-23 16:30 ` Dooley, Brian
2022-10-07 9:55 ` Akhil Goyal
2022-10-06 13:13 ` [PATCH v2 1/2] examples/fips_validation: share test callback with multiple keys Dooley, Brian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220812115201.1032352-1-gmuthukrishn@marvell.com \
--to=gmuthukrishn@marvell.com \
--cc=anoobj@marvell.com \
--cc=brian.dooley@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).