* [PATCH] app/proc-info: add rte_eal_cleanup() to avoid memory leak
@ 2022-08-18 11:37 Fidaullah Noonari
2022-08-18 14:53 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Fidaullah Noonari @ 2022-08-18 11:37 UTC (permalink / raw)
To: maryam.tahhan; +Cc: dev, Fidaullah Noonari
when app is launched with -m proc-info exit without
rte_eal_cleanup() causing memory leakage. This commit resolves the
memory leakage issue and closes app properly.
Bugzilla id: 898
Signed-off-by: Fidaullah Noonari <fidaullah.noonari@emumba.com>
---
app/proc-info/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 1bfba5f60d..44a946045e 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -1523,6 +1523,9 @@ main(int argc, char **argv)
if (mem_info) {
meminfo_display();
+ ret = rte_eal_cleanup();
+ if (ret != 0)
+ printf("Error from rte_eal_cleanup(), %d\n", ret);
return 0;
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] app/proc-info: add rte_eal_cleanup() to avoid memory leak
2022-08-18 11:37 [PATCH] app/proc-info: add rte_eal_cleanup() to avoid memory leak Fidaullah Noonari
@ 2022-08-18 14:53 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2022-08-18 14:53 UTC (permalink / raw)
To: Fidaullah Noonari; +Cc: maryam.tahhan, dev
On Thu, 18 Aug 2022 16:37:42 +0500
Fidaullah Noonari <fidaullah.noonari@emumba.com> wrote:
> when app is launched with -m proc-info exit without
> rte_eal_cleanup() causing memory leakage. This commit resolves the
> memory leakage issue and closes app properly.
>
> Bugzilla id: 898
>
> Signed-off-by: Fidaullah Noonari <fidaullah.noonari@emumba.com>
> ---
> app/proc-info/main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/app/proc-info/main.c b/app/proc-info/main.c
> index 1bfba5f60d..44a946045e 100644
> --- a/app/proc-info/main.c
> +++ b/app/proc-info/main.c
> @@ -1523,6 +1523,9 @@ main(int argc, char **argv)
>
> if (mem_info) {
> meminfo_display();
> + ret = rte_eal_cleanup();
> + if (ret != 0)
> + printf("Error from rte_eal_cleanup(), %d\n", ret);
A goto would avoid duplicating code:
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 1bfba5f60d10..9cfcce31ab9a 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -1523,7 +1523,7 @@ main(int argc, char **argv)
if (mem_info) {
meminfo_display();
- return 0;
+ goto cleanup;
}
nb_ports = rte_eth_dev_count_avail();
@@ -1593,6 +1593,7 @@ main(int argc, char **argv)
RTE_ETH_FOREACH_DEV(i)
rte_eth_dev_close(i);
+cleanup:
ret = rte_eal_cleanup();
if (ret)
printf("Error from rte_eal_cleanup(), %d\n", ret);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-18 14:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-18 11:37 [PATCH] app/proc-info: add rte_eal_cleanup() to avoid memory leak Fidaullah Noonari
2022-08-18 14:53 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).