DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shinae Woo <shinae@alkira.net>
To: dev@dpdk.org
Subject: [PATCH] linux/igb_uio: make module parameters visible in sysfs
Date: Sun, 21 Aug 2022 16:19:50 -0700	[thread overview]
Message-ID: <20220821231950.5957-1-shinae@alkira.net> (raw)

- explicitly set default value for intr_mode
- give read permission on wc_activate
- applying patch gives below visibility

```
$ more /sys/module/igb_uio/parameters/* | cat
::::::::::::::
/sys/module/igb_uio/parameters/intr_mode
::::::::::::::
msix
::::::::::::::
/sys/module/igb_uio/parameters/wc_activate
::::::::::::::
0
```

Signed-off-by: Shinae Woo <shinae@alkira.net>
---
 linux/igb_uio/igb_uio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c
index 33e0e02..c927ae6 100644
--- a/linux/igb_uio/igb_uio.c
+++ b/linux/igb_uio/igb_uio.c
@@ -44,7 +44,7 @@ struct rte_uio_pci_dev {
 };
 
 static int wc_activate;
-static char *intr_mode;
+static char *intr_mode = RTE_INTR_MODE_MSIX_NAME;
 static enum rte_intr_mode igbuio_intr_mode_preferred = RTE_INTR_MODE_MSIX;
 /* sriov sysfs */
 static ssize_t
@@ -663,7 +663,7 @@ MODULE_PARM_DESC(intr_mode,
 "    " RTE_INTR_MODE_LEGACY_NAME "     Use Legacy interrupt\n"
 "\n");
 
-module_param(wc_activate, int, 0);
+module_param(wc_activate, int, S_IRUGO);
 MODULE_PARM_DESC(wc_activate,
 "Activate support for write combining (WC) (default=0)\n"
 "    0 - disable\n"
-- 
2.20.1


             reply	other threads:[~2022-08-21 23:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-21 23:19 Shinae Woo [this message]
2023-10-31 16:59 ` Stephen Hemminger
  -- strict thread matches above, loose matches on Subject: below --
2022-08-21 22:12 Shinae Woo
2023-07-06  2:40 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220821231950.5957-1-shinae@alkira.net \
    --to=shinae@alkira.net \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).