From: Huisong Li <lihuisong@huawei.com>
To: <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <ferruh.yigit@xilinx.com>,
<andrew.rybchenko@oktetlabs.ru>, <huangdaode@huawei.com>,
<lihuisong@huawei.com>
Subject: [PATCH 4/6] app/testpmd: check the validity of the port
Date: Thu, 25 Aug 2022 10:57:17 +0800 [thread overview]
Message-ID: <20220825025719.14281-5-lihuisong@huawei.com> (raw)
In-Reply-To: <20220825025719.14281-1-lihuisong@huawei.com>
This patch checks the validity of port id for all events in
'eth_event_callback()'.
Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
app/test-pmd/testpmd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index addcbcac85..c743d65cf2 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3706,14 +3706,15 @@ eth_event_callback(portid_t port_id, enum rte_eth_event_type type, void *param,
fflush(stdout);
}
+ if (port_id_is_invalid(port_id, DISABLED_WARN))
+ return 0;
+
switch (type) {
case RTE_ETH_EVENT_NEW:
ports[port_id].need_setup = 1;
ports[port_id].port_status = RTE_PORT_HANDLING;
break;
case RTE_ETH_EVENT_INTR_RMV:
- if (port_id_is_invalid(port_id, DISABLED_WARN))
- break;
if (rte_eal_alarm_set(100000,
rmv_port_callback, (void *)(intptr_t)port_id))
fprintf(stderr,
--
2.22.0
next prev parent reply other threads:[~2022-08-25 2:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 2:57 [PATCH 0/6] app/testpmd: support attach and detach port for MP Huisong Li
2022-08-25 2:57 ` [PATCH 1/6] bus/pci: fix a segfault when call callback Huisong Li
2022-08-25 2:57 ` [PATCH 2/6] bus/vdev: " Huisong Li
2022-08-25 2:57 ` [PATCH 3/6] ethdev: fix push new event Huisong Li
2022-08-25 2:57 ` Huisong Li [this message]
2022-08-25 2:57 ` [PATCH 5/6] app/testpmd: support attach and detach port for MP Huisong Li
2022-08-25 2:57 ` [PATCH 6/6] app/testpmd: stop packet forwarding in new and destroy event Huisong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220825025719.14281-5-lihuisong@huawei.com \
--to=lihuisong@huawei.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=huangdaode@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).