From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A142A0547; Thu, 25 Aug 2022 17:37:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61C9F42B6C; Thu, 25 Aug 2022 17:37:32 +0200 (CEST) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by mails.dpdk.org (Postfix) with ESMTP id C0C244280B for ; Thu, 25 Aug 2022 17:37:28 +0200 (CEST) Received: by mail-lj1-f176.google.com with SMTP id s8so2358201ljj.5 for ; Thu, 25 Aug 2022 08:37:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=flSZ51o96WQTICQNKPA/3pAXVbZ+zl7tcADll00WpMQ=; b=bCqtzy3DK7/Vp2i9I2pXf8GUPzCZTu8FPT/3pI+veT5R+wkYA+w4vcx6CZO1SPOeaA Su542zu6+FpMn39LjPwAbMMHhkKj4qoQ8WXC4qJNVAM4CgF86tdmlDyVck2wbSEc3+35 a+oLm6E/HMKiV94oNdeydeZCs0hZpt3SOiO/SswlEy0P+ykeJt/SNU0IZgyHijvvL591 MPHDoPxLiNj5mRTSKt8UQEaIOCd1zFSFiX+L8IYrCvb7c6jbyEj+vkhpsfsIV2r5ySqV ffvJ3Qe45FOhz14l/Azq3DAKEHW8/CV0Hgs6OsXRhNm4QSmtWMSmF06TZELd9P+YnEoR gzMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=flSZ51o96WQTICQNKPA/3pAXVbZ+zl7tcADll00WpMQ=; b=yviWITdho+xG6387HCwmvPkSn7wmZ5BIqG9Weo2qk+iHcPEPEVRFX6MK97rx3TOitt +x3nNSVkab1qb0+OAtaJysLplOKOobmIYk6OoytzziI3Sl5A3SqRy5WIuRN0DAAT6kxn nPHoA+/h/gJ+WqVJ0Y0hmXPG1zQ2xhvqv14kwQoijKYGogBnTYR4PPkDwZdaKUmiWJ09 X1qypafm7ZbOKqwAfLBME23hidrmrTrU7s5dsLaXJMNp1Koicf+fgNuvOP2edPHi+wbA qAqoRzqyS4D34Q2M9mBMMDJfMVcYMNCouVo8YxHd0RVgI2ck3AUvpjij7DyIrZjPbLEq q0Nw== X-Gm-Message-State: ACgBeo29beA3MkjftJOVMdTRnsorKoDZya/kWR7MaMzFrOnXL/6rJoXk JMu1Pt2IL006fL47Jbn3jmjXz9lfYIA= X-Google-Smtp-Source: AA6agR7zE9vcjH+G5T2HA+BzYbrg5WOT++s+nhuUCQFRa2DSp8zRd6+OQ2M5sNNtpS3qo0UArY084Q== X-Received: by 2002:a2e:544e:0:b0:261:cc28:d4cd with SMTP id y14-20020a2e544e000000b00261cc28d4cdmr1179523ljd.105.1661441847957; Thu, 25 Aug 2022 08:37:27 -0700 (PDT) Received: from sovereign.. (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id r2-20020ac25c02000000b0048a9e899693sm562909lfp.16.2022.08.25.08.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:37:27 -0700 (PDT) From: Dmitry Kozlyuk To: dev@dpdk.org Cc: Dmitry Kozlyuk Subject: [PATCH v2 4/4] eal: remove unneeded includes from a public header Date: Thu, 25 Aug 2022 18:37:09 +0300 Message-Id: <20220825153709.33181-5-dmitry.kozliuk@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220825153709.33181-1-dmitry.kozliuk@gmail.com> References: <20220821205009.1317044-1-dmitry.kozliuk@gmail.com> <20220825153709.33181-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do not include , , and from , because they are not used by this file directly. Include the needed headers directly from the files that need them. Signed-off-by: Dmitry Kozlyuk --- Done as a separate commit to keep EAL change clean. app/test-bbdev/test_bbdev_vector.c | 1 + app/test-crypto-perf/cperf_test_vector_parsing.c | 1 + app/test-eventdev/parser.h | 1 + app/test-pmd/bpf_cmd.c | 2 ++ app/test-pmd/cmdline.c | 1 + app/test-pmd/cmdline_tm.c | 2 ++ app/test-pmd/config.c | 1 + app/test/test.h | 2 ++ drivers/bus/vdev/vdev_params.c | 1 + drivers/common/cnxk/cnxk_telemetry_nix.c | 1 + drivers/common/cnxk/cnxk_telemetry_npa.c | 1 + drivers/crypto/scheduler/scheduler_pmd.c | 2 ++ drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c | 2 ++ drivers/net/i40e/i40e_ethdev.c | 1 + drivers/net/iavf/iavf_ethdev.c | 1 + drivers/net/ice/ice_ethdev.c | 1 + drivers/net/softnic/parser.h | 1 + lib/dmadev/rte_dmadev.c | 1 + lib/eal/common/eal_common_debug.c | 2 ++ lib/eal/common/eal_common_string_fns.c | 4 +++- lib/eal/include/generic/rte_rwlock.h | 2 ++ lib/eal/include/rte_common.h | 3 --- lib/eal/linux/eal.c | 1 + lib/eal/linux/eal_vfio_mp_sync.c | 1 + lib/eal/unix/eal_unix_timer.c | 1 + lib/eal/windows/rte_thread.c | 2 ++ lib/ethdev/sff_telemetry.c | 1 + lib/eventdev/rte_event_eth_rx_adapter.c | 1 + lib/eventdev/rte_event_timer_adapter.c | 1 + lib/meter/rte_meter.c | 1 + lib/pci/rte_pci.c | 1 + lib/pipeline/rte_swx_ctl.c | 1 + lib/sched/rte_pie.c | 1 + lib/security/rte_security.c | 2 ++ lib/telemetry/telemetry_data.c | 3 +++ lib/telemetry/telemetry_legacy.c | 1 + 36 files changed, 48 insertions(+), 4 deletions(-) diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c index f020836f88..5018397c46 100644 --- a/app/test-bbdev/test_bbdev_vector.c +++ b/app/test-bbdev/test_bbdev_vector.c @@ -5,6 +5,7 @@ #ifdef RTE_EXEC_ENV_FREEBSD #define _WITH_GETLINE #endif +#include #include #include #include diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c b/app/test-crypto-perf/cperf_test_vector_parsing.c index 87f3a90055..2c9087b5f9 100644 --- a/app/test-crypto-perf/cperf_test_vector_parsing.c +++ b/app/test-crypto-perf/cperf_test_vector_parsing.c @@ -4,6 +4,7 @@ #ifdef RTE_EXEC_ENV_FREEBSD #define _WITH_GETLINE #endif +#include #include #include diff --git a/app/test-eventdev/parser.h b/app/test-eventdev/parser.h index 696b40a3e2..954371b5b8 100644 --- a/app/test-eventdev/parser.h +++ b/app/test-eventdev/parser.h @@ -5,6 +5,7 @@ #ifndef __INCLUDE_PARSER_H__ #define __INCLUDE_PARSER_H__ +#include #include #define PARSE_DELIMITER " \f\n\r\t\v" diff --git a/app/test-pmd/bpf_cmd.c b/app/test-pmd/bpf_cmd.c index 648e0e9294..46f6b7d6d2 100644 --- a/app/test-pmd/bpf_cmd.c +++ b/app/test-pmd/bpf_cmd.c @@ -2,7 +2,9 @@ * Copyright(c) 2018 Intel Corporation */ +#include #include + #include #include #include diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index b4fe9dfb17..07566c7a77 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -3,6 +3,7 @@ * Copyright(c) 2014 6WIND S.A. */ +#include #include #include #include diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c index fb56a234c5..1bc6c00998 100644 --- a/app/test-pmd/cmdline_tm.c +++ b/app/test-pmd/cmdline_tm.c @@ -2,6 +2,8 @@ * Copyright(c) 2017 Intel Corporation */ +#include + #include #include #include diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index a2939867c4..86054455d2 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -3,6 +3,7 @@ * Copyright 2013-2014 6WIND S.A. */ +#include #include #include #include diff --git a/app/test/test.h b/app/test/test.h index 7115edf469..85f57efbc6 100644 --- a/app/test/test.h +++ b/app/test/test.h @@ -5,7 +5,9 @@ #ifndef _TEST_H_ #define _TEST_H_ +#include #include +#include #include #include diff --git a/drivers/bus/vdev/vdev_params.c b/drivers/bus/vdev/vdev_params.c index 3969faf16d..3d6f63344a 100644 --- a/drivers/bus/vdev/vdev_params.c +++ b/drivers/bus/vdev/vdev_params.c @@ -2,6 +2,7 @@ * Copyright 2018 Gaëtan Rivet */ +#include #include #include diff --git a/drivers/common/cnxk/cnxk_telemetry_nix.c b/drivers/common/cnxk/cnxk_telemetry_nix.c index 4119e9ee4f..b7285cf137 100644 --- a/drivers/common/cnxk/cnxk_telemetry_nix.c +++ b/drivers/common/cnxk/cnxk_telemetry_nix.c @@ -2,6 +2,7 @@ * Copyright(C) 2021 Marvell. */ +#include #include "cnxk_telemetry.h" #include "roc_api.h" #include "roc_priv.h" diff --git a/drivers/common/cnxk/cnxk_telemetry_npa.c b/drivers/common/cnxk/cnxk_telemetry_npa.c index ae515df84f..b6ae108b10 100644 --- a/drivers/common/cnxk/cnxk_telemetry_npa.c +++ b/drivers/common/cnxk/cnxk_telemetry_npa.c @@ -2,6 +2,7 @@ * Copyright(C) 2021 Marvell. */ +#include #include "cnxk_telemetry.h" #include "roc_api.h" #include "roc_priv.h" diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c index dd198080bf..2750fe8bd3 100644 --- a/drivers/crypto/scheduler/scheduler_pmd.c +++ b/drivers/crypto/scheduler/scheduler_pmd.c @@ -1,6 +1,8 @@ /* SPDX-License-Identifier: BSD-3-Clause * Copyright(c) 2017 Intel Corporation */ +#include + #include #include #include diff --git a/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c b/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c index bfdbd1ee5d..c38af63bdc 100644 --- a/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c +++ b/drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c @@ -2,6 +2,8 @@ * Copyright(C) 2022 Marvell. */ +#include + #include #include diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 67d79de08d..36ca42aa87 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2,6 +2,7 @@ * Copyright(c) 2010-2017 Intel Corporation */ +#include #include #include #include diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 506fcff6e3..652f0d00a5 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -2,6 +2,7 @@ * Copyright(c) 2017 Intel Corporation */ +#include #include #include #include diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index b2300790ae..e8304a1f2b 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -5,6 +5,7 @@ #include #include +#include #include #include #include diff --git a/drivers/net/softnic/parser.h b/drivers/net/softnic/parser.h index 6f408b2485..c17a5d8ef0 100644 --- a/drivers/net/softnic/parser.h +++ b/drivers/net/softnic/parser.h @@ -5,6 +5,7 @@ #ifndef __INCLUDE_SOFTNIC_PARSER_H__ #define __INCLUDE_SOFTNIC_PARSER_H__ +#include #include #include diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c index 174d4c40ae..e64c923a00 100644 --- a/lib/dmadev/rte_dmadev.c +++ b/lib/dmadev/rte_dmadev.c @@ -3,6 +3,7 @@ * Copyright(c) 2021 Intel Corporation */ +#include #include #include diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c index 15418e957f..dcb554af1e 100644 --- a/lib/eal/common/eal_common_debug.c +++ b/lib/eal/common/eal_common_debug.c @@ -3,6 +3,8 @@ */ #include +#include + #include #include #include diff --git a/lib/eal/common/eal_common_string_fns.c b/lib/eal/common/eal_common_string_fns.c index 5fc4ee71dc..9ca2045b18 100644 --- a/lib/eal/common/eal_common_string_fns.c +++ b/lib/eal/common/eal_common_string_fns.c @@ -2,8 +2,10 @@ * Copyright(c) 2010-2014 Intel Corporation */ -#include +#include #include +#include +#include #include #include diff --git a/lib/eal/include/generic/rte_rwlock.h b/lib/eal/include/generic/rte_rwlock.h index da9bc3e9c0..6f600db2af 100644 --- a/lib/eal/include/generic/rte_rwlock.h +++ b/lib/eal/include/generic/rte_rwlock.h @@ -21,6 +21,8 @@ extern "C" { #endif +#include + #include #include #include diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h index 86c50c55e0..2e22c1b955 100644 --- a/lib/eal/include/rte_common.h +++ b/lib/eal/include/rte_common.h @@ -17,9 +17,6 @@ extern "C" { #endif #include -#include -#include -#include #include #include diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 37d29643a5..46bf52cef0 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -3,6 +3,7 @@ * Copyright(c) 2012-2014 6WIND S.A. */ +#include #include #include #include diff --git a/lib/eal/linux/eal_vfio_mp_sync.c b/lib/eal/linux/eal_vfio_mp_sync.c index 4e26781948..157f20e583 100644 --- a/lib/eal/linux/eal_vfio_mp_sync.c +++ b/lib/eal/linux/eal_vfio_mp_sync.c @@ -2,6 +2,7 @@ * Copyright(c) 2010-2018 Intel Corporation */ +#include #include #include diff --git a/lib/eal/unix/eal_unix_timer.c b/lib/eal/unix/eal_unix_timer.c index cc50159104..e71602b3a1 100644 --- a/lib/eal/unix/eal_unix_timer.c +++ b/lib/eal/unix/eal_unix_timer.c @@ -2,6 +2,7 @@ * Copyright 2020 Mellanox Technologies, Ltd */ +#include #include #include diff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c index 077152568f..63442ece9d 100644 --- a/lib/eal/windows/rte_thread.c +++ b/lib/eal/windows/rte_thread.c @@ -3,6 +3,8 @@ * Copyright (C) 2022 Microsoft Corporation */ +#include + #include #include #include diff --git a/lib/ethdev/sff_telemetry.c b/lib/ethdev/sff_telemetry.c index 887f07c47e..81dec4a39c 100644 --- a/lib/ethdev/sff_telemetry.c +++ b/lib/ethdev/sff_telemetry.c @@ -2,6 +2,7 @@ * Copyright(c) 2022 Intel Corporation */ +#include #include #include "rte_ethdev.h" diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index bf8741d2ea..2ce7dc652c 100644 --- a/lib/eventdev/rte_event_eth_rx_adapter.c +++ b/lib/eventdev/rte_event_eth_rx_adapter.c @@ -2,6 +2,7 @@ * Copyright(c) 2017 Intel Corporation. * All rights reserved. */ +#include #if defined(LINUX) #include #endif diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c index e0d978d641..27bf4c85b3 100644 --- a/lib/eventdev/rte_event_timer_adapter.c +++ b/lib/eventdev/rte_event_timer_adapter.c @@ -3,6 +3,7 @@ * All rights reserved. */ +#include #include #include #include diff --git a/lib/meter/rte_meter.c b/lib/meter/rte_meter.c index 4549b97d36..6545803d36 100644 --- a/lib/meter/rte_meter.c +++ b/lib/meter/rte_meter.c @@ -2,6 +2,7 @@ * Copyright(c) 2010-2014 Intel Corporation */ +#include #include #include diff --git a/lib/pci/rte_pci.c b/lib/pci/rte_pci.c index 355772ff56..1c5ef951d3 100644 --- a/lib/pci/rte_pci.c +++ b/lib/pci/rte_pci.c @@ -3,6 +3,7 @@ * Copyright 2013-2014 6WIND S.A. */ +#include #include #include #include diff --git a/lib/pipeline/rte_swx_ctl.c b/lib/pipeline/rte_swx_ctl.c index 710e89a46a..fecc215398 100644 --- a/lib/pipeline/rte_swx_ctl.c +++ b/lib/pipeline/rte_swx_ctl.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: BSD-3-Clause * Copyright(c) 2020 Intel Corporation */ +#include #include #include #include diff --git a/lib/sched/rte_pie.c b/lib/sched/rte_pie.c index c84f75a18c..947e2a059f 100644 --- a/lib/sched/rte_pie.c +++ b/lib/sched/rte_pie.c @@ -2,6 +2,7 @@ * Copyright(c) 2020 Intel Corporation */ +#include #include #include diff --git a/lib/security/rte_security.c b/lib/security/rte_security.c index 4f5e4b4d49..9bf49a3bd0 100644 --- a/lib/security/rte_security.c +++ b/lib/security/rte_security.c @@ -4,6 +4,8 @@ * Copyright (c) 2020 Samsung Electronics Co., Ltd All Rights Reserved */ +#include + #include #include #include diff --git a/lib/telemetry/telemetry_data.c b/lib/telemetry/telemetry_data.c index e14ae3c4d4..2581c27413 100644 --- a/lib/telemetry/telemetry_data.c +++ b/lib/telemetry/telemetry_data.c @@ -2,6 +2,9 @@ * Copyright(c) 2020 Intel Corporation */ +#include +#include + #undef RTE_USE_LIBBSD #include diff --git a/lib/telemetry/telemetry_legacy.c b/lib/telemetry/telemetry_legacy.c index 8aba44d689..17d77fff59 100644 --- a/lib/telemetry/telemetry_legacy.c +++ b/lib/telemetry/telemetry_legacy.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: BSD-3-Clause * Copyright(c) 2020 Intel Corporation */ +#include #ifndef RTE_EXEC_ENV_WINDOWS #include -- 2.33.1