From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 82C02A0550;
Fri, 26 Aug 2022 14:43:08 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C290540A80;
Fri, 26 Aug 2022 14:42:50 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id E0AC840143
for <dev@dpdk.org>; Fri, 26 Aug 2022 14:42:48 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1661517768;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=JHrvXXARgJBOV+K4etbQE6SOwGhN/4WXEqNSDtdqleQ=;
b=WT4vYC7haAsTiFZYeUwsi5Z3BWj4TgiKeEx9aY44hs9gKCYjaufBuLpYhINKpGhAWhzxv7
nPtRnSKwXwZB01sySnUcYFyxWKFmh2zKgrlNz/KQcfJig5b6IuaWFf1WragcKQ61b5Kwod
d/SzQIgbeMuZITOxSylHEyNJ8NZfAws=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
[66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
us-mta-365-806MI9oVNQyuF_pODE-ukw-1; Fri, 26 Aug 2022 08:42:42 -0400
X-MC-Unique: 806MI9oVNQyuF_pODE-ukw-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com
[10.11.54.7])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CDE903817A6D;
Fri, 26 Aug 2022 12:42:41 +0000 (UTC)
Received: from fchome.redhat.com (unknown [10.40.193.251])
by smtp.corp.redhat.com (Postfix) with ESMTP id BFF1B141510F;
Fri, 26 Aug 2022 12:42:40 +0000 (UTC)
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, bruce.richardson@intel.com,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
Subject: [PATCH v4 07/27] dev: hide debug messages in device iterator
Date: Fri, 26 Aug 2022 14:41:48 +0200
Message-Id: <20220826124208.671400-8-david.marchand@redhat.com>
In-Reply-To: <20220826124208.671400-1-david.marchand@redhat.com>
References: <20220628144643.1213026-1-david.marchand@redhat.com>
<20220826124208.671400-1-david.marchand@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"; x-default=true
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
For any bus that does not support device iteration, rte_dev_iterator_init
both returned an error code and logged an error message.
An application (like testpmd) that only wants to list devices, would have
no choice but to inspect a bus object to avoid spewing error logs.
Make those log messages debug level, and remove the check in testpmd.
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/test-pmd/config.c | 4 ----
lib/eal/common/eal_common_dev.c | 7 +++----
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 3a53b616d8..bc73819183 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -641,10 +641,6 @@ device_infos_display(const char *identifier)
if (identifier && da.bus != next)
continue;
- /* Skip buses that don't have iterate method */
- if (!next->dev_iterate)
- continue;
-
snprintf(devstr, sizeof(devstr), "bus=%s", next->name);
RTE_DEV_FOREACH(dev, devstr, &dev_iter) {
diff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c
index 9d913e5478..b6f0392f30 100644
--- a/lib/eal/common/eal_common_dev.c
+++ b/lib/eal/common/eal_common_dev.c
@@ -592,18 +592,17 @@ rte_dev_iterator_init(struct rte_dev_iterator *it,
* one layer specified.
*/
if (bus == NULL && cls == NULL) {
- RTE_LOG(ERR, EAL,
- "Either bus or class must be specified.\n");
+ RTE_LOG(DEBUG, EAL, "Either bus or class must be specified.\n");
rte_errno = EINVAL;
goto get_out;
}
if (bus != NULL && bus->dev_iterate == NULL) {
- RTE_LOG(ERR, EAL, "Bus %s not supported\n", bus->name);
+ RTE_LOG(DEBUG, EAL, "Bus %s not supported\n", bus->name);
rte_errno = ENOTSUP;
goto get_out;
}
if (cls != NULL && cls->dev_iterate == NULL) {
- RTE_LOG(ERR, EAL, "Class %s not supported\n", cls->name);
+ RTE_LOG(DEBUG, EAL, "Class %s not supported\n", cls->name);
rte_errno = ENOTSUP;
goto get_out;
}
--
2.37.2