DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: "David Marchand" <david.marchand@redhat.com>,
	"lic121" <chengtcli@qq.com>, "dev" <dev@dpdk.org>
Subject: Re: [PATCH] eal: zero out new added memory
Date: Mon, 29 Aug 2022 15:49:25 +0300	[thread overview]
Message-ID: <20220829154925.6575540a@sovereign> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D872CC@smartserver.smartshare.dk>

2022-08-29 14:37 (UTC+0200), Morten Brørup:
> > From: David Marchand [mailto:david.marchand@redhat.com]
> > Sent: Monday, 29 August 2022 13.58
> >
> > > > > > On Sat, Aug 27, 2022 at 12:57:50PM +0300, Dmitry Kozlyuk wrote:  
> > > > > > > The kernel ensures that the newly mapped memory is zeroed,
> > > > > > > and DPDK ensures that files in hugetlbfs are not re-mapped.  
> 
> David, are you suggesting that this invariant - guaranteeing that DPDK memory is zeroed - was violated by SELinux in the SELinux/container issue you were tracking?
> 
> If so, the method to ensure the invariant is faulty for SELinux. Assuming DPDK supports SELinux, this bug should be fixed.

+1, I'd like to know more about that case.

EAL checks the unlink() result, so if it fails, the allocation should fail
and the invariant should not be broken.
Code from 20.11.5:

	if (rte_eal_process_type() == RTE_PROC_PRIMARY &&
			unlink(path) == -1 &&
			errno != ENOENT) {
		RTE_LOG(DEBUG, EAL, "%s(): could not remove '%s': %s\n",
			__func__, path, strerror(errno));
		return -1;
	}

Can SELinux restriction result in errno == ENOENT?
I'd expect EPERM/EACCESS.

  parent reply	other threads:[~2022-08-29 12:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-27  9:25 chengtcli
2022-08-27  9:57 ` Dmitry Kozlyuk
2022-08-27 13:31   ` lic121
2022-08-27 14:56     ` Dmitry Kozlyuk
2022-08-29  1:18       ` lic121
2022-08-29 11:37         ` lic121
2022-08-29 11:57           ` David Marchand
2022-08-29 12:37             ` Morten Brørup
2022-08-29 12:43               ` David Marchand
2022-08-29 12:49               ` Dmitry Kozlyuk [this message]
2022-08-30  1:11                 ` lic121
2022-08-30  9:49                   ` lic121
2022-08-30 10:59                     ` Dmitry Kozlyuk
2022-08-30 12:47                       ` lic121
2022-08-30 12:53                       ` lic121
2022-09-03 13:53                         ` lic121

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220829154925.6575540a@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=chengtcli@qq.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).