From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67BEDA0093; Wed, 31 Aug 2022 18:25:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E25A240F17; Wed, 31 Aug 2022 18:25:54 +0200 (CEST) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 7012740395 for ; Wed, 31 Aug 2022 18:25:53 +0200 (CEST) Received: by mail-pj1-f48.google.com with SMTP id o4so14628811pjp.4 for ; Wed, 31 Aug 2022 09:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc; bh=22B2ceMjaJqrsv7fMGmB7BwrXwf5LX4ThdLBL33iHfc=; b=25+ZhbCCRoQNRD4TlrtCulS6U8lmAkHtjEyClq8AR+jHmFnFY9yQ2ANr5lOQY4M98F zlD+xBTdHKNPZwbbCEcu1gs5h0neXC1ZBGfHxL1/bdXYAb20K14fjsePtEvEXwgcuhB3 F+ChRoqmWW29l2/dWiFlnAUcI6Tske82aqraU/v5UqpjurxXxCuLwtlzTGtEBv73ricb nAEnC04XLtOP4OCW5G7Fnt0DW96O0uziXFKKF6Nx2AiNugmC1WANtWK03W7hsTbVe8Iq 7Or6CFW8Hi1JZXb1/NBT+kCrVePdHleDwy2LIUZ8YBmA7jXhxCk4gwuD62wNTf6hq4iW h5/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=22B2ceMjaJqrsv7fMGmB7BwrXwf5LX4ThdLBL33iHfc=; b=a/ly+GOehBGDy8QV8w9s74o9FpoCMPWq8J1ODLSjaOTbTmZheRnmscxGwuBWe2Hifm v0rU3BBc9+CTCgeTWiqPyIvUf5lb4ByzIC8VriJUOFH/pkrE67Vm8HIWXdn+pNuU11mP 8q51vD4VT7fteMHpbx7tUcNRY+lyocs1XijMzSbfvYWW/IVCSfV57vCv0cAEfLewMMPH OuNaHYN1GlWbKYhW9+t+GHULQf35B1K0GJ8gjENGXGB7djlU0MTFPKJ3xJeZblbAzJy2 l775zp/417/7TvvbmI2YJhf1FWPZyi/Pu4hRZSs/RVobkAZP4gSVxn63iGgHan3u/P9A vQLw== X-Gm-Message-State: ACgBeo1o51DnJ8MOrV5Y/1LGMPkKQzolTDaZ7vsScHacqTBW46Rn2Cb0 s2wLgQviLo9guqVQqISWoUVwew== X-Google-Smtp-Source: AA6agR6vLlaBITlyRfWR/IyIsmLTHaaTMD1T/fu0WwtEmQyn0uYxdxRp5jzwLGonyVqTfovursvstg== X-Received: by 2002:a17:902:cec7:b0:172:5b09:161c with SMTP id d7-20020a170902cec700b001725b09161cmr25696302plg.60.1661963152512; Wed, 31 Aug 2022 09:25:52 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id n4-20020a170902f60400b001637529493esm11908283plg.66.2022.08.31.09.25.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Aug 2022 09:25:52 -0700 (PDT) Date: Wed, 31 Aug 2022 09:25:50 -0700 From: Stephen Hemminger To: Joyce Kong Cc: jgrajcia@cisco.com, huzaifa.rahman@emumba.com, dev@dpdk.org, nd@arm.com, mb@smartsharesystems.com, ruifeng.wang@arm.com Subject: Re: [PATCH v3 1/2] net/memif: add a Rx fast path Message-ID: <20220831092550.788683ac@hermes.local> In-Reply-To: <20220822034731.528424-2-joyce.kong@arm.com> References: <20220701102815.1444223-2-joyce.kong@arm.com> <20220822034731.528424-1-joyce.kong@arm.com> <20220822034731.528424-2-joyce.kong@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 22 Aug 2022 03:47:30 +0000 Joyce Kong wrote: > + if (likely(mbuf_size >= pmd->cfg.pkt_buffer_size)) { > + struct rte_mbuf *mbufs[nb_pkts]; > + ret = rte_pktmbuf_alloc_bulk(mq->mempool, mbufs, nb_pkts); > + if (unlikely(ret < 0)) > + goto no_free_bufs; > + The indentation looks off here, is this because of diff? Also, my preference is to use blank line after declaration. One more thing, the use of variable length array on stack will cause the function to get additional overhead if stack-protector strong is enabled.