DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] regex/mlx5: add check for nb max matches
@ 2022-09-01  8:28 Gerry Gribbon
  2022-10-09 14:35 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Gerry Gribbon @ 2022-09-01  8:28 UTC (permalink / raw)
  To: dev; +Cc: jamhunter, ggribbon, Ori Kam

Added check so user gets error if they try to configure the
nb_max_matches value when using rte_regexdev_configure().

Signed-off-by: Gerry Gribbon <ggribbon@nvidia.com>
Acked-by: Ori Kam <orika@nvidia.com>
---
 drivers/regex/mlx5/mlx5_rxp.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/regex/mlx5/mlx5_rxp.c b/drivers/regex/mlx5/mlx5_rxp.c
index ed3af15e40..47d32b7dd7 100644
--- a/drivers/regex/mlx5/mlx5_rxp.c
+++ b/drivers/regex/mlx5/mlx5_rxp.c
@@ -144,6 +144,11 @@ mlx5_regex_configure(struct rte_regexdev *dev,
 
 	if (priv->prog_mode == MLX5_RXP_MODE_NOT_DEFINED)
 		return -1;
+	if (cfg->nb_max_matches != MLX5_REGEX_MAX_MATCHES) {
+		DRV_LOG(ERR, "nb_max_matches is not configurable.");
+		rte_errno = EINVAL;
+		return -rte_errno;
+	}
 	priv->nb_queues = cfg->nb_queue_pairs;
 	dev->data->dev_conf.nb_queue_pairs = priv->nb_queues;
 	priv->qps = rte_zmalloc(NULL, sizeof(struct mlx5_regex_qp) *
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] regex/mlx5: add check for nb max matches
  2022-09-01  8:28 [PATCH] regex/mlx5: add check for nb max matches Gerry Gribbon
@ 2022-10-09 14:35 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2022-10-09 14:35 UTC (permalink / raw)
  To: Gerry Gribbon; +Cc: dev, jamhunter, Ori Kam

01/09/2022 10:28, Gerry Gribbon:
> Added check so user gets error if they try to configure the
> nb_max_matches value when using rte_regexdev_configure().
> 
> Signed-off-by: Gerry Gribbon <ggribbon@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>

Applied, thanks.

Note the more explicit title on merge:
regex/mlx5: forbid changing maximum match number



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-09 14:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01  8:28 [PATCH] regex/mlx5: add check for nb max matches Gerry Gribbon
2022-10-09 14:35 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).