From: Bhagyada Modali <bhagyada.modali@amd.com>
To: <chandu@amd.com>, <ferruh.yigit@amd.com>
Cc: <dev@dpdk.org>, Bhagyada Modali <bhagyada.modali@amd.com>
Subject: [PATCH v2 4/4] net/axgbe: fix checksum and RSS in scattered Rx
Date: Thu, 1 Sep 2022 08:49:48 -0400 [thread overview]
Message-ID: <20220901124948.97063-4-bhagyada.modali@amd.com> (raw)
In-Reply-To: <20220901124948.97063-1-bhagyada.modali@amd.com>
Updated the RSS hash and CSUM checks with first_seg instead of mbufs.
Fixes: 965b3127d425 ("net/axgbe: support scattered Rx")
Signed-off-by: Bhagyada Modali <bhagyada.modali@amd.com>
---
drivers/net/axgbe/axgbe_rxtx.c | 41 +++++++++++++++++++++-------------
1 file changed, 25 insertions(+), 16 deletions(-)
diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c
index 7c07fd90ef..2bad638f79 100644
--- a/drivers/net/axgbe/axgbe_rxtx.c
+++ b/drivers/net/axgbe/axgbe_rxtx.c
@@ -427,24 +427,27 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue,
/* Get the RSS hash */
if (AXGMAC_GET_BITS_LE(desc->write.desc3, RX_NORMAL_DESC3, RSV))
- mbuf->hash.rss = rte_le_to_cpu_32(desc->write.desc1);
+ first_seg->hash.rss =
+ rte_le_to_cpu_32(desc->write.desc1);
etlt = AXGMAC_GET_BITS_LE(desc->write.desc3,
RX_NORMAL_DESC3, ETLT);
offloads = rxq->pdata->eth_dev->data->dev_conf.rxmode.offloads;
if (!err || !etlt) {
if (etlt == RX_CVLAN_TAG_PRESENT) {
- mbuf->ol_flags |= RTE_MBUF_F_RX_VLAN;
- mbuf->vlan_tci =
+ first_seg->ol_flags |= RTE_MBUF_F_RX_VLAN;
+ first_seg->vlan_tci =
AXGMAC_GET_BITS_LE(desc->write.desc0,
RX_NORMAL_DESC0, OVT);
if (offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP)
- mbuf->ol_flags |= RTE_MBUF_F_RX_VLAN_STRIPPED;
+ first_seg->ol_flags |=
+ RTE_MBUF_F_RX_VLAN_STRIPPED;
else
- mbuf->ol_flags &= ~RTE_MBUF_F_RX_VLAN_STRIPPED;
+ first_seg->ol_flags &=
+ ~RTE_MBUF_F_RX_VLAN_STRIPPED;
} else {
- mbuf->ol_flags &=
+ first_seg->ol_flags &=
~(RTE_MBUF_F_RX_VLAN | RTE_MBUF_F_RX_VLAN_STRIPPED);
- mbuf->vlan_tci = 0;
+ first_seg->vlan_tci = 0;
}
}
@@ -468,18 +471,24 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue,
first_seg->port = rxq->port_id;
if (rxq->pdata->rx_csum_enable) {
- mbuf->ol_flags = 0;
- mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD;
- mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;
+ first_seg->ol_flags = 0;
+ first_seg->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD;
+ first_seg->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;
if (unlikely(error_status == AXGBE_L3_CSUM_ERR)) {
- mbuf->ol_flags &= ~RTE_MBUF_F_RX_IP_CKSUM_GOOD;
- mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD;
- mbuf->ol_flags &= ~RTE_MBUF_F_RX_L4_CKSUM_GOOD;
- mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN;
+ first_seg->ol_flags &=
+ ~RTE_MBUF_F_RX_IP_CKSUM_GOOD;
+ first_seg->ol_flags |=
+ RTE_MBUF_F_RX_IP_CKSUM_BAD;
+ first_seg->ol_flags &=
+ ~RTE_MBUF_F_RX_L4_CKSUM_GOOD;
+ first_seg->ol_flags |=
+ RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN;
} else if (unlikely(error_status
== AXGBE_L4_CSUM_ERR)) {
- mbuf->ol_flags &= ~RTE_MBUF_F_RX_L4_CKSUM_GOOD;
- mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD;
+ first_seg->ol_flags &=
+ ~RTE_MBUF_F_RX_L4_CKSUM_GOOD;
+ first_seg->ol_flags |=
+ RTE_MBUF_F_RX_L4_CKSUM_BAD;
}
}
--
2.25.1
next prev parent reply other threads:[~2022-09-01 12:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 5:33 [PATCH 1/4] net/axgbe: fix scattered Rx function Bhagyada Modali
2022-09-01 5:33 ` [PATCH 2/4] " Bhagyada Modali
2022-09-01 5:33 ` [PATCH 3/4] " Bhagyada Modali
2022-09-01 5:33 ` [PATCH 4/4] " Bhagyada Modali
2022-09-01 12:49 ` [PATCH v2 1/4] net/axgbe: fix scattered Rx Bhagyada Modali
2022-09-01 12:49 ` [PATCH v2 2/4] net/axgbe: fix mbuf lengths in " Bhagyada Modali
2022-09-01 12:49 ` [PATCH v2 3/4] net/axgbe: fix length of each segment " Bhagyada Modali
2022-09-01 12:49 ` Bhagyada Modali [this message]
2022-09-01 15:03 ` [PATCH v2 1/4] net/axgbe: fix " Ferruh Yigit
2022-09-02 8:47 ` [PATCH v3 " Bhagyada Modali
2022-09-02 8:47 ` [PATCH v3 2/4] net/axgbe: fix mbuf lengths in " Bhagyada Modali
2022-09-02 8:47 ` [PATCH v3 3/4] net/axgbe: fix length of each segment " Bhagyada Modali
2022-09-02 8:47 ` [PATCH v3 4/4] net/axgbe: fix checksum and RSS " Bhagyada Modali
2022-09-05 5:00 ` [PATCH v3 1/4] net/axgbe: fix " Namburu, Chandu-babu
2022-09-05 16:48 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901124948.97063-4-bhagyada.modali@amd.com \
--to=bhagyada.modali@amd.com \
--cc=chandu@amd.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).