From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA021A0542; Fri, 2 Sep 2022 05:01:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F15F342829; Fri, 2 Sep 2022 05:00:54 +0200 (CEST) Received: from smtpbg.qq.com (smtpbgeu1.qq.com [52.59.177.22]) by mails.dpdk.org (Postfix) with ESMTP id CCC4A40684; Fri, 2 Sep 2022 05:00:52 +0200 (CEST) X-QQ-mid: bizesmtp70t1662087649tlykbg2o Received: from wxdbg.localdomain.com ( [183.129.236.74]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 02 Sep 2022 11:00:49 +0800 (CST) X-QQ-SSF: 01400000000000G0T000000A0000000 X-QQ-FEAT: 6O9OQ9ciFt5so7feLr4vx1H6iSUl+q6nfWGPE6pMcpwydwPCcq52NFDU7coW1 lAqM62l0pYbvBgAbkeAakoTcctfWxBp9oQJKCo56+W4T90qL6+TFRcwb9LDDmeQeQsGZ5gf M87ViSQtoYN3KqDzytzlvstEwfWb+7ZmxqXQv6Yh2QKB2BtoXNdR3JBwT/K0nVllu8a3cTc 7Z+WbG7h+00lJf7rYyMESbF5GJUh7LQuiZ2YoQxs4o4lceXUagq3Z/SS504mu0yf4Y9xXZX KsoRHXXomtb0M/VWTP+wXOA1FZ/qdBUUK97SsHGrwnqBc3sLFcDZY1dNfFOHnIFG6vyuDZh pzgrHKtMRMNtC4RC69SoTgPCGxCoYX5ueRYZb8Ny1kobU6j0U4MggI0brKq8mqQNOY+3ayN X-QQ-GoodBg: 2 From: Jiawen Wu To: dev@dpdk.org Cc: Jiawen Wu , stable@dpdk.org Subject: [PATCH 3/9] net/txgbe: remove semaphore between SW/FW Date: Fri, 2 Sep 2022 11:00:05 +0800 Message-Id: <20220902030011.377523-4-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220902030011.377523-1-jiawenwu@trustnetic.com> References: <20220902030011.377523-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybglogicsvr:qybglogicsvr5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Since firmware does not use the semaphore between software and firmware. Remove useless unilateral semaphore setting. Fixes: 35c90ecccfd4 ("net/txgbe: add EEPROM functions") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_eeprom.c | 32 --------------------------- 1 file changed, 32 deletions(-) diff --git a/drivers/net/txgbe/base/txgbe_eeprom.c b/drivers/net/txgbe/base/txgbe_eeprom.c index 4ed6bd6728..aeeae06dfc 100644 --- a/drivers/net/txgbe/base/txgbe_eeprom.c +++ b/drivers/net/txgbe/base/txgbe_eeprom.c @@ -111,37 +111,6 @@ s32 txgbe_get_eeprom_semaphore(struct txgbe_hw *hw) status = 0; } - /* Now get the semaphore between SW/FW through the SWESMBI bit */ - if (status == 0) { - for (i = 0; i < timeout; i++) { - /* Set the SW EEPROM semaphore bit to request access */ - wr32m(hw, TXGBE_MNGSWSYNC, - TXGBE_MNGSWSYNC_REQ, TXGBE_MNGSWSYNC_REQ); - - /* - * If we set the bit successfully then we got the - * semaphore. - */ - swsm = rd32(hw, TXGBE_MNGSWSYNC); - if (swsm & TXGBE_MNGSWSYNC_REQ) - break; - - usec_delay(50); - } - - /* - * Release semaphores and return error if SW EEPROM semaphore - * was not granted because we don't have access to the EEPROM - */ - if (i >= timeout) { - DEBUGOUT("SWESMBI Software EEPROM semaphore not granted."); - txgbe_release_eeprom_semaphore(hw); - status = TXGBE_ERR_EEPROM; - } - } else { - DEBUGOUT("Software semaphore SMBI between device drivers not granted."); - } - return status; } @@ -153,7 +122,6 @@ s32 txgbe_get_eeprom_semaphore(struct txgbe_hw *hw) **/ void txgbe_release_eeprom_semaphore(struct txgbe_hw *hw) { - wr32m(hw, TXGBE_MNGSWSYNC, TXGBE_MNGSWSYNC_REQ, 0); wr32m(hw, TXGBE_SWSEM, TXGBE_SWSEM_PF, 0); txgbe_flush(hw); } -- 2.27.0