From: Amit Prakash Shukla <amitprakashs@marvell.com>
To: Ruifeng Wang <ruifeng.wang@arm.com>
Cc: <dev@dpdk.org>, <jerinj@marvell.com>, <stable@dpdk.org>,
<gakhil@marvell.com>, <stephen@networkplumber.org>,
Amit Prakash Shukla <amitprakashs@marvell.com>
Subject: [PATCH v2] examples: compilation fix for GCC-12
Date: Fri, 2 Sep 2022 13:13:37 +0530 [thread overview]
Message-ID: <20220902074337.3129786-1-amitprakashs@marvell.com> (raw)
In-Reply-To: <20220901082343.3074804-1-amitprakashs@marvell.com>
GCC-12 warns when a pointer of type union points to an array of same
defined size, as union internally gets paded with pad bytes.
../examples/common/neon/port_group.h:42:21: error: array subscript
'union <anonymous>[0]' is partly outside array bounds of
'uint16_t[5]' {aka 'short unsigned int[5]'}
[-Werror=array-bounds]
42 | pnum->u64 = gptbl[v].pnum;
| ^~
../examples/common/neon/port_group.h:21:23: note: object 'pn' of
size [0, 10]
21 | port_groupx4(uint16_t pn[FWDSTEP + 1], uint16_t *lp, uint16x8_t dp1
| ~~~~~~~~~^~~~~~~~~~~~~~~
../examples/common/neon/port_group.h:43:21: error: array subscript
'union <anonymous>[0]' is partly outside array bounds of
'uint16_t[5]' {aka 'short unsigned int[5]'} [-Werror=array-bounds]
43 | pnum->u16[FWDSTEP] = 1;
| ^~
Fixes: bdfc3816fbfc ("examples: common packet group functionality")
Cc: stable@dpdk.org
Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
---
v2:
- Changed to __rte_packed instead of direct attribute
examples/common/neon/port_group.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/common/neon/port_group.h b/examples/common/neon/port_group.h
index 82c6ed6d73..04e5699f70 100644
--- a/examples/common/neon/port_group.h
+++ b/examples/common/neon/port_group.h
@@ -24,7 +24,7 @@ port_groupx4(uint16_t pn[FWDSTEP + 1], uint16_t *lp, uint16x8_t dp1,
union {
uint16_t u16[FWDSTEP + 1];
uint64_t u64;
- } *pnum = (void *)pn;
+ } __rte_packed *pnum = (void *)pn;
uint16x8_t mask = {1, 2, 4, 8, 0, 0, 0, 0};
int32_t v;
--
2.25.1
next prev parent reply other threads:[~2022-09-02 7:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 8:23 [PATCH] " Amit Prakash Shukla
2022-09-01 15:24 ` Stephen Hemminger
2022-09-02 7:19 ` [EXT] " Amit Prakash Shukla
2022-09-02 7:43 ` Amit Prakash Shukla [this message]
2022-10-06 6:31 ` [PATCH v2] " Amit Prakash Shukla
2022-10-06 9:21 ` Thomas Monjalon
2022-10-06 9:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902074337.3129786-1-amitprakashs@marvell.com \
--to=amitprakashs@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).