From: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
To: dev@dpdk.org
Cc: anatoly.burakov@intel.com, reshma.pattan@intel.com,
bruce.richardson@intel.com,
Herakliusz Lipiec <herakliusz.lipiec@intel.com>
Subject: [PATCH v2] net/ring: add monitor callback
Date: Fri, 2 Sep 2022 18:25:21 +0100 [thread overview]
Message-ID: <20220902172521.3293866-1-herakliusz.lipiec@intel.com> (raw)
In-Reply-To: <20220803142845.2221915-1-herakliusz.lipiec@intel.com>
Currently ring pmd does not support ``rte_power_monitor`` api.
This patch adds support by adding monitor callback that is called
whenever we enter sleep state and need to check if it is time to wake
up.
Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2:
- changed umonitor references to monitor as this is how it appears in
dpdk api
- fixed coding style issues
---
drivers/net/ring/rte_eth_ring.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index cfb81da5fe..1050c22777 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -284,6 +284,29 @@ eth_dev_close(struct rte_eth_dev *dev)
return ret;
}
+static int ring_monitor_callback(const uint64_t value,
+ const uint64_t arg[RTE_POWER_MONITOR_OPAQUE_SZ])
+{
+ /* Check if the head pointer has changed */
+ return value != arg[0];
+}
+
+static int
+eth_get_monitor_addr(void *rx_queue, struct rte_power_monitor_cond *pmc)
+{
+ struct rte_ring *rng = ((struct ring_queue *)rx_queue)->rng;
+
+ /*
+ * Monitor ring head since if head moves
+ * there are packets to transmit
+ */
+ pmc->addr = &rng->prod.head;
+ pmc->size = sizeof(rng->prod.head);
+ pmc->opaque[0] = rng->prod.head;
+ pmc->fn = ring_monitor_callback;
+ return 0;
+}
+
static const struct eth_dev_ops ops = {
.dev_close = eth_dev_close,
.dev_start = eth_dev_start,
@@ -303,6 +326,7 @@ static const struct eth_dev_ops ops = {
.promiscuous_disable = eth_promiscuous_disable,
.allmulticast_enable = eth_allmulticast_enable,
.allmulticast_disable = eth_allmulticast_disable,
+ .get_monitor_addr = eth_get_monitor_addr,
};
static int
--
2.36.1
next prev parent reply other threads:[~2022-09-02 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 14:28 [PATCH] net/ring: add umonitor callback Herakliusz Lipiec
2022-09-01 14:43 ` Bruce Richardson
2022-09-02 17:25 ` Herakliusz Lipiec [this message]
2022-10-04 15:12 ` [PATCH v2] net/ring: add monitor callback Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902172521.3293866-1-herakliusz.lipiec@intel.com \
--to=herakliusz.lipiec@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).