From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9905CA054A; Tue, 6 Sep 2022 16:57:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BB0540143; Tue, 6 Sep 2022 16:57:41 +0200 (CEST) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id 320B5400D6 for ; Tue, 6 Sep 2022 16:57:40 +0200 (CEST) Received: by mail-pf1-f182.google.com with SMTP id 14so2871088pfu.9 for ; Tue, 06 Sep 2022 07:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=hQqyJ+l5qLt4gG4fxdu9DmeLPaASfN1EtIOaQs9V4jk=; b=7ghq0ZHHMez5zGfgte3+TXN8geQFI+ix6KugeQLgF9vjD07Mb8PLCvjwYD2vNeBTpc lYCvNOQm7k3D84ldQ2g8YOrr80/3AzBHe1cXIBgHsL5RzgdBEVqL8GbKp2vYWRHCLta0 /0DCcSMGAZodfZmmdOzwQ3c6O5Tg0dSScUhxxDwAd39+SS1+2+2xIY/pRKFL6dKnEs2R ym5mJ7MGP0TrTm98Jl6mxj7mh/9SW/bUyvnwYC96YHSbrw0Q0FUFYXvFxT/WVlUL6ttY LTt/3RE0d3LhetFYuEaIs3YK8SFNdUKJ26aeeAnYgTjYOZDMuCwiQfCrLM0rFmwACP7T S+YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=hQqyJ+l5qLt4gG4fxdu9DmeLPaASfN1EtIOaQs9V4jk=; b=OseHEJMlsU/sJOmYoBStrDo6ZDPMm9q03JTwgVz1uRcJjbPBlpUd7ZzYmVaF6SApcv B3anCMHGFOplEOaAYawpbxpy29URKhLEs2Pl1hC+qyykrGxpUU3PyLrgFG1Dl2ICmu0u inGoIzauOSoyLdFTkHBtBtx72T4IJPmRnLQyFuXsIZla8y8FI/kz7SGHfdrRXLpRk6Ty HoWlcHlT4HVAmzCzYemfXwInZjYVx5eqbaYLyB6sPi8YU3PqW2XQZqsVJ6pGR25xb+TI bcAXqkcKxX8trl4Fq3H2X/osWM8E/LlzJFPGX1EipmtKr6TxoSjyqTacISSoSW3qwcRS H5zQ== X-Gm-Message-State: ACgBeo23m1vKXBT/3A+NSnvF+x6nfnTA0OhJiIhwAfF7KU1a3VhNW8IC XitOXPSZP3jpzPZgJ+pGG8UqgA== X-Google-Smtp-Source: AA6agR5JIJyfBAhcZk50535jzIOam5G5dTD9hLbrqqOmOhfvWBvkTAXPJPIn2qJzvDJ1OrDm+58LxA== X-Received: by 2002:a63:2cc6:0:b0:41c:5f9c:e15c with SMTP id s189-20020a632cc6000000b0041c5f9ce15cmr45691393pgs.241.1662476259336; Tue, 06 Sep 2022 07:57:39 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id f7-20020a170902ce8700b0016bedcced2fsm10048877plg.35.2022.09.06.07.57.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 07:57:38 -0700 (PDT) Date: Tue, 6 Sep 2022 07:57:37 -0700 From: Stephen Hemminger To: Yiding Zhou Cc: dev@dpdk.org, qi.z.zhang@intel.com, anatoly.burakov@intel.com, xingguang.he@intel.com, stable@dpdk.org Subject: Re: [PATCH v2] net/pcap: fix timeout of stopping device Message-ID: <20220906075737.2fb429a5@hermes.local> In-Reply-To: <20220906080511.46088-1-yidingx.zhou@intel.com> References: <20220825072041.10768-1-yidingx.zhou@intel.com> <20220906080511.46088-1-yidingx.zhou@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 6 Sep 2022 16:05:11 +0800 Yiding Zhou wrote: > The pcap file will be synchronized to the disk when stopping the device. > It takes a long time if the file is large that would cause the > 'detach sync request' timeout when the device is closed under multi-process > scenario. > > This commit fixes the issue by using alarm handler to release dumper. > > Fixes: 0ecfb6c04d54 ("net/pcap: move handler to process private") > Cc: stable@dpdk.org > > Signed-off-by: Yiding Zhou I think you need to redesign the handshake if this the case. Forcing 30 second delay at the end of all uses of pcap is not acceptable.