From: Henning Schild <henning.schild@siemens.com>
To: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Cc: <dev@dpdk.org>, Henning Schild <henning.schild@siemens.com>
Subject: [PATCH] lib: do not call memcpy with sz zero and null pointer
Date: Wed, 7 Sep 2022 17:05:03 +0200 [thread overview]
Message-ID: <20220907150503.6212-1-henning.schild@siemens.com> (raw)
There is no point in such a call and UBSan complains about a call to
memcpy with a null pointer as second arg.
When building with -Db_sanitize=undefined, Clang gives the following
warning
../lib/bpf/bpf_load.c:37:20: runtime error: null pointer passed as
argument 2, which is declared to never be null
A check of the sz before calling memcpy fixes that.
Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
lib/bpf/bpf_load.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/bpf/bpf_load.c b/lib/bpf/bpf_load.c
index 0c4ac7be6c55..48d3d80ac3e3 100644
--- a/lib/bpf/bpf_load.c
+++ b/lib/bpf/bpf_load.c
@@ -34,7 +34,8 @@ bpf_load(const struct rte_bpf_prm *prm)
memcpy(&bpf->prm, prm, sizeof(bpf->prm));
- memcpy(buf + bsz, prm->xsym, xsz);
+ if (xsz)
+ memcpy(buf + bsz, prm->xsym, xsz);
memcpy(buf + bsz + xsz, prm->ins, insz);
bpf->prm.xsym = (void *)(buf + bsz);
--
2.35.1
next reply other threads:[~2022-09-09 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 15:05 Henning Schild [this message]
2022-09-21 13:06 ` Thomas Monjalon
2022-09-21 13:57 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907150503.6212-1-henning.schild@siemens.com \
--to=henning.schild@siemens.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).