From: Zhirun Yan <zhirun.yan@intel.com>
To: dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com
Cc: cunming.liang@intel.com, haiyue.wang@intel.com,
Zhirun Yan <zhirun.yan@intel.com>
Subject: [RFC, v1 5/6] graph: add stats for corss-core dispatching
Date: Thu, 8 Sep 2022 10:09:58 +0800 [thread overview]
Message-ID: <20220908020959.1675953-6-zhirun.yan@intel.com> (raw)
In-Reply-To: <20220908020959.1675953-1-zhirun.yan@intel.com>
Add stats for cross-core dispatching scheduler if stats collection is
enabled.
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
Signed-off-by: Cunming Liang <cunming.liang@intel.com>
Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
---
lib/graph/graph_debug.c | 4 ++++
lib/graph/graph_stats.c | 19 +++++++++++++++----
lib/graph/rte_graph.h | 3 +++
lib/graph/rte_graph_worker.h | 3 +++
4 files changed, 25 insertions(+), 4 deletions(-)
diff --git a/lib/graph/graph_debug.c b/lib/graph/graph_debug.c
index b84412f5dd..168299259b 100644
--- a/lib/graph/graph_debug.c
+++ b/lib/graph/graph_debug.c
@@ -74,6 +74,10 @@ rte_graph_obj_dump(FILE *f, struct rte_graph *g, bool all)
fprintf(f, " size=%d\n", n->size);
fprintf(f, " idx=%d\n", n->idx);
fprintf(f, " total_objs=%" PRId64 "\n", n->total_objs);
+ fprintf(f, " total_sched_objs=%" PRId64 "\n",
+ n->total_sched_objs);
+ fprintf(f, " total_sched_fail=%" PRId64 "\n",
+ n->total_sched_fail);
fprintf(f, " total_calls=%" PRId64 "\n", n->total_calls);
for (i = 0; i < n->nb_edges; i++)
fprintf(f, " edge[%d] <%s>\n", i,
diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c
index 65e12d46a3..c123ac4087 100644
--- a/lib/graph/graph_stats.c
+++ b/lib/graph/graph_stats.c
@@ -41,15 +41,18 @@ struct rte_graph_cluster_stats {
#define boarder() \
fprintf(f, "+-------------------------------+---------------+--------" \
- "-------+---------------+---------------+---------------+-" \
+ "-------+---------------+---------------+---------------+"\
+ "---------------+---------------+-" \
"----------+\n")
static inline void
print_banner(FILE *f)
{
boarder();
- fprintf(f, "%-32s%-16s%-16s%-16s%-16s%-16s%-16s\n", "|Node", "|calls",
- "|objs", "|realloc_count", "|objs/call", "|objs/sec(10E6)",
+ fprintf(f, "%-32s%-16s%-16s%-16s%-16s%-16s%-16s%-16s%-16s\n",
+ "|Node", "|calls",
+ "|objs", "|sched objs", "|sched fail",
+ "|realloc_count", "|objs/call", "|objs/sec(10E6)",
"|cycles/call|");
boarder();
}
@@ -77,8 +80,10 @@ print_node(FILE *f, const struct rte_graph_cluster_node_stats *stat)
fprintf(f,
"|%-31s|%-15" PRIu64 "|%-15" PRIu64 "|%-15" PRIu64
+ "|%-15" PRIu64 "|%-15" PRIu64
"|%-15.3f|%-15.6f|%-11.4f|\n",
- stat->name, calls, objs, stat->realloc_count, objs_per_call,
+ stat->name, calls, objs, stat->sched_objs,
+ stat->sched_fail, stat->realloc_count, objs_per_call,
objs_per_sec, cycles_per_call);
}
@@ -331,6 +336,7 @@ static inline void
cluster_node_arregate_stats(struct cluster_node *cluster)
{
uint64_t calls = 0, cycles = 0, objs = 0, realloc_count = 0;
+ uint64_t sched_objs = 0, sched_fail = 0;
struct rte_graph_cluster_node_stats *stat = &cluster->stat;
struct rte_node *node;
rte_node_t count;
@@ -338,6 +344,9 @@ cluster_node_arregate_stats(struct cluster_node *cluster)
for (count = 0; count < cluster->nb_nodes; count++) {
node = cluster->nodes[count];
+ sched_objs += node->total_sched_objs;
+ sched_fail += node->total_sched_fail;
+
calls += node->total_calls;
objs += node->total_objs;
cycles += node->total_cycles;
@@ -347,6 +356,8 @@ cluster_node_arregate_stats(struct cluster_node *cluster)
stat->calls = calls;
stat->objs = objs;
stat->cycles = cycles;
+ stat->sched_objs = sched_objs;
+ stat->sched_fail = sched_fail;
stat->ts = rte_get_timer_cycles();
stat->realloc_count = realloc_count;
}
diff --git a/lib/graph/rte_graph.h b/lib/graph/rte_graph.h
index 27fd1e6cd0..1c929d741a 100644
--- a/lib/graph/rte_graph.h
+++ b/lib/graph/rte_graph.h
@@ -208,6 +208,9 @@ struct rte_graph_cluster_node_stats {
uint64_t objs; /**< Current number of objs processed. */
uint64_t cycles; /**< Current number of cycles. */
+ uint64_t sched_objs;
+ uint64_t sched_fail;
+
uint64_t prev_ts; /**< Previous call timestamp. */
uint64_t prev_calls; /**< Previous number of calls. */
uint64_t prev_objs; /**< Previous number of processed objs. */
diff --git a/lib/graph/rte_graph_worker.h b/lib/graph/rte_graph_worker.h
index e98697d880..51f174c5c1 100644
--- a/lib/graph/rte_graph_worker.h
+++ b/lib/graph/rte_graph_worker.h
@@ -80,6 +80,9 @@ struct rte_node {
/* Fast schedule area */
unsigned int lcore_id __rte_cache_aligned; /**< Node running Lcore. */
+ uint64_t total_sched_objs; /**< Number of objects scheduled. */
+ uint64_t total_sched_fail; /**< Number of scheduled failure. */
+
/* Fast path area */
#define RTE_NODE_CTX_SZ 16
uint8_t ctx[RTE_NODE_CTX_SZ] __rte_cache_aligned; /**< Node Context. */
--
2.25.1
next prev parent reply other threads:[~2022-09-08 2:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 2:09 [RFC, v1 0/6] graph enhancement for multi-core dispatch Zhirun Yan
2022-09-08 2:09 ` [RFC, v1 1/6] graph: introduce core affinity API into graph Zhirun Yan
2022-09-08 2:09 ` [RFC, v1 2/6] graph: introduce graph clone API for other worker core Zhirun Yan
2022-09-08 2:09 ` [RFC, v1 3/6] graph: enable stream moving cross cores Zhirun Yan
2022-09-08 2:09 ` [RFC, v1 4/6] graph: enhance graph walk by cross-core dispatch Zhirun Yan
2022-09-08 5:27 ` [EXT] " Pavan Nikhilesh Bhagavatula
2022-09-15 1:52 ` Yan, Zhirun
2022-09-08 2:09 ` Zhirun Yan [this message]
2022-09-08 2:09 ` [RFC, v1 6/6] examples: add l2fwd-graph Zhirun Yan
2022-09-20 9:33 ` [RFC, v1 0/6] graph enhancement for multi-core dispatch Jerin Jacob
2022-09-30 6:41 ` Yan, Zhirun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220908020959.1675953-6-zhirun.yan@intel.com \
--to=zhirun.yan@intel.com \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).