From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DA42A00C3; Tue, 13 Sep 2022 11:27:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4EAF940156; Tue, 13 Sep 2022 11:27:45 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id A0FAD40151; Tue, 13 Sep 2022 11:27:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663061264; x=1694597264; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ClEu++KBcuZlR4R0kU3ow8/TRM1yiVb08p1TfRiO4Fw=; b=AFE4kOgKq//4BKLFKUMWnBydnv/a06vbUlc365eS8IEx5QVkyLhfbrNc 226aet9MgJ6LNfjAlsAjC83sByNmernNf5vTo4puK+njgVNfPrUKG9qNN CddsLmdCtgMtI0zJhi0RtPIrJKli5Se0VfadiWUX/vgUGmSjDWOx8E9/h b3Up+7y+vpuIXrZrWSoaV24Z7VzFCnH5F+CDV44JTvdIPzs3WgDUM9niD 9Euhvnwq56miiZ9UYYqJbwrOyY2/bXC7DzA69X7GVqoWq1+nOZxDl0CzC fJAaRrBJAT+sxLioCKbVCxLVbJ7itnCXJRrwV71s/5q36orKFIH43QuQu g==; X-IronPort-AV: E=McAfee;i="6500,9779,10468"; a="296826760" X-IronPort-AV: E=Sophos;i="5.93,312,1654585200"; d="scan'208";a="296826760" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2022 02:27:42 -0700 X-IronPort-AV: E=Sophos;i="5.93,312,1654585200"; d="scan'208";a="684793621" Received: from unknown (HELO localhost.localdomain) ([10.239.252.103]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2022 02:27:39 -0700 From: Zhichao Zeng To: dev@dpdk.org Cc: qiming.yang@intel.com, yidingx.zhou@intel.com, Zhichao Zeng , stable@dpdk.org, Bruce Richardson , Konstantin Ananyev , Jingjing Wu , Beilei Xing , Qi Zhang , Leyi Rong Subject: [PATCH v2] net/iavf: fix processing vlan tci in SSE path Date: Tue, 13 Sep 2022 17:28:41 +0800 Message-Id: <20220913092841.411307-1-zhichaox.zeng@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220722092945.4017592-1-zhichaox.zeng@intel.com> References: <20220722092945.4017592-1-zhichaox.zeng@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The SSE RX path does not process the vlan tci correctly when it's stored in L2TAG2, so the vlan tci could not be extracted from descriptor, then would not be put into mbuf either. Add processing when vlan tci is stored in L2TAG2. Fixes: 1162f5a0ef31 ("net/iavf: support flexible Rx descriptor in SSE path") Cc: stable@dpdk.org Signed-off-by: Zhichao Zeng --- v2: remove the redundant code --- drivers/net/iavf/iavf_rxtx_vec_sse.c | 93 +++++++++++++++++++++++----- 1 file changed, 78 insertions(+), 15 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_sse.c b/drivers/net/iavf/iavf_rxtx_vec_sse.c index 4a5232c1d2..17eed21f70 100644 --- a/drivers/net/iavf/iavf_rxtx_vec_sse.c +++ b/drivers/net/iavf/iavf_rxtx_vec_sse.c @@ -208,9 +208,15 @@ flex_rxd_to_fdir_flags_vec(const __m128i fdir_id0_3) return fdir_flags; } +#ifndef RTE_LIBRTE_IAVF_16BYTE_RX_DESC +static inline void +flex_desc_to_olflags_v(struct iavf_rx_queue *rxq, __m128i descs[4], __m128i descs_bh[4], + struct rte_mbuf **rx_pkts) +#else static inline void flex_desc_to_olflags_v(struct iavf_rx_queue *rxq, __m128i descs[4], struct rte_mbuf **rx_pkts) +#endif { const __m128i mbuf_init = _mm_set_epi64x(0, rxq->mbuf_initializer); __m128i rearm0, rearm1, rearm2, rearm3; @@ -286,6 +292,39 @@ flex_desc_to_olflags_v(struct iavf_rx_queue *rxq, __m128i descs[4], /* merge the flags */ flags = _mm_or_si128(flags, rss_vlan); +#ifndef RTE_LIBRTE_IAVF_16BYTE_RX_DESC + if (rxq->rx_flags & IAVF_RX_FLAGS_VLAN_TAG_LOC_L2TAG2_2) { + const __m128i l2tag2_mask = + _mm_set1_epi32(1 << IAVF_RX_FLEX_DESC_STATUS1_L2TAG2P_S); + + const __m128i vlan_tci0_1 = + _mm_unpacklo_epi32(descs_bh[0], descs_bh[1]); + const __m128i vlan_tci2_3 = + _mm_unpacklo_epi32(descs_bh[2], descs_bh[3]); + const __m128i vlan_tci0_3 = + _mm_unpacklo_epi64(vlan_tci0_1, vlan_tci2_3); + + __m128i vlan_bits = _mm_and_si128(vlan_tci0_3, l2tag2_mask); + + vlan_bits = _mm_srli_epi32(vlan_bits, + IAVF_RX_FLEX_DESC_STATUS1_L2TAG2P_S); + + const __m128i vlan_flags_shuf = + _mm_set_epi8(0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, + RTE_MBUF_F_RX_VLAN | + RTE_MBUF_F_RX_VLAN_STRIPPED, + 0); + + const __m128i vlan_flags = _mm_shuffle_epi8(vlan_flags_shuf, vlan_bits); + + /* merge with vlan_flags */ + flags = _mm_or_si128(flags, vlan_flags); + } +#endif + if (rxq->fdir_enabled) { const __m128i fdir_id0_1 = _mm_unpackhi_epi32(descs[0], descs[1]); @@ -748,6 +787,9 @@ _recv_raw_pkts_vec_flex_rxd(struct iavf_rx_queue *rxq, pos += IAVF_VPMD_DESCS_PER_LOOP, rxdp += IAVF_VPMD_DESCS_PER_LOOP) { __m128i descs[IAVF_VPMD_DESCS_PER_LOOP]; +#ifndef RTE_LIBRTE_IAVF_16BYTE_RX_DESC + __m128i descs_bh[IAVF_VPMD_DESCS_PER_LOOP]; +#endif __m128i pkt_mb0, pkt_mb1, pkt_mb2, pkt_mb3; __m128i staterr, sterr_tmp1, sterr_tmp2; /* 2 64 bit or 4 32 bit mbuf pointers in one XMM reg. */ @@ -806,8 +848,6 @@ _recv_raw_pkts_vec_flex_rxd(struct iavf_rx_queue *rxq, /* C.1 4=>2 filter staterr info only */ sterr_tmp1 = _mm_unpackhi_epi32(descs[1], descs[0]); - flex_desc_to_olflags_v(rxq, descs, &rx_pkts[pos]); - /* D.2 pkt 3,4 set in_port/nb_seg and remove crc */ pkt_mb3 = _mm_add_epi16(pkt_mb3, crc_adjust); pkt_mb2 = _mm_add_epi16(pkt_mb2, crc_adjust); @@ -821,36 +861,35 @@ _recv_raw_pkts_vec_flex_rxd(struct iavf_rx_queue *rxq, * needs to load 2nd 16B of each desc for RSS hash parsing, * will cause performance drop to get into this context. */ - if (offloads & RTE_ETH_RX_OFFLOAD_RSS_HASH) { + if (offloads & RTE_ETH_RX_OFFLOAD_RSS_HASH || + rxq->rx_flags & IAVF_RX_FLAGS_VLAN_TAG_LOC_L2TAG2_2) { /* load bottom half of every 32B desc */ - const __m128i raw_desc_bh3 = - _mm_load_si128 + descs_bh[3] = _mm_load_si128 ((void *)(&rxdp[3].wb.status_error1)); rte_compiler_barrier(); - const __m128i raw_desc_bh2 = - _mm_load_si128 + descs_bh[2] = _mm_load_si128 ((void *)(&rxdp[2].wb.status_error1)); rte_compiler_barrier(); - const __m128i raw_desc_bh1 = - _mm_load_si128 + descs_bh[1] = _mm_load_si128 ((void *)(&rxdp[1].wb.status_error1)); rte_compiler_barrier(); - const __m128i raw_desc_bh0 = - _mm_load_si128 + descs_bh[0] = _mm_load_si128 ((void *)(&rxdp[0].wb.status_error1)); + } + if (offloads & RTE_ETH_RX_OFFLOAD_RSS_HASH) { /** * to shift the 32b RSS hash value to the * highest 32b of each 128b before mask */ __m128i rss_hash3 = - _mm_slli_epi64(raw_desc_bh3, 32); + _mm_slli_epi64(descs_bh[3], 32); __m128i rss_hash2 = - _mm_slli_epi64(raw_desc_bh2, 32); + _mm_slli_epi64(descs_bh[2], 32); __m128i rss_hash1 = - _mm_slli_epi64(raw_desc_bh1, 32); + _mm_slli_epi64(descs_bh[1], 32); __m128i rss_hash0 = - _mm_slli_epi64(raw_desc_bh0, 32); + _mm_slli_epi64(descs_bh[0], 32); __m128i rss_hash_msk = _mm_set_epi32(0xFFFFFFFF, 0, 0, 0); @@ -869,6 +908,30 @@ _recv_raw_pkts_vec_flex_rxd(struct iavf_rx_queue *rxq, pkt_mb1 = _mm_or_si128(pkt_mb1, rss_hash1); pkt_mb0 = _mm_or_si128(pkt_mb0, rss_hash0); } /* if() on RSS hash parsing */ + + if (rxq->rx_flags & IAVF_RX_FLAGS_VLAN_TAG_LOC_L2TAG2_2) { + /* L2TAG2_2 */ + __m128i vlan_tci3 = _mm_slli_si128(descs_bh[3], 4); + __m128i vlan_tci2 = _mm_slli_si128(descs_bh[2], 4); + __m128i vlan_tci1 = _mm_slli_si128(descs_bh[1], 4); + __m128i vlan_tci0 = _mm_slli_si128(descs_bh[0], 4); + + const __m128i vlan_tci_msk = _mm_set_epi32(0, 0xFFFF0000, 0, 0); + + vlan_tci3 = _mm_and_si128(vlan_tci3, vlan_tci_msk); + vlan_tci2 = _mm_and_si128(vlan_tci2, vlan_tci_msk); + vlan_tci1 = _mm_and_si128(vlan_tci1, vlan_tci_msk); + vlan_tci0 = _mm_and_si128(vlan_tci0, vlan_tci_msk); + + pkt_mb3 = _mm_or_si128(pkt_mb3, vlan_tci3); + pkt_mb2 = _mm_or_si128(pkt_mb2, vlan_tci2); + pkt_mb1 = _mm_or_si128(pkt_mb1, vlan_tci1); + pkt_mb0 = _mm_or_si128(pkt_mb0, vlan_tci0); + } + + flex_desc_to_olflags_v(rxq, descs, descs_bh, &rx_pkts[pos]); +#else + flex_desc_to_olflags_v(rxq, descs, &rx_pkts[pos]); #endif /* C.2 get 4 pkts staterr value */ -- 2.25.1